Some cppcheck cleaning

Change-Id: Iac1c26d031e8196ef93cb403dc60f07e0eef6380

connectivity/workben/testmoz/main.cxx

@@ -410,7 +410,6 @@ Reference< ::com::sun::star::sdbc::XConnection> TestConnected
             break;
         default:
             return pConnection;
-            break;
     }
     pConnection =
         pDriver->connect(url,aValue);

cppu/source/AffineBridge/AffineBridge.cxx

@@ -319,9 +319,7 @@ void AffineBridge::v_leave(void)
 
 int  AffineBridge::v_isValid(rtl::OUString * pReason)
 {
-    int result = 1;
-
-    result = m_enterCount > 0;
+    int result = m_enterCount > 0;
     if (!result)
         *pReason = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("not entered"));
 

cppu/source/LogBridge/LogBridge.cxx

@@ -109,12 +109,11 @@ void LogBridge::v_leave(void)
 
 int LogBridge::v_isValid(rtl::OUString * pReason)
 {
-    int result = 1;
-
-    result = m_count > 0;
+    int result = m_count > 0;
     if (!result)
+    {
         *pReason = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("not entered"));
-
+    }
     else
     {
         result = m_threadId == osl_getThreadIdentifier(NULL);

cppu/source/UnsafeBridge/UnsafeBridge.cxx

@@ -118,12 +118,11 @@ void UnsafeBridge::v_leave(void)
 
 int UnsafeBridge::v_isValid(rtl::OUString * pReason)
 {
-    int result = 1;
-
-    result = m_count > 0;
+    int result = m_count > 0;
     if (!result)
+    {
         *pReason = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("not entered"));
-
+    }
     else
     {
         result = m_threadId == osl_getThreadIdentifier(NULL);

crashrep/source/unx/main.cxx

@@ -336,7 +336,7 @@ bool SendHTTPRequest(
 
                 if ( pszProxyServer )
                     sprintf( buffer,
-                    "POST http://%s:%d/soap/servlet/rpcrouter HTTP/1.0\r\n"
+                    "POST http://%s:%u/soap/servlet/rpcrouter HTTP/1.0\r\n"
                         "Content-Type: text/xml; charset=\"utf-8\"\r\n"
                         "Content-Length: %d\r\n"
                         "SOAPAction: \"\"\r\n\r\n",
@@ -525,21 +525,19 @@ bool send_crash_report( const boost::unordered_map< string, string >& rSettings
 
 static bool append_file( const char *filename, string& rString )
 {
-    char buf[1024];
-    bool bSuccess = false;
-
     FILE *fp = fopen( filename, "r" );
     if ( fp )
     {
+        char buf[1024];
         while (fgets(buf, sizeof(buf), fp) != NULL)
         {
             rString.append( buf );
         }
         fclose( fp );
-        bSuccess = true;
+        return true;
     }
 
-    return bSuccess;
+    return false;
 }
 
 string crash_get_details( const boost::unordered_map< string, string >& rSettings )