loplugin:unnecessaryvirtual

Change-Id: Ic044a6e4568e707022d87bc5712205fbdf084ba2
Reviewed-on: https://gerrit.libreoffice.org/52067Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

basctl/source/basicide/baside2.hxx

@@ -369,7 +369,7 @@ public:
     BasicStatus&    GetBasicStatus() { return m_aStatus; }
 
     virtual bool    IsModified () override;
-    virtual bool    IsPasteAllowed ();
+    bool            IsPasteAllowed ();
 
     void            ShowCursor( bool bOn );
 

basctl/source/inc/baside3.hxx

@@ -101,7 +101,7 @@ public:
 
     virtual void        StoreData() override;
     virtual bool        IsModified() override;
-    virtual bool        IsPasteAllowed();
+    bool                IsPasteAllowed();
 
     virtual svl::IUndoManager* GetUndoManager() override;
     // return number of pages to be printed

include/editeng/adjustitem.hxx

@@ -63,7 +63,7 @@ public:
                                   MapUnit ePresMetric,
                                   OUString &rText, const IntlWrapper& ) const override;
     virtual sal_uInt16       GetValueCount() const override;
-    virtual OUString         GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                 GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual sal_uInt16       GetEnumValue() const override;
     virtual void             SetEnumValue( sal_uInt16 nNewVal ) override;
     virtual SfxPoolItem*     Clone( SfxItemPool *pPool = nullptr ) const override;

include/editeng/charreliefitem.hxx

@@ -42,7 +42,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual sal_uInt16      GetVersion( sal_uInt16 nFileVersion ) const override;
 
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual sal_uInt16      GetValueCount() const override;
 
     virtual bool GetPresentation( SfxItemPresentation ePres,

include/editeng/cmapitem.hxx

@@ -47,7 +47,7 @@ public:
                                     OUString &rText, const IntlWrapper& ) const override;
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual sal_uInt16      GetValueCount() const override;
 
     SvxCaseMapItem& operator=(const SvxCaseMapItem& rMap)

include/editeng/crossedoutitem.hxx

@@ -48,7 +48,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*    Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&       Store(SvStream &, sal_uInt16 nItemVersion) const override;
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual sal_uInt16      GetValueCount() const override;
     virtual bool            QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool            PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;

include/editeng/escapementitem.hxx

@@ -98,7 +98,7 @@ public:
         }
 
     virtual sal_uInt16      GetValueCount() const override;
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual sal_uInt16      GetEnumValue() const override;
     virtual void            SetEnumValue( sal_uInt16 nNewVal ) override;
 };

include/editeng/formatbreakitem.hxx

@@ -51,7 +51,7 @@ public:
                                   MapUnit eCoreMetric,
                                   MapUnit ePresMetric,
                                   OUString &rText, const IntlWrapper& ) const override;
-    virtual OUString         GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                 GetValueTextByPos( sal_uInt16 nPos ) const;
 
     virtual SfxPoolItem*     Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SvStream&        Store( SvStream& , sal_uInt16 nItemVersion ) const override;

include/editeng/postitem.hxx

@@ -49,7 +49,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*    Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&       Store(SvStream &, sal_uInt16 nItemVersion) const override;
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual sal_uInt16      GetValueCount() const override;
 
     virtual bool            QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;

include/editeng/wghtitem.hxx

@@ -49,7 +49,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*    Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&       Store(SvStream &, sal_uInt16 nItemVersion) const override;
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual sal_uInt16      GetValueCount() const override;
 
     virtual bool            QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;

include/svl/aeitem.hxx

@@ -60,8 +60,8 @@ public:
     void                    RemoveValue( sal_uInt16 nValue );
 
     virtual sal_uInt16      GetValueCount() const override;
-    virtual sal_uInt16      GetValueByPos( sal_uInt16 nPos ) const;
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    sal_uInt16              GetValueByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual SfxPoolItem*    Create(SvStream &, sal_uInt16 nVersion) const override;
 };

include/svx/sdgmoitm.hxx

@@ -40,7 +40,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool* pPool = nullptr ) const override;
     virtual sal_uInt16      GetValueCount() const override;
 
-    virtual OUString        GetValueTextByPos( sal_uInt16 nPos ) const;
+    OUString                GetValueTextByPos( sal_uInt16 nPos ) const;
     virtual bool GetPresentation( SfxItemPresentation ePres,
                                   MapUnit eCoreMetric,
                                   MapUnit ePresMetric,

include/svx/sdr/properties/defaultproperties.hxx

@@ -100,7 +100,7 @@ namespace sdr
             virtual void ForceDefaultAttributes();
 
             // Scale the included ItemSet.
-            virtual void Scale(const Fraction& rScale);
+            void Scale(const Fraction& rScale);
         };
     } // end of namespace properties
 } // end of namespace sdr

include/svx/sdr/table/tablecontroller.hxx

@@ -51,7 +51,7 @@ public:
     SVX_DLLPRIVATE virtual bool onMouseButtonUp(const MouseEvent& rMEvt, vcl::Window* pWin) override;
     SVX_DLLPRIVATE virtual bool onMouseMove(const MouseEvent& rMEvt, vcl::Window* pWin) override;
 
-    SVX_DLLPRIVATE virtual bool HasMarked();
+    SVX_DLLPRIVATE bool HasMarked();
     SVX_DLLPRIVATE virtual bool DeleteMarked() override;
 
     SVX_DLLPRIVATE virtual void onSelectionHasChanged() override;

include/svx/sdtaditm.hxx

@@ -41,7 +41,7 @@ public:
     virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
 
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };

include/svx/sdtaitm.hxx

@@ -43,7 +43,7 @@ public:
     virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
     virtual void dumpAsXml(struct _xmlTextWriter* pWriter) const override;
 };
@@ -67,7 +67,7 @@ public:
     virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

include/svx/sdtakitm.hxx

@@ -85,7 +85,7 @@ public:
     virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

include/svx/sdtfsitm.hxx

@@ -44,7 +44,7 @@ public:
     virtual bool             QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool             PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString         GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString                GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
     virtual bool             HasBoolValue() const override;
     virtual bool             GetBoolValue() const override;

include/svx/svdedxv.hxx

@@ -219,7 +219,7 @@ public:
     SdrTextObj* GetTextEditObject() const { return mxTextEditObj.get(); }
 
     // info about TextEditPageView. Default is 0L.
-    virtual SdrPageView* GetTextEditPageView() const;
+    SdrPageView* GetTextEditPageView() const;
 
     // Current window of the outliners.
     void SetTextEditWin(vcl::Window* pWin);

include/svx/sxcecitm.hxx

@@ -36,7 +36,7 @@ public:
     virtual SfxPoolItem*     Clone(SfxItemPool* pPool=nullptr) const override;
     virtual sal_uInt16       GetValueCount() const override; // { return 3; }
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
 
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };

include/svx/sxctitm.hxx

@@ -33,7 +33,7 @@ public:
     SdrCaptionTypeItem(SdrCaptionType eStyle=SdrCaptionType::Type3): SfxEnumItem(SDRATTR_CAPTIONTYPE, eStyle) {}
     virtual SfxPoolItem*    Clone(SfxItemPool* pPool=nullptr) const override;
     virtual sal_uInt16      GetValueCount() const override; // { return 4; }
-    virtual OUString        GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString                GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

include/svx/sxekitm.hxx

@@ -38,7 +38,7 @@ public:
     virtual sal_uInt16   GetValueCount() const override; // { return 5; }
     virtual bool         QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool         PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
-    virtual OUString     GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString             GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

include/svx/sxmtpitm.hxx

@@ -38,7 +38,7 @@ public:
     virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 
@@ -55,7 +55,7 @@ public:
     virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

include/svx/sxmuitm.hxx

@@ -35,7 +35,7 @@ public:
     virtual bool         QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool         PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

sc/source/filter/inc/lotimpop.hxx

@@ -80,7 +80,7 @@ public:
     virtual             ~ImportLotus() override;
 
     ErrCode             parse(); //parse + CalcAfterLoad
-    virtual ErrCode     Read();
+    ErrCode             Read();
     ErrCode             Read( SvStream& );                  // special for *.fm3 files
 };
 

sc/source/ui/inc/PivotLayoutTreeList.hxx

@@ -29,7 +29,7 @@ public:
 
 protected:
     virtual void InsertEntryForSourceTarget(SvTreeListEntry* pSource, SvTreeListEntry* pTarget) override;
-    virtual void InsertEntryForItem(ScItemValue* pItemValue, sal_uLong nPosition);
+    void InsertEntryForItem(ScItemValue* pItemValue, sal_uLong nPosition);
 
     virtual void KeyInput(const KeyEvent& rKeyEvent) override;
 };

sc/source/ui/inc/docsh.hxx

@@ -299,7 +299,7 @@ public:
      * Called when the Options dialog is dismissed with the OK button, to
      * handle potentially conflicting option settings.
      */
-    virtual void    CheckConfigOptions();
+    void            CheckConfigOptions();
 
     void            PostEditView( ScEditEngineDefaulter* pEditEngine, const ScAddress& rCursorPos );
 

sc/source/ui/inc/prevwsh.hxx

@@ -62,7 +62,7 @@ private:
 
 protected:
     virtual void    Activate(bool bMDI) override;
-    virtual void    AdjustPosSizePixel( const Point &rPos, const Size &rSize );
+    void            AdjustPosSizePixel( const Point &rPos, const Size &rSize );
 
     virtual void    InnerResizePixel( const Point &rOfs, const Size &rSize, bool inplaceEditModeChange ) override;
     virtual void    OuterResizePixel( const Point &rOfs, const Size &rSize ) override;

scaddins/source/analysis/analysishelper.hxx

@@ -571,7 +571,7 @@ public:
                             // converts fVal from this unit to rFrom unit
                             // throws exception if not from same class
                            // this implementation is for proportional cases only
-    virtual double          ConvertToBase( double fVal, sal_Int16 nMatchLevel ) const;
+    double                  ConvertToBase( double fVal, sal_Int16 nMatchLevel ) const;
     virtual double          ConvertFromBase( double fVal, sal_Int16 nMatchLevel ) const override;
 };
 

sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx

@@ -45,7 +45,7 @@ public:
         used by the currently selected page of the document in the
         center pane.
     */
-    virtual void UpdateSelection();
+    void UpdateSelection();
 
     /** Copy all master pages that are to be shown into the given list.
     */

svx/inc/sxcikitm.hxx

@@ -36,7 +36,7 @@ public:
     virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

svx/inc/sxmkitm.hxx

@@ -36,7 +36,7 @@ public:
     virtual bool           QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override;
     virtual bool           PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override;
 
-    virtual OUString GetValueTextByPos(sal_uInt16 nPos) const;
+    OUString GetValueTextByPos(sal_uInt16 nPos) const;
     virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override;
 };
 

sw/source/core/inc/frame.hxx

@@ -890,7 +890,7 @@ public:
 public:
     // if writer is NULL, dumps the layout structure as XML in layout.xml
     virtual void dumpAsXml(xmlTextWriterPtr writer = nullptr) const;
-    virtual void dumpTopMostAsXml(xmlTextWriterPtr writer = nullptr) const;
+    void dumpTopMostAsXml(xmlTextWriterPtr writer = nullptr) const;
     void dumpInfosAsXml(xmlTextWriterPtr writer) const;
     virtual void dumpAsXmlAttributes(xmlTextWriterPtr writer) const;
     void dumpChildrenAsXml(xmlTextWriterPtr writer) const;