Kaydet (Commit) 8e60725a authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:countusersofdefaultparams in dbaccess

Change-Id: Ic372096785f9f6ead569b34dcc7e97f78ab9ddf8
Reviewed-on: https://gerrit.libreoffice.org/45837Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 5b88e639
......@@ -40,7 +40,7 @@ namespace dbaxml
OXMLDataSource( ODBFilter& rImport, sal_uInt16 nPrfx,
const OUString& rLName,
const css::uno::Reference< css::xml::sax::XAttributeList > & xAttrList,
const UsedFor _eUsedFor = eDataSource );
const UsedFor _eUsedFor );
virtual ~OXMLDataSource() override;
virtual SvXMLImportContextRef CreateChildContext( sal_uInt16 nPrefix,
......
......@@ -208,7 +208,7 @@ public:
const TypeIterator& operator++();
protected:
TypeIterator(const ODsnTypeCollection* _pContainer, sal_Int32 _nInitialPos = 0);
TypeIterator(const ODsnTypeCollection* _pContainer, sal_Int32 _nInitialPos);
};
......
......@@ -110,7 +110,7 @@ void OApplicationController::convertToView(const OUString& _sName)
OUString aDefaultName = ::dbaui::createDefaultName(xMeta,xTables,aName);
DynamicTableOrQueryNameCheck aNameChecker( xConnection, CommandType::TABLE );
ScopedVclPtrInstance< OSaveAsDlg > aDlg( getView(), CommandType::TABLE, getORB(), xConnection, aDefaultName, aNameChecker );
ScopedVclPtrInstance< OSaveAsDlg > aDlg( getView(), CommandType::TABLE, getORB(), xConnection, aDefaultName, aNameChecker, SADFlags::NONE );
if ( aDlg->Execute() == RET_OK )
{
OUString sName = aDlg->getName();
......
......@@ -136,7 +136,7 @@ namespace
protected:
virtual void DataChanged(const DataChangedEvent& rDCEvt) override;
public:
OTablePreviewWindow( vcl::Window* pParent, WinBits nStyle = 0 );
OTablePreviewWindow( vcl::Window* pParent, WinBits nStyle );
virtual bool EventNotify( NotifyEvent& rNEvt ) override;
};
OTablePreviewWindow::OTablePreviewWindow(vcl::Window* pParent, WinBits nStyle) : Window( pParent, nStyle)
......
......@@ -36,7 +36,7 @@ namespace dbaui
::dbaccess::ODsnTypeCollection* m_pCollection;
public:
DbuTypeCollectionItem(sal_Int16 nWhich = 0, ::dbaccess::ODsnTypeCollection* _pCollection = nullptr);
DbuTypeCollectionItem(sal_Int16 nWhich, ::dbaccess::ODsnTypeCollection* _pCollection);
DbuTypeCollectionItem(const DbuTypeCollectionItem& _rSource);
virtual bool operator==(const SfxPoolItem& _rItem) const override;
......
......@@ -33,7 +33,7 @@ namespace dbaui
short m_nPos;
OUString m_strHelpText;
public:
OPropColumnEditCtrl(vcl::Window* pParent, OUString const & _rAllowedChars, const char* pHelpId, short nPosition = -1, WinBits nWinStyle = 0);
OPropColumnEditCtrl(vcl::Window* pParent, OUString const & _rAllowedChars, const char* pHelpId, short nPosition, WinBits nWinStyle);
virtual bool IsModified() const override { return IsValueChangedFromSaved(); }
......@@ -47,7 +47,7 @@ namespace dbaui
OUString m_strHelpText;
public:
OPropEditCtrl(vcl::Window* pParent, const char* pHelpId, short nPosition = -1, WinBits nWinStyle = 0);
OPropEditCtrl(vcl::Window* pParent, const char* pHelpId, short nPosition, WinBits nWinStyle);
virtual bool IsModified() const override { return IsValueChangedFromSaved(); }
......@@ -61,7 +61,7 @@ namespace dbaui
OUString m_strHelpText;
public:
OPropNumericEditCtrl(vcl::Window* pParent, const char* pHelpId, short nPosition = -1, WinBits nWinStyle = 0);
OPropNumericEditCtrl(vcl::Window* pParent, const char* pHelpId, short nPosition, WinBits nWinStyle);
virtual bool IsModified() const override { return IsValueChangedFromSaved(); }
......@@ -77,7 +77,7 @@ namespace dbaui
OUString m_strHelpText;
public:
OPropListBoxCtrl(vcl::Window* pParent, const char* pHelpId, short nPosition = -1, WinBits nWinStyle = 0);
OPropListBoxCtrl(vcl::Window* pParent, const char* pHelpId, short nPosition, WinBits nWinStyle);
bool IsModified() const { return IsValueChangedFromSaved(); }
......
......@@ -41,7 +41,7 @@ namespace dbaui
virtual ~OJoinExchObj() override;
public:
OJoinExchObj(const OJoinExchangeData& jxdSource,bool _bFirstEntry=false);
OJoinExchObj(const OJoinExchangeData& jxdSource, bool _bFirstEntry);
// XInterface
......
......@@ -54,7 +54,7 @@ namespace dbaui
explicit OTableWindowData( const css::uno::Reference< css::beans::XPropertySet>& _xTable
,const OUString& _rComposedName
,const OUString& strTableName
,const OUString& rWinName = OUString() );
,const OUString& rWinName );
virtual ~OTableWindowData() override;
/** late constructor
......
......@@ -41,7 +41,7 @@ class OConnectionURLEdit : public Edit
bool m_bShowPrefix; // when <TRUE> the prefix will be visible, otherwise not
public:
OConnectionURLEdit(vcl::Window* pParent, WinBits _nBits,bool _bShowPrefix = false);
OConnectionURLEdit(vcl::Window* pParent, WinBits _nBits, bool _bShowPrefix);
virtual ~OConnectionURLEdit() override;
virtual void dispose() override;
......
......@@ -76,7 +76,7 @@ namespace dbaui
DECL_LINK( MenuEventListener, VclMenuEvent&, void );
public:
DBTreeListBox( vcl::Window* pParent, WinBits nWinStyle=0);
DBTreeListBox( vcl::Window* pParent, WinBits nWinStyle);
virtual ~DBTreeListBox() override;
virtual void dispose() override;
......
......@@ -62,14 +62,14 @@ namespace dbaui
const css::uno::Reference< css::sdbc::XConnection>& _xConnection,
const OUString& rDefault,
const IObjectNameCheck& _rObjectNameCheck,
SADFlags _nFlags = SADFlags::NONE);
SADFlags _nFlags);
OSaveAsDlg( vcl::Window* _pParent,
const css::uno::Reference< css::uno::XComponentContext >& _rxContext,
const OUString& _rDefault,
const OUString& _sLabel,
const IObjectNameCheck& _rObjectNameCheck,
SADFlags _nFlags = SADFlags::NONE);
SADFlags _nFlags);
virtual ~OSaveAsDlg() override;
virtual void dispose() override;
......
......@@ -38,7 +38,7 @@ class OMarkableTreeListBox : public DBTreeListBox
Link<void*,void> m_aCheckButtonHandler;
public:
OMarkableTreeListBox( vcl::Window* pParent, WinBits nWinStyle=0 );
OMarkableTreeListBox( vcl::Window* pParent, WinBits nWinStyle );
virtual ~OMarkableTreeListBox() override;
virtual void dispose() override;
......
......@@ -221,7 +221,7 @@ namespace dbaui
bool m_bActivatingForDrop;
public:
SbaGridControl(css::uno::Reference< css::uno::XComponentContext > const & _rM, Window* pParent, FmXGridPeer* _pPeer, WinBits nBits = WB_TABSTOP);
SbaGridControl(css::uno::Reference< css::uno::XComponentContext > const & _rM, Window* pParent, FmXGridPeer* _pPeer, WinBits nBits);
virtual ~SbaGridControl() override;
virtual void dispose() override;
......
......@@ -357,7 +357,7 @@ namespace
TTableDataHelper::const_iterator aFind = m_aTableData.find(sSourceName);
if ( aFind == m_aTableData.end() )
{
aFind = m_aTableData.emplace(sSourceName,std::make_shared<OTableWindowData>(xTableProp,sSourceName, sSourceName)).first;
aFind = m_aTableData.emplace(sSourceName,std::make_shared<OTableWindowData>(xTableProp,sSourceName, sSourceName, OUString())).first;
aFind->second->ShowAll(false);
}
TTableWindowData::value_type pReferencingTable = aFind->second;
......@@ -390,7 +390,7 @@ namespace
if ( m_xTables->hasByName(sReferencedTable) )
{
Reference<XPropertySet> xReferencedTable(m_xTables->getByName(sReferencedTable),UNO_QUERY);
aRefFind = m_aTableData.emplace(sReferencedTable,std::make_shared<OTableWindowData>(xReferencedTable,sReferencedTable, sReferencedTable)).first;
aRefFind = m_aTableData.emplace(sReferencedTable,std::make_shared<OTableWindowData>(xReferencedTable,sReferencedTable, sReferencedTable, OUString())).first;
aRefFind->second->ShowAll(false);
}
else
......
......@@ -306,7 +306,7 @@ bool OTableController::doSaveDoc(bool _bSaveAs)
}
DynamicTableOrQueryNameCheck aNameChecker( getConnection(), CommandType::TABLE );
ScopedVclPtrInstance< OSaveAsDlg > aDlg( getView(), CommandType::TABLE, getORB(), getConnection(), aDefaultName, aNameChecker );
ScopedVclPtrInstance< OSaveAsDlg > aDlg( getView(), CommandType::TABLE, getORB(), getConnection(), aDefaultName, aNameChecker, SADFlags::NONE );
if ( aDlg->Execute() != RET_OK )
return false;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment