loplugin:stringcopy: extensions

Change-Id: I6abf8ec16f39db9226efa7e2c7f82644da100c81

extensions/source/dbpilots/listcombowizard.cxx

@@ -181,8 +181,8 @@ namespace dbp
 
                 // build the statement to set as list source
                 OUString sStatement = "SELECT " +
-                    OUString( getSettings().sListContentField ) +  ", " + OUString( getSettings().sLinkedListField ) +
-                    " FROM " + OUString( getSettings().sListContentTable );
+                    getSettings().sListContentField +  ", " + getSettings().sLinkedListField +
+                    " FROM " + getSettings().sListContentTable;
                 Sequence< OUString > aListSource { sStatement };
                 getContext().xObjectModel->setPropertyValue("ListSource", makeAny(aListSource));
             }
@@ -196,7 +196,7 @@ namespace dbp
             }
 
             // the bound field
-            getContext().xObjectModel->setPropertyValue("DataField", makeAny(OUString(getSettings().sLinkedFormField)));
+            getContext().xObjectModel->setPropertyValue("DataField", makeAny(getSettings().sLinkedFormField));
         }
         catch(const Exception&)
         {

extensions/source/dbpilots/optiongrouplayouter.cxx

@@ -119,9 +119,9 @@ namespace dbp
                 UNO_QUERY);
 
             // the label
-            xRadioModel->setPropertyValue("Label", makeAny(OUString(*aLabelIter)));
+            xRadioModel->setPropertyValue("Label", makeAny(*aLabelIter));
             // the value
-            xRadioModel->setPropertyValue("RefValue", makeAny(OUString(*aValueIter)));
+            xRadioModel->setPropertyValue("RefValue", makeAny(*aValueIter));
 
             // default selection
             if (_rSettings.sDefaultField == *aLabelIter)
@@ -129,7 +129,7 @@ namespace dbp
 
             // the connection to the database field
             if (!_rSettings.sDBField.isEmpty())
-                xRadioModel->setPropertyValue("DataField", makeAny(OUString(_rSettings.sDBField)));
+                xRadioModel->setPropertyValue("DataField", makeAny(_rSettings.sDBField));
 
             // the name for the model
             xRadioModel->setPropertyValue("Name", makeAny(sElementsName));

extensions/source/propctrlr/fontdialog.cxx

@@ -313,8 +313,8 @@ namespace pcr
                 const SvxFontItem& rFontItem =
                     static_cast<const SvxFontItem&>(_rSet.Get(CFID_FONT));
 
-                lcl_pushBackPropertyValue( _out_properties, PROPERTY_FONT_NAME     , makeAny(OUString(rFontItem.GetFamilyName())));
-                lcl_pushBackPropertyValue( _out_properties, PROPERTY_FONT_STYLENAME, makeAny(OUString(rFontItem.GetStyleName())));
+                lcl_pushBackPropertyValue( _out_properties, PROPERTY_FONT_NAME     , makeAny(rFontItem.GetFamilyName()));
+                lcl_pushBackPropertyValue( _out_properties, PROPERTY_FONT_STYLENAME, makeAny(rFontItem.GetStyleName()));
                 lcl_pushBackPropertyValue( _out_properties, PROPERTY_FONT_FAMILY   , makeAny((sal_Int16)rFontItem.GetFamily()));
                 lcl_pushBackPropertyValue( _out_properties, PROPERTY_FONT_CHARSET  , makeAny((sal_Int16)rFontItem.GetCharSet()));
             }

extensions/source/propctrlr/formcomponenthandler.cxx

@@ -523,7 +523,7 @@ namespace pcr
                 if ( !xDatabaseContext->hasByName( sControlValue ) )
                 {
                     ::svt::OFileNotation aTransformer(sControlValue);
-                    aPropertyValue <<= OUString( aTransformer.get( ::svt::OFileNotation::N_URL ) );
+                    aPropertyValue <<= aTransformer.get( ::svt::OFileNotation::N_URL );
                 }
             }
         }

extensions/source/propctrlr/standardcontrol.cxx

@@ -812,7 +812,7 @@ namespace pcr
 
     Any SAL_CALL OComboboxControl::getValue()
     {
-        return makeAny( OUString( getTypedControlWindow()->GetText() ) );
+        return makeAny( getTypedControlWindow()->GetText() );
     }
 
 

extensions/source/resource/oooresourceloader.cxx

@@ -70,7 +70,7 @@ namespace extensions { namespace resource
     {
         OSL_PRECOND( _resourceManager.IsAvailable( getResourceType(), _resourceId ), "StringResourceAccess::getResource: precondition not met!" );
         Any aResource;
-        aResource <<= OUString( _resourceManager.ReadString( _resourceId ) );
+        aResource <<= _resourceManager.ReadString( _resourceId );
         return aResource;
     }