Kaydet (Commit) 988477e2 authored tarafından Chris Sherlock's avatar Chris Sherlock

vcl: renamed OutputDevice::PaintLineGeometryWithEvtlExpand()

I asked on the LO dev mailing list what Evtl means and what is being
expanded, and Michael Stahl kindly responded:

>  "Evtl" usually means German "eventuell" which means "possible" or
>  "optional" (i.e. totally different meaning from English "eventual").

So in other words, it means paint using line geometry and optionally
expand. Or in other words, it just draws a line using a B2DPolyPolygon.
Thus, I have renamed it to drawLine(), which is a private function of
OutputDevice. I think this makes it somewhat clearer :-)

Change-Id: I7eec23c61eda9dc1074922f5f2f67eacbc7fd725
Reviewed-on: https://gerrit.libreoffice.org/12264Reviewed-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
Tested-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
üst 167ff1e7
...@@ -687,7 +687,7 @@ private: ...@@ -687,7 +687,7 @@ private:
/** Helper for line geometry paint with support for graphic expansion (pattern and fat_to_area) /** Helper for line geometry paint with support for graphic expansion (pattern and fat_to_area)
*/ */
SAL_DLLPRIVATE void PaintLineGeometryWithEvtlExpand( const LineInfo& rInfo, basegfx::B2DPolyPolygon aLinePolyPolygon ); SAL_DLLPRIVATE void drawLine( basegfx::B2DPolyPolygon aLinePolyPolygon, const LineInfo& rInfo );
///@} ///@}
......
...@@ -74,7 +74,7 @@ void OutputDevice::DrawLine( const Point& rStartPt, const Point& rEndPt, ...@@ -74,7 +74,7 @@ void OutputDevice::DrawLine( const Point& rStartPt, const Point& rEndPt,
aLinePolygon.append(basegfx::B2DPoint(aStartPt.X(), aStartPt.Y())); aLinePolygon.append(basegfx::B2DPoint(aStartPt.X(), aStartPt.Y()));
aLinePolygon.append(basegfx::B2DPoint(aEndPt.X(), aEndPt.Y())); aLinePolygon.append(basegfx::B2DPoint(aEndPt.X(), aEndPt.Y()));
PaintLineGeometryWithEvtlExpand(aInfo, basegfx::B2DPolyPolygon(aLinePolygon)); drawLine( basegfx::B2DPolyPolygon(aLinePolygon), aInfo );
} }
else else
{ {
...@@ -145,9 +145,7 @@ void OutputDevice::DrawLine( const Point& rStartPt, const Point& rEndPt ) ...@@ -145,9 +145,7 @@ void OutputDevice::DrawLine( const Point& rStartPt, const Point& rEndPt )
mpAlphaVDev->DrawLine( rStartPt, rEndPt ); mpAlphaVDev->DrawLine( rStartPt, rEndPt );
} }
void OutputDevice::PaintLineGeometryWithEvtlExpand( void OutputDevice::drawLine( basegfx::B2DPolyPolygon aLinePolyPolygon, const LineInfo& rInfo )
const LineInfo& rInfo,
basegfx::B2DPolyPolygon aLinePolyPolygon)
{ {
const bool bTryAA((mnAntialiasing & ANTIALIASING_ENABLE_B2DDRAW) const bool bTryAA((mnAntialiasing & ANTIALIASING_ENABLE_B2DDRAW)
&& mpGraphics->supportsOperation(OutDevSupport_B2DDraw) && mpGraphics->supportsOperation(OutDevSupport_B2DDraw)
......
...@@ -244,7 +244,7 @@ void OutputDevice::drawPolyLine(const Polygon& rPoly, const LineInfo& rLineInfo) ...@@ -244,7 +244,7 @@ void OutputDevice::drawPolyLine(const Polygon& rPoly, const LineInfo& rLineInfo)
if(bDashUsed || bLineWidthUsed) if(bDashUsed || bLineWidthUsed)
{ {
PaintLineGeometryWithEvtlExpand(aInfo, basegfx::B2DPolyPolygon(aPoly.getB2DPolygon())); drawLine ( basegfx::B2DPolyPolygon(aPoly.getB2DPolygon()), aInfo );
} }
else else
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment