Kaydet (Commit) 99862627 authored tarafından Takeshi Abe's avatar Takeshi Abe

cppcheck: possibly efficient checking for emptiness

üst 13021dae
...@@ -96,7 +96,7 @@ sal_Bool SAL_CALL CFilterContainer::addFilter( ...@@ -96,7 +96,7 @@ sal_Bool SAL_CALL CFilterContainer::addFilter(
sal_Bool SAL_CALL CFilterContainer::delFilter( const OUString& aName ) sal_Bool SAL_CALL CFilterContainer::delFilter( const OUString& aName )
{ {
OSL_ASSERT( m_vFilters.size() > 0 ); OSL_ASSERT( !m_vFilters.empty() );
sal_Int32 pos = getFilterTagPos( aName ); sal_Int32 pos = getFilterTagPos( aName );
if ( pos > -1 ) if ( pos > -1 )
...@@ -134,7 +134,7 @@ void SAL_CALL CFilterContainer::empty() ...@@ -134,7 +134,7 @@ void SAL_CALL CFilterContainer::empty()
sal_Bool SAL_CALL CFilterContainer::getFilter( const OUString& aName, OUString& theFilter ) const sal_Bool SAL_CALL CFilterContainer::getFilter( const OUString& aName, OUString& theFilter ) const
{ {
OSL_PRECOND( m_vFilters.size() > 0, "Empty filter container" ); OSL_PRECOND( !m_vFilters.empty() , "Empty filter container" );
sal_Int32 pos = getFilterTagPos( aName ); sal_Int32 pos = getFilterTagPos( aName );
...@@ -188,7 +188,7 @@ sal_Int32 SAL_CALL CFilterContainer::getFilterPos( const OUString& aName ) const ...@@ -188,7 +188,7 @@ sal_Int32 SAL_CALL CFilterContainer::getFilterPos( const OUString& aName ) const
sal_Int32 SAL_CALL CFilterContainer::getFilterTagPos( const OUString& aName ) const sal_Int32 SAL_CALL CFilterContainer::getFilterTagPos( const OUString& aName ) const
{ {
if ( m_vFilters.size( ) > 0 ) if ( !m_vFilters.empty() )
{ {
sal_Int32 i = 0; sal_Int32 i = 0;
FILTER_VECTOR_T::const_iterator iter; FILTER_VECTOR_T::const_iterator iter;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment