vcl: dispose of more Window sub-classes, particularly top-level windows.

Change-Id: If8311e5cf3193fd1434c3af5225367ca8e91fc6d

include/vcl/btndlg.hxx

@@ -40,6 +40,7 @@ class VCL_DLLPUBLIC ButtonDialog : public Dialog
 public:
                         ButtonDialog( vcl::Window* pParent, WinBits nStyle = WB_STDDIALOG );
     virtual             ~ButtonDialog();
+    virtual void        dispose() SAL_OVERRIDE;
 
     virtual void        Resize() SAL_OVERRIDE;
     virtual void        StateChanged( StateChangedType nStateChange ) SAL_OVERRIDE;

include/vcl/floatwin.hxx

@@ -122,6 +122,7 @@ public:
     explicit        FloatingWindow(vcl::Window* pParent, const OString& rID, const OUString& rUIXMLDescription,
                                    const css::uno::Reference<css::frame::XFrame> &rFrame = css::uno::Reference<css::frame::XFrame>());
     virtual         ~FloatingWindow();
+    virtual void    dispose() SAL_OVERRIDE;
 
     virtual bool    Notify( NotifyEvent& rNEvt ) SAL_OVERRIDE;
     virtual void    StateChanged( StateChangedType nType ) SAL_OVERRIDE;

include/vcl/introwin.hxx

@@ -30,8 +30,10 @@ private:
     SAL_DLLPRIVATE void ImplInitIntroWindowData();
 
 public:
-    IntroWindow();
-    virtual ~IntroWindow();
+                 IntroWindow();
+    virtual      ~IntroWindow();
+    virtual void dispose() SAL_OVERRIDE;
+
 };
 
 #endif // INCLUDED_VCL_INTROWIN_HXX

include/vcl/msgbox.hxx

@@ -48,7 +48,8 @@ protected:
 public:
                         MessBox( vcl::Window* pParent, WinBits nStyle,
                                  const OUString& rTitle, const OUString& rMessage );
-                        virtual ~MessBox();
+    virtual             ~MessBox();
+    virtual void        dispose() SAL_OVERRIDE;
 
     virtual void        StateChanged( StateChangedType nStateChange ) SAL_OVERRIDE;
 

include/vcl/openglwin.hxx

@@ -33,8 +33,10 @@ public:
 class VCLOPENGL_DLLPUBLIC OpenGLWindow : public vcl::Window
 {
 public:
-    OpenGLWindow(vcl::Window* pParent);
-    virtual ~OpenGLWindow();
+                   OpenGLWindow(vcl::Window* pParent);
+    virtual        ~OpenGLWindow();
+    virtual void   dispose() SAL_OVERRIDE;
+
     OpenGLContext& getContext();
 
     void setRenderer(IRenderer* pRenderer);

include/vcl/syschild.hxx

@@ -42,6 +42,7 @@ public:
                             // create a SystemChildWindow using the given SystemWindowData
     explicit                SystemChildWindow( vcl::Window* pParent, WinBits nStyle, SystemWindowData *pData, bool bShow = true );
     virtual                 ~SystemChildWindow();
+    virtual void            dispose() SAL_OVERRIDE;
 
     const SystemEnvData*    GetSystemData() const;
 

include/vcl/syswin.hxx

@@ -172,7 +172,9 @@ protected:
 
     SAL_DLLPRIVATE void DoInitialLayout();
 public:
-                    virtual ~SystemWindow();
+    virtual         ~SystemWindow();
+    virtual void    dispose() SAL_OVERRIDE;
+
     virtual bool    Notify( NotifyEvent& rNEvt ) SAL_OVERRIDE;
     virtual bool    PreNotify( NotifyEvent& rNEvt ) SAL_OVERRIDE;
 

include/vcl/wrkwin.hxx

@@ -66,6 +66,7 @@ public:
     explicit        WorkWindow( vcl::Window* pParent, const ::com::sun::star::uno::Any& aSystemWorkWindowToken, WinBits nStyle = WB_STDWORK );
     explicit        WorkWindow( SystemParentData* pParent ); // Not in the REMOTE-Version
     virtual         ~WorkWindow();
+    virtual void    dispose() SAL_OVERRIDE;
 
     virtual bool    Close() SAL_OVERRIDE;
 

vcl/inc/brdwin.hxx

@@ -83,14 +83,14 @@ class ImplBorderWindow : public vcl::Window
 
 private:
     ImplBorderWindowView*   mpBorderView;
-    vcl::Window*                 mpMenuBarWindow;
+    vcl::Window*            mpMenuBarWindow;
     long                    mnMinWidth;
     long                    mnMinHeight;
     long                    mnMaxWidth;
     long                    mnMaxHeight;
     long                    mnRollHeight;
     long                    mnOrgMenuHeight;
-    sal_uInt16                  mnTitleType;
+    sal_uInt16              mnTitleType;
     WindowBorderStyle       mnBorderStyle;
     bool                    mbFloatWindow;
     bool                    mbSmallOutBorder;
@@ -121,7 +121,8 @@ public:
                                               sal_uInt16 nTypeStyle = 0 );
                             ImplBorderWindow( vcl::Window* pParent, WinBits nStyle = 0,
                                               sal_uInt16 nTypeStyle = 0 );
-                            virtual ~ImplBorderWindow();
+    virtual                 ~ImplBorderWindow();
+    virtual void            dispose() SAL_OVERRIDE;
 
     virtual void            MouseMove( const MouseEvent& rMEvt ) SAL_OVERRIDE;
     virtual void            MouseButtonDown( const MouseEvent& rMEvt ) SAL_OVERRIDE;

vcl/source/window/brdwin.cxx

@@ -1845,8 +1845,16 @@ ImplBorderWindow::ImplBorderWindow( vcl::Window* pParent, WinBits nStyle ,
 }
 
 ImplBorderWindow::~ImplBorderWindow()
+{
+    dispose();
+}
+
+void ImplBorderWindow::dispose()
 {
     delete mpBorderView;
+    mpBorderView = NULL;
+
+    vcl::Window::dispose();
 }
 
 void ImplBorderWindow::MouseMove( const MouseEvent& rMEvt )

vcl/source/window/btndlg.cxx

@@ -58,12 +58,20 @@ ButtonDialog::ButtonDialog( vcl::Window* pParent, WinBits nStyle ) :
 }
 
 ButtonDialog::~ButtonDialog()
+{
+    dispose();
+}
+
+void ButtonDialog::dispose()
 {
     for ( btn_iterator it = maItemList.begin(); it != maItemList.end(); ++it)
     {
         if ( it->mpPushButton && it->mbOwnButton )
             delete it->mpPushButton;
     }
+    maItemList.clear();
+
+    Dialog::dispose();
 }
 
 PushButton* ButtonDialog::ImplCreatePushButton( sal_uInt16 nBtnFlags )

vcl/source/window/dialog.cxx

@@ -538,6 +538,8 @@ void Dialog::settingOptimalLayoutSize(Window *pBox)
 
 Dialog::~Dialog()
 {
+    dispose();
+
     delete mpDialogImpl;
     mpDialogImpl = NULL;
 }

vcl/source/window/floatwin.cxx

@@ -185,18 +185,30 @@ void FloatingWindow::doDeferredInit(WinBits nBits)
 
 FloatingWindow::~FloatingWindow()
 {
-    if( mbPopupModeCanceled )
-        // indicates that ESC key was pressed
-        // will be handled in Window::ImplGrabFocus()
-        SetDialogControlFlags( GetDialogControlFlags() | WINDOW_DLGCTRL_FLOATWIN_POPUPMODEEND_CANCEL );
+    dispose();
+}
+
+void FloatingWindow::dispose()
+{
+    if (mpImplData)
+    {
+        if( mbPopupModeCanceled )
+            // indicates that ESC key was pressed
+            // will be handled in Window::ImplGrabFocus()
+            SetDialogControlFlags( GetDialogControlFlags() | WINDOW_DLGCTRL_FLOATWIN_POPUPMODEEND_CANCEL );
 
-    if ( IsInPopupMode() )
-        EndPopupMode( FLOATWIN_POPUPMODEEND_CANCEL | FLOATWIN_POPUPMODEEND_CLOSEALL | FLOATWIN_POPUPMODEEND_DONTCALLHDL );
+        if ( IsInPopupMode() )
+            EndPopupMode( FLOATWIN_POPUPMODEEND_CANCEL | FLOATWIN_POPUPMODEEND_CLOSEALL | FLOATWIN_POPUPMODEEND_DONTCALLHDL );
 
-    if ( mnPostId )
-        Application::RemoveUserEvent( mnPostId );
+        if ( mnPostId )
+            Application::RemoveUserEvent( mnPostId );
+        mnPostId = 0;
+    }
 
     delete mpImplData;
+    mpImplData = NULL;
+
+    SystemWindow::dispose();
 }
 
 Point FloatingWindow::CalcFloatingPosition( vcl::Window* pWindow, const Rectangle& rRect, sal_uLong nFlags, sal_uInt16& rArrangeIndex )

vcl/source/window/introwin.cxx

@@ -40,6 +40,12 @@ IntroWindow::IntroWindow( ) :
 
 IntroWindow::~IntroWindow()
 {
+    dispose();
+}
+
+void IntroWindow::dispose()
+{
+    // FIXME: really we should have a dispose & a ref-ptr there [!] ...
     ImplSVData* pSVData = ImplGetSVData();
     if ( pSVData->mpIntroWindow == this )
         pSVData->mpIntroWindow = NULL;

vcl/source/window/menubarwindow.cxx

@@ -164,9 +164,20 @@ MenuBarWindow::MenuBarWindow( vcl::Window* pParent ) :
 }
 
 MenuBarWindow::~MenuBarWindow()
+{
+    dispose();
+}
+
+void MenuBarWindow::dispose()
 {
     aCloseBtn->RemoveEventListener(LINK(this, MenuBarWindow, ToolboxEventHdl));
     RemoveEventListener(LINK(this, MenuBarWindow, ShowHideListener));
+
+    aCloseBtn.disposeAndClear();
+    aFloatBtn.disposeAndClear();
+    aHideBtn.disposeAndClear();
+
+    Window::dispose();
 }
 
 void MenuBarWindow::SetMenu( MenuBar* pMen )
@@ -1057,15 +1068,6 @@ void MenuBarWindow::GetFocus()
     }
 }
 
-void MenuBarWindow::dispose()
-{
-    aCloseBtn.disposeAndClear();
-    aFloatBtn.disposeAndClear();
-    aHideBtn.disposeAndClear();
-    Window::dispose();
-}
-
-
 ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible > MenuBarWindow::CreateAccessible()
 {
     ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible > xAcc;

vcl/source/window/menubarwindow.hxx

@@ -105,11 +105,11 @@ private:
     void            DataChanged( const DataChangedEvent& rDCEvt ) SAL_OVERRIDE;
     void            LoseFocus() SAL_OVERRIDE;
     void            GetFocus() SAL_OVERRIDE;
-    virtual void    dispose() SAL_OVERRIDE;
 
 public:
                     MenuBarWindow( vcl::Window* pParent );
-                    virtual ~MenuBarWindow();
+    virtual         ~MenuBarWindow();
+    virtual void    dispose() SAL_OVERRIDE;
 
     virtual void    ShowButtons(bool bClose, bool bFloat, bool bHide) SAL_OVERRIDE;
 

vcl/source/window/menufloatingwindow.cxx

@@ -103,8 +103,15 @@ void MenuFloatingWindow::doShutdown()
 }
 
 MenuFloatingWindow::~MenuFloatingWindow()
+{
+    dispose();
+}
+
+void MenuFloatingWindow::dispose()
 {
     doShutdown();
+
+    FloatingWindow::dispose();
 }
 
 void MenuFloatingWindow::Resize()

vcl/source/window/menufloatingwindow.hxx

@@ -80,7 +80,8 @@ protected:
 
 public:
                     MenuFloatingWindow( Menu* pMenu, vcl::Window* pParent, WinBits nStyle );
-                    virtual ~MenuFloatingWindow();
+    virtual         ~MenuFloatingWindow();
+    virtual void    dispose() SAL_OVERRIDE;
 
             void    doShutdown();
 

vcl/source/window/msgbox.cxx

@@ -150,10 +150,22 @@ MessBox::MessBox( vcl::Window* pParent, WinBits nStyle,
 }
 
 MessBox::~MessBox()
+{
+    dispose();
+}
+
+void MessBox::dispose()
 {
     delete mpVCLMultiLineEdit;
+    mpVCLMultiLineEdit = NULL;
+
     delete mpFixedImage;
+    mpFixedImage = NULL;
+
     delete mpCheckBox;
+    mpCheckBox = NULL;
+
+    ButtonDialog::dispose();
 }
 
 void MessBox::ImplPosControls()

vcl/source/window/openglwin.cxx

@@ -40,9 +40,17 @@ OpenGLWindow::OpenGLWindow(vcl::Window* pParent):
 }
 
 OpenGLWindow::~OpenGLWindow()
+{
+    dispose();
+}
+
+void OpenGLWindow::dispose()
 {
     if(mpRenderer)
         mpRenderer->contextDestroyed();
+    mpRenderer = NULL;
+
+    Window::dispose();
 }
 
 OpenGLContext& OpenGLWindow::getContext()

vcl/source/window/scrwnd.cxx

@@ -83,9 +83,17 @@ ImplWheelWindow::ImplWheelWindow( vcl::Window* pParent ) :
 }
 
 ImplWheelWindow::~ImplWheelWindow()
+{
+    dispose();
+}
+
+void ImplWheelWindow::dispose()
 {
     ImplStop();
     delete mpTimer;
+    mpTimer = NULL;
+
+    FloatingWindow::dispose();
 }
 
 void ImplWheelWindow::ImplStop()

vcl/source/window/scrwnd.hxx

@@ -70,7 +70,8 @@ protected:
 public:
 
                         ImplWheelWindow( vcl::Window* pParent );
-                        virtual ~ImplWheelWindow();
+    virtual             ~ImplWheelWindow();
+    virtual void        dispose() SAL_OVERRIDE;
 
     void                ImplStop();
     void                ImplSetWheelMode( sal_uLong nWheelMode );

vcl/source/window/syschild.cxx

@@ -132,13 +132,19 @@ SystemChildWindow::SystemChildWindow( vcl::Window* pParent, WinBits nStyle, Syst
 }
 
 SystemChildWindow::~SystemChildWindow()
+{
+    dispose();
+}
+
+void SystemChildWindow::dispose()
 {
     Hide();
-    if ( mpWindowImpl->mpSysObj )
+    if ( mpWindowImpl && mpWindowImpl->mpSysObj )
     {
         ImplGetSVData()->mpDefInst->DestroyObject( mpWindowImpl->mpSysObj );
         mpWindowImpl->mpSysObj = NULL;
     }
+    Window::dispose();
 }
 
 const SystemEnvData* SystemChildWindow::GetSystemData() const

vcl/source/window/syswin.cxx

@@ -105,13 +105,21 @@ void SystemWindow::loadUI(vcl::Window* pParent, const OString& rID, const OUStri
 }
 
 SystemWindow::~SystemWindow()
+{
+    dispose();
+}
+
+void SystemWindow::dispose()
 {
     maLayoutIdle.Stop();
     delete mpImplData;
     mpImplData = NULL;
+
     // Hack to make sure code called from base ~Window does not interpret this
     // as a SystemWindow (which it no longer is by then):
     mpWindowImpl->mbSysWin = false;
+
+    Window::dispose();
 }
 
 bool SystemWindow::Notify( NotifyEvent& rNEvt )

vcl/source/window/wrkwin.cxx

@@ -119,6 +119,12 @@ WorkWindow::~WorkWindow()
         pSVData->maWinData.mpAppWin = NULL;
         Application::Quit();
     }
+    dispose();
+}
+
+void WorkWindow::dispose()
+{
+    SystemWindow::dispose();
 }
 
 void WorkWindow::ShowFullScreenMode( bool bFullScreenMode )