-Wextra for compiler plugins

Change-Id: I246dcf1d2c099c510435d21f0dd47e3c098456f2

compilerplugins/Makefile-clang.mk

@@ -11,7 +11,7 @@
 # You may occassionally want to override some of these
 
 # Compile flags ('make CLANGCXXFLAGS=-g' if you need to debug the plugin)
-CLANGCXXFLAGS=-O2 -Wall -g
+CLANGCXXFLAGS=-O2 -Wall -Wextra -g
 
 # The uninteresting rest.
 

compilerplugins/clang/pluginhandler.cxx

@@ -216,12 +216,12 @@ void PluginHandler::HandleTranslationUnit( ASTContext& context )
         }
     }
 
-ASTConsumer* LibreOfficeAction::CreateASTConsumer( CompilerInstance& Compiler, StringRef InFile )
+ASTConsumer* LibreOfficeAction::CreateASTConsumer( CompilerInstance& Compiler, StringRef )
     {
     return new PluginHandler( Compiler.getASTContext(), _args );
     }
 
-bool LibreOfficeAction::ParseArgs( const CompilerInstance& CI, const vector< string >& args )
+bool LibreOfficeAction::ParseArgs( const CompilerInstance&, const vector< string >& args )
     {
     _args = args;
     return true;

compilerplugins/clang/postfixincrementfix.cxx

@@ -125,7 +125,7 @@ bool PostfixIncrementFix::canChangePostfixToPrefix( const CXXOperatorCallExpr* o
     }
 
 bool PostfixIncrementFix::canChangeInConditionStatement( const CXXOperatorCallExpr* op, const Expr* condition,
-    const StmtParents& parents, int parent_pos )
+    const StmtParents& parents, unsigned int parent_pos )
     {
     // cannot be changed in condition, can be changed in statements
     if( parent_pos == parents.size() - 1 )

compilerplugins/clang/postfixincrementfix.hxx

@@ -30,7 +30,7 @@ class PostfixIncrementFix
         void fixPostfixOperators( const Stmt* stmt, StmtParents& parents );
         bool canChangePostfixToPrefix( const CXXOperatorCallExpr* op, StmtParents& parents, int parent_pos );
         bool canChangeInConditionStatement( const CXXOperatorCallExpr* op, const Expr* condition,
-            const StmtParents& parents, int parent_pos );
+            const StmtParents& parents, unsigned int parent_pos );
         bool shouldDoChange( const Expr* op );
     };