loplugin:passstuffbyref in canvas

Change-Id: Idde288ab4bb7935e5da2a84190fd4b398961d358

canvas/source/cairo/cairo_devicehelper.hxx

@@ -91,7 +91,7 @@ namespace cairocanvas
         void dumpScreenContent() const;
 
         OutputDevice* getOutputDevice() const { return mpRefDevice; }
-        ::cairo::SurfaceSharedPtr getSurface() { return mpSurface; }
+        const ::cairo::SurfaceSharedPtr& getSurface() { return mpSurface; }
         ::cairo::SurfaceSharedPtr createSurface( const ::basegfx::B2ISize& rSize, int aContent = CAIRO_CONTENT_COLOR_ALPHA );
         ::cairo::SurfaceSharedPtr createSurface( BitmapSystemData& rData, const Size& rSize );
 

canvas/source/cairo/cairo_spritedevicehelper.hxx

@@ -60,7 +60,7 @@ namespace cairocanvas
         void notifySizeUpdate( const css::awt::Rectangle& rBounds );
         void setSize( const ::basegfx::B2ISize& rSize );
 
-        ::cairo::SurfaceSharedPtr getBufferSurface() { return mpBufferSurface; }
+        const ::cairo::SurfaceSharedPtr& getBufferSurface() { return mpBufferSurface; }
         ::cairo::SurfaceSharedPtr getWindowSurface();
         ::cairo::SurfaceSharedPtr createSurface( const ::basegfx::B2ISize& rSize, int aContent = CAIRO_CONTENT_COLOR_ALPHA );
         ::cairo::SurfaceSharedPtr createSurface( BitmapSystemData& rData, const Size& rSize );

canvas/source/opengl/ogl_bitmapcanvashelper.hxx

@@ -49,7 +49,7 @@ namespace oglcanvas
         // BitmapCanvasHelper functionality
         // ================================
 
-        css::geometry::IntegerSize2D getSize() { return maSize; }
+        const css::geometry::IntegerSize2D& getSize() { return maSize; }
 
         css::uno::Reference< css::rendering::XBitmapCanvas > queryBitmapCanvas();
 

canvas/source/tools/pagemanager.hxx

@@ -41,7 +41,7 @@ namespace canvas
         // accelerated page, e.g. OpenGL texture.
         ::basegfx::B2ISize getPageSize() const;
 
-        canvas::IRenderModuleSharedPtr getRenderModule() const { return mpRenderModule; }
+        const canvas::IRenderModuleSharedPtr& getRenderModule() const { return mpRenderModule; }
 
         FragmentSharedPtr allocateSpace( const ::basegfx::B2ISize& rSize );
         void              free( const FragmentSharedPtr& pFragment );

canvas/source/vcl/devicehelper.hxx

@@ -77,7 +77,7 @@ namespace vclcanvas
         css::uno::Reference<
             css::rendering::XColorSpace > getColorSpace() const;
 
-        OutDevProviderSharedPtr getOutDev() const { return mpOutDev; }
+        const OutDevProviderSharedPtr& getOutDev() const { return mpOutDev; }
 
         /** called when DumpScreenContent property is enabled on
             XGraphicDevice, and writes out bitmaps of current screen.

canvas/source/vcl/spritedevicehelper.hxx

@@ -54,7 +54,7 @@ namespace vclcanvas
         css::uno::Any getSurfaceHandle() const;
 
         void dumpScreenContent() const;
-        BackBufferSharedPtr getBackBuffer() const { return mpBackBuffer; }
+        const BackBufferSharedPtr& getBackBuffer() const { return mpBackBuffer; }
 
         void notifySizeUpdate( const css::awt::Rectangle& rBounds );
 

include/canvas/base/bufferedgraphicdevicebase.hxx

@@ -159,7 +159,7 @@ namespace canvas
             }
         }
 
-        css::uno::Reference< css::awt::XWindow2 > getWindow() const
+        const css::uno::Reference< css::awt::XWindow2 >& getWindow() const
         {
             return mxWindow;
         }

include/canvas/base/canvascustomspritehelper.hxx

@@ -90,8 +90,8 @@ namespace canvas
 
         // Sprite
         bool isAreaUpdateOpaque( const ::basegfx::B2DRange& rUpdateArea ) const;
-        ::basegfx::B2DPoint  getPosPixel() const { return maPosition; }
-        ::basegfx::B2DVector getSizePixel() const { return maSize; }
+        const ::basegfx::B2DPoint& getPosPixel() const { return maPosition; }
+        const ::basegfx::B2DVector& getSizePixel() const { return maSize; }
         ::basegfx::B2DRange  getUpdateArea() const;
         double               getPriority() const { return mfPriority; }
 

include/canvas/spriteredrawmanager.hxx

@@ -124,7 +124,7 @@ namespace canvas
             const Sprite::Reference&    getSprite() const { return mpSprite; }
 
             // #i61843# need to return by value here, to be used safely from bind
-            ::basegfx::B2DRange         getUpdateArea() const { return maTrueUpdateArea; }
+            const ::basegfx::B2DRange&  getUpdateArea() const { return maTrueUpdateArea; }
             bool                        needsUpdate() const { return mbNeedsUpdate; }
             bool                        isPureMove() const { return mbIsPureMove; }
 
@@ -177,7 +177,7 @@ namespace canvas
             {
             }
 
-            Sprite::Reference getSprite() const { return mpAffectedSprite; }
+            const Sprite::Reference& getSprite() const { return mpAffectedSprite; }
 
             ChangeType          meChangeType;
             Sprite::Reference   mpAffectedSprite;