Kaydet (Commit) 9bd5ba2d authored tarafından Miklos Vajna's avatar Miklos Vajna

sw: prefix members of XMLRedlineImportHelper

Change-Id: I7e45e30f8e316c49d1fe2311baf82a5729905a3c
Reviewed-on: https://gerrit.libreoffice.org/72702
Tested-by: Jenkins
Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.com>
üst 729c8d13
...@@ -241,22 +241,22 @@ XMLRedlineImportHelper::XMLRedlineImportHelper( ...@@ -241,22 +241,22 @@ XMLRedlineImportHelper::XMLRedlineImportHelper(
const Reference<XPropertySet> & rImportInfo ) const Reference<XPropertySet> & rImportInfo )
: m_rImport(rImport) : m_rImport(rImport)
, ,
sInsertion( GetXMLToken( XML_INSERTION )), m_sInsertion( GetXMLToken( XML_INSERTION )),
sDeletion( GetXMLToken( XML_DELETION )), m_sDeletion( GetXMLToken( XML_DELETION )),
sFormatChange( GetXMLToken( XML_FORMAT_CHANGE )), m_sFormatChange( GetXMLToken( XML_FORMAT_CHANGE )),
aRedlineMap(), m_aRedlineMap(),
bIgnoreRedlines(bNoRedlinesPlease), m_bIgnoreRedlines(bNoRedlinesPlease),
xModelPropertySet(rModel), m_xModelPropertySet(rModel),
xImportInfoPropertySet(rImportInfo) m_xImportInfoPropertySet(rImportInfo)
{ {
// check to see if redline mode is handled outside of component // check to see if redline mode is handled outside of component
bool bHandleShowChanges = true; bool bHandleShowChanges = true;
bool bHandleRecordChanges = true; bool bHandleRecordChanges = true;
bool bHandleProtectionKey = true; bool bHandleProtectionKey = true;
if ( xImportInfoPropertySet.is() ) if ( m_xImportInfoPropertySet.is() )
{ {
Reference<XPropertySetInfo> xInfo = Reference<XPropertySetInfo> xInfo =
xImportInfoPropertySet->getPropertySetInfo(); m_xImportInfoPropertySet->getPropertySetInfo();
bHandleShowChanges = ! xInfo->hasPropertyByName( g_sShowChanges ); bHandleShowChanges = ! xInfo->hasPropertyByName( g_sShowChanges );
bHandleRecordChanges = ! xInfo->hasPropertyByName( g_sRecordChanges ); bHandleRecordChanges = ! xInfo->hasPropertyByName( g_sRecordChanges );
...@@ -264,30 +264,30 @@ XMLRedlineImportHelper::XMLRedlineImportHelper( ...@@ -264,30 +264,30 @@ XMLRedlineImportHelper::XMLRedlineImportHelper(
} }
// get redline mode // get redline mode
bShowChanges = *o3tl::doAccess<bool>( m_bShowChanges = *o3tl::doAccess<bool>(
( bHandleShowChanges ? xModelPropertySet : xImportInfoPropertySet ) ( bHandleShowChanges ? m_xModelPropertySet : m_xImportInfoPropertySet )
->getPropertyValue( g_sShowChanges )); ->getPropertyValue( g_sShowChanges ));
bRecordChanges = *o3tl::doAccess<bool>( m_bRecordChanges = *o3tl::doAccess<bool>(
( bHandleRecordChanges ? xModelPropertySet : xImportInfoPropertySet ) ( bHandleRecordChanges ? m_xModelPropertySet : m_xImportInfoPropertySet )
->getPropertyValue( g_sRecordChanges )); ->getPropertyValue( g_sRecordChanges ));
{ {
Any aAny = (bHandleProtectionKey ? xModelPropertySet Any aAny = (bHandleProtectionKey ? m_xModelPropertySet
: xImportInfoPropertySet ) : m_xImportInfoPropertySet )
->getPropertyValue( g_sRedlineProtectionKey ); ->getPropertyValue( g_sRedlineProtectionKey );
aAny >>= aProtectionKey; aAny >>= m_aProtectionKey;
} }
// set redline mode to "don't record changes" // set redline mode to "don't record changes"
if( bHandleRecordChanges ) if( bHandleRecordChanges )
{ {
xModelPropertySet->setPropertyValue( g_sRecordChanges, makeAny(false) ); m_xModelPropertySet->setPropertyValue( g_sRecordChanges, makeAny(false) );
} }
} }
XMLRedlineImportHelper::~XMLRedlineImportHelper() XMLRedlineImportHelper::~XMLRedlineImportHelper()
{ {
// delete all left over (and obviously incomplete) RedlineInfos (and map) // delete all left over (and obviously incomplete) RedlineInfos (and map)
for( auto& rEntry : aRedlineMap ) for( auto& rEntry : m_aRedlineMap )
{ {
RedlineInfo* pInfo = rEntry.second; RedlineInfo* pInfo = rEntry.second;
...@@ -319,17 +319,17 @@ XMLRedlineImportHelper::~XMLRedlineImportHelper() ...@@ -319,17 +319,17 @@ XMLRedlineImportHelper::~XMLRedlineImportHelper()
} }
delete pInfo; delete pInfo;
} }
aRedlineMap.clear(); m_aRedlineMap.clear();
// set redline mode, either to info property set, or directly to // set redline mode, either to info property set, or directly to
// the document // the document
bool bHandleShowChanges = true; bool bHandleShowChanges = true;
bool bHandleRecordChanges = true; bool bHandleRecordChanges = true;
bool bHandleProtectionKey = true; bool bHandleProtectionKey = true;
if ( xImportInfoPropertySet.is() ) if ( m_xImportInfoPropertySet.is() )
{ {
Reference<XPropertySetInfo> xInfo = Reference<XPropertySetInfo> xInfo =
xImportInfoPropertySet->getPropertySetInfo(); m_xImportInfoPropertySet->getPropertySetInfo();
bHandleShowChanges = ! xInfo->hasPropertyByName( g_sShowChanges ); bHandleShowChanges = ! xInfo->hasPropertyByName( g_sShowChanges );
bHandleRecordChanges = ! xInfo->hasPropertyByName( g_sRecordChanges ); bHandleRecordChanges = ! xInfo->hasPropertyByName( g_sRecordChanges );
...@@ -341,30 +341,30 @@ XMLRedlineImportHelper::~XMLRedlineImportHelper() ...@@ -341,30 +341,30 @@ XMLRedlineImportHelper::~XMLRedlineImportHelper()
{ {
Any aAny; Any aAny;
aAny <<= bShowChanges; aAny <<= m_bShowChanges;
if ( bHandleShowChanges ) if ( bHandleShowChanges )
{ {
aAny <<= true; aAny <<= true;
xModelPropertySet->setPropertyValue( g_sShowChanges, aAny ); m_xModelPropertySet->setPropertyValue( g_sShowChanges, aAny );
// TODO maybe we need some property for the view-setting? // TODO maybe we need some property for the view-setting?
SwDoc *const pDoc(SwImport::GetDocFromXMLImport(m_rImport)); SwDoc *const pDoc(SwImport::GetDocFromXMLImport(m_rImport));
assert(pDoc); assert(pDoc);
pDoc->GetDocumentRedlineManager().SetHideRedlines(!bShowChanges); pDoc->GetDocumentRedlineManager().SetHideRedlines(!m_bShowChanges);
} }
else else
xImportInfoPropertySet->setPropertyValue( g_sShowChanges, aAny ); m_xImportInfoPropertySet->setPropertyValue( g_sShowChanges, aAny );
aAny <<= bRecordChanges; aAny <<= m_bRecordChanges;
if ( bHandleRecordChanges ) if ( bHandleRecordChanges )
xModelPropertySet->setPropertyValue( g_sRecordChanges, aAny ); m_xModelPropertySet->setPropertyValue( g_sRecordChanges, aAny );
else else
xImportInfoPropertySet->setPropertyValue( g_sRecordChanges, aAny ); m_xImportInfoPropertySet->setPropertyValue( g_sRecordChanges, aAny );
aAny <<= aProtectionKey; aAny <<= m_aProtectionKey;
if ( bHandleProtectionKey ) if ( bHandleProtectionKey )
xModelPropertySet->setPropertyValue( g_sRedlineProtectionKey, aAny ); m_xModelPropertySet->setPropertyValue( g_sRedlineProtectionKey, aAny );
else else
xImportInfoPropertySet->setPropertyValue( g_sRedlineProtectionKey, aAny); m_xImportInfoPropertySet->setPropertyValue( g_sRedlineProtectionKey, aAny);
} }
catch (const uno::RuntimeException &) // fdo#65882 catch (const uno::RuntimeException &) // fdo#65882
{ {
...@@ -389,15 +389,15 @@ void XMLRedlineImportHelper::Add( ...@@ -389,15 +389,15 @@ void XMLRedlineImportHelper::Add(
// ad 1) // ad 1)
RedlineType_t eType; RedlineType_t eType;
if (rType == sInsertion) if (rType == m_sInsertion)
{ {
eType = nsRedlineType_t::REDLINE_INSERT; eType = nsRedlineType_t::REDLINE_INSERT;
} }
else if (rType == sDeletion) else if (rType == m_sDeletion)
{ {
eType = nsRedlineType_t::REDLINE_DELETE; eType = nsRedlineType_t::REDLINE_DELETE;
} }
else if (rType == sFormatChange) else if (rType == m_sFormatChange)
{ {
eType = nsRedlineType_t::REDLINE_FORMAT; eType = nsRedlineType_t::REDLINE_FORMAT;
} }
...@@ -418,7 +418,7 @@ void XMLRedlineImportHelper::Add( ...@@ -418,7 +418,7 @@ void XMLRedlineImportHelper::Add(
pInfo->bMergeLastParagraph = bMergeLastPara; pInfo->bMergeLastParagraph = bMergeLastPara;
// ad 3) // ad 3)
auto itPair = aRedlineMap.emplace(rId, pInfo); auto itPair = m_aRedlineMap.emplace(rId, pInfo);
if (!itPair.second) if (!itPair.second)
{ {
// 3b) we already have a redline with this name: hierarchical redlines // 3b) we already have a redline with this name: hierarchical redlines
...@@ -446,8 +446,8 @@ Reference<XTextCursor> XMLRedlineImportHelper::CreateRedlineTextSection( ...@@ -446,8 +446,8 @@ Reference<XTextCursor> XMLRedlineImportHelper::CreateRedlineTextSection(
SolarMutexGuard aGuard; SolarMutexGuard aGuard;
// get RedlineInfo // get RedlineInfo
RedlineMapType::iterator aFind = aRedlineMap.find(rId); RedlineMapType::iterator aFind = m_aRedlineMap.find(rId);
if (aRedlineMap.end() != aFind) if (m_aRedlineMap.end() != aFind)
{ {
// get document from old cursor (via tunnel) // get document from old cursor (via tunnel)
SwDoc* pDoc = lcl_GetDocViaTunnel(xOldCursor); SwDoc* pDoc = lcl_GetDocViaTunnel(xOldCursor);
...@@ -492,8 +492,8 @@ void XMLRedlineImportHelper::SetCursor( ...@@ -492,8 +492,8 @@ void XMLRedlineImportHelper::SetCursor(
Reference<XTextRange> const & rRange, Reference<XTextRange> const & rRange,
bool bIsOutsideOfParagraph) bool bIsOutsideOfParagraph)
{ {
RedlineMapType::iterator aFind = aRedlineMap.find(rId); RedlineMapType::iterator aFind = m_aRedlineMap.find(rId);
if (aRedlineMap.end() != aFind) if (m_aRedlineMap.end() != aFind)
{ {
// RedlineInfo found; now set Cursor // RedlineInfo found; now set Cursor
RedlineInfo* pInfo = aFind->second; RedlineInfo* pInfo = aFind->second;
...@@ -527,7 +527,7 @@ void XMLRedlineImportHelper::SetCursor( ...@@ -527,7 +527,7 @@ void XMLRedlineImportHelper::SetCursor(
if (IsReady(pInfo)) if (IsReady(pInfo))
{ {
InsertIntoDocument(pInfo); InsertIntoDocument(pInfo);
aRedlineMap.erase(rId); m_aRedlineMap.erase(rId);
delete pInfo; delete pInfo;
} }
} }
...@@ -543,8 +543,8 @@ void XMLRedlineImportHelper::AdjustStartNodeCursor( ...@@ -543,8 +543,8 @@ void XMLRedlineImportHelper::AdjustStartNodeCursor(
// start + end nodes are treated the same. For either it's // start + end nodes are treated the same. For either it's
// necessary that the target node already exists. // necessary that the target node already exists.
RedlineMapType::iterator aFind = aRedlineMap.find(rId); RedlineMapType::iterator aFind = m_aRedlineMap.find(rId);
if (aRedlineMap.end() != aFind) if (m_aRedlineMap.end() != aFind)
{ {
// RedlineInfo found; now set Cursor // RedlineInfo found; now set Cursor
RedlineInfo* pInfo = aFind->second; RedlineInfo* pInfo = aFind->second;
...@@ -555,7 +555,7 @@ void XMLRedlineImportHelper::AdjustStartNodeCursor( ...@@ -555,7 +555,7 @@ void XMLRedlineImportHelper::AdjustStartNodeCursor(
if( IsReady(pInfo) ) if( IsReady(pInfo) )
{ {
InsertIntoDocument(pInfo); InsertIntoDocument(pInfo);
aRedlineMap.erase(rId); m_aRedlineMap.erase(rId);
delete pInfo; delete pInfo;
} }
} }
...@@ -617,7 +617,7 @@ void XMLRedlineImportHelper::InsertIntoDocument(RedlineInfo* pRedlineInfo) ...@@ -617,7 +617,7 @@ void XMLRedlineImportHelper::InsertIntoDocument(RedlineInfo* pRedlineInfo)
// these redlines have no function, and will thus be ignored (just as // these redlines have no function, and will thus be ignored (just as
// in sw3io), so no action here // in sw3io), so no action here
} }
else if ( bIgnoreRedlines || else if ( m_bIgnoreRedlines ||
!CheckNodesRange( aPaM.GetPoint()->nNode, !CheckNodesRange( aPaM.GetPoint()->nNode,
aPaM.GetMark()->nNode, aPaM.GetMark()->nNode,
true ) true )
...@@ -636,7 +636,7 @@ void XMLRedlineImportHelper::InsertIntoDocument(RedlineInfo* pRedlineInfo) ...@@ -636,7 +636,7 @@ void XMLRedlineImportHelper::InsertIntoDocument(RedlineInfo* pRedlineInfo)
pDoc->getIDocumentContentOperations().DeleteRange(aPaM); pDoc->getIDocumentContentOperations().DeleteRange(aPaM);
// And what about the "deleted nodes"? // And what about the "deleted nodes"?
// They have to be deleted as well (#i80689)! // They have to be deleted as well (#i80689)!
if( bIgnoreRedlines && pRedlineInfo->pContentIndex != nullptr ) if( m_bIgnoreRedlines && pRedlineInfo->pContentIndex != nullptr )
{ {
SwNodeIndex aIdx( *pRedlineInfo->pContentIndex ); SwNodeIndex aIdx( *pRedlineInfo->pContentIndex );
const SwNode* pEnd = aIdx.GetNode().EndOfSectionNode(); const SwNode* pEnd = aIdx.GetNode().EndOfSectionNode();
...@@ -726,18 +726,18 @@ SwRedlineData* XMLRedlineImportHelper::ConvertRedline( ...@@ -726,18 +726,18 @@ SwRedlineData* XMLRedlineImportHelper::ConvertRedline(
void XMLRedlineImportHelper::SetShowChanges( bool bShow ) void XMLRedlineImportHelper::SetShowChanges( bool bShow )
{ {
bShowChanges = bShow; m_bShowChanges = bShow;
} }
void XMLRedlineImportHelper::SetRecordChanges( bool bRecord ) void XMLRedlineImportHelper::SetRecordChanges( bool bRecord )
{ {
bRecordChanges = bRecord; m_bRecordChanges = bRecord;
} }
void XMLRedlineImportHelper::SetProtectionKey( void XMLRedlineImportHelper::SetProtectionKey(
const Sequence<sal_Int8> & rKey ) const Sequence<sal_Int8> & rKey )
{ {
aProtectionKey = rKey; m_aProtectionKey = rKey;
} }
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
...@@ -43,22 +43,22 @@ class XMLRedlineImportHelper final ...@@ -43,22 +43,22 @@ class XMLRedlineImportHelper final
{ {
SvXMLImport & m_rImport; SvXMLImport & m_rImport;
const OUString sInsertion; const OUString m_sInsertion;
const OUString sDeletion; const OUString m_sDeletion;
const OUString sFormatChange; const OUString m_sFormatChange;
RedlineMapType aRedlineMap; RedlineMapType m_aRedlineMap;
// if true, no redlines should be inserted into document // if true, no redlines should be inserted into document
// (This typically happen when a document is loaded in 'insert'-mode.) // (This typically happen when a document is loaded in 'insert'-mode.)
bool const bIgnoreRedlines; bool const m_bIgnoreRedlines;
// save information for saving and reconstruction of the redline mode // save information for saving and reconstruction of the redline mode
css::uno::Reference<css::beans::XPropertySet> xModelPropertySet; css::uno::Reference<css::beans::XPropertySet> m_xModelPropertySet;
css::uno::Reference<css::beans::XPropertySet> xImportInfoPropertySet; css::uno::Reference<css::beans::XPropertySet> m_xImportInfoPropertySet;
bool bShowChanges; bool m_bShowChanges;
bool bRecordChanges; bool m_bRecordChanges;
css::uno::Sequence<sal_Int8> aProtectionKey; css::uno::Sequence<sal_Int8> m_aProtectionKey;
public: public:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment