Kaydet (Commit) 9ce08dcc authored tarafından Stephan Bergmann's avatar Stephan Bergmann

writeHeaderFieldBody is only called with bInitialSpace = false

Change-Id: Ib7fe0bee6339bfad0f63794fec3dfb3f24333ff4
üst a68b0ef5
...@@ -205,8 +205,7 @@ public: ...@@ -205,8 +205,7 @@ public:
static void writeHeaderFieldBody(INetMIMEOutputSink & rSink, static void writeHeaderFieldBody(INetMIMEOutputSink & rSink,
const OUString& rBody, const OUString& rBody,
rtl_TextEncoding ePreferredEncoding, rtl_TextEncoding ePreferredEncoding);
bool bInitialSpace = true);
static OUString decodeHeaderFieldBody(const OString& rBody); static OUString decodeHeaderFieldBody(const OString& rBody);
......
...@@ -972,9 +972,6 @@ createPreferredCharsetList(rtl_TextEncoding eEncoding) ...@@ -972,9 +972,6 @@ createPreferredCharsetList(rtl_TextEncoding eEncoding)
class INetMIMEEncodedWordOutputSink class INetMIMEEncodedWordOutputSink
{ {
public:
enum Space { SPACE_NO, SPACE_ALWAYS };
private: private:
enum { BUFFER_SIZE = 256 }; enum { BUFFER_SIZE = 256 };
...@@ -988,7 +985,6 @@ private: ...@@ -988,7 +985,6 @@ private:
STATE_BAD }; STATE_BAD };
INetMIMEOutputSink & m_rSink; INetMIMEOutputSink & m_rSink;
Space m_eInitialSpace;
sal_uInt32 m_nExtraSpaces; sal_uInt32 m_nExtraSpaces;
INetMIMECharsetList_Impl * m_pEncodingList; INetMIMECharsetList_Impl * m_pEncodingList;
sal_Unicode * m_pBuffer; sal_Unicode * m_pBuffer;
...@@ -1003,7 +999,6 @@ private: ...@@ -1003,7 +999,6 @@ private:
public: public:
inline INetMIMEEncodedWordOutputSink(INetMIMEOutputSink & rTheSink, inline INetMIMEEncodedWordOutputSink(INetMIMEOutputSink & rTheSink,
Space eTheInitialSpace,
rtl_TextEncoding ePreferredEncoding); rtl_TextEncoding ePreferredEncoding);
~INetMIMEEncodedWordOutputSink(); ~INetMIMEEncodedWordOutputSink();
...@@ -1016,10 +1011,8 @@ public: ...@@ -1016,10 +1011,8 @@ public:
}; };
inline INetMIMEEncodedWordOutputSink::INetMIMEEncodedWordOutputSink( inline INetMIMEEncodedWordOutputSink::INetMIMEEncodedWordOutputSink(
INetMIMEOutputSink & rTheSink, INetMIMEOutputSink & rTheSink, rtl_TextEncoding ePreferredEncoding):
Space eTheInitialSpace, rtl_TextEncoding ePreferredEncoding):
m_rSink(rTheSink), m_rSink(rTheSink),
m_eInitialSpace(eTheInitialSpace),
m_nExtraSpaces(0), m_nExtraSpaces(0),
m_pEncodingList(createPreferredCharsetList(ePreferredEncoding)), m_pEncodingList(createPreferredCharsetList(ePreferredEncoding)),
m_ePrevCoding(CODING_NONE), m_ePrevCoding(CODING_NONE),
...@@ -1190,9 +1183,6 @@ needsEncodedWordEscape(sal_uInt32 nChar) ...@@ -1190,9 +1183,6 @@ needsEncodedWordEscape(sal_uInt32 nChar)
void INetMIMEEncodedWordOutputSink::finish(bool bWriteTrailer) void INetMIMEEncodedWordOutputSink::finish(bool bWriteTrailer)
{ {
if (m_eInitialSpace == SPACE_ALWAYS && m_nExtraSpaces == 0)
m_nExtraSpaces = 1;
if (m_eEncodedWordState == STATE_SECOND_EQUALS) if (m_eEncodedWordState == STATE_SECOND_EQUALS)
{ {
// If the text is already an encoded word, copy it verbatim: // If the text is already an encoded word, copy it verbatim:
...@@ -1405,7 +1395,6 @@ void INetMIMEEncodedWordOutputSink::finish(bool bWriteTrailer) ...@@ -1405,7 +1395,6 @@ void INetMIMEEncodedWordOutputSink::finish(bool bWriteTrailer)
} }
} }
m_eInitialSpace = SPACE_NO;
m_nExtraSpaces = 0; m_nExtraSpaces = 0;
m_pEncodingList->reset(); m_pEncodingList->reset();
m_pBufferEnd = m_pBuffer; m_pBufferEnd = m_pBuffer;
...@@ -2398,15 +2387,9 @@ sal_Unicode const * INetMIME::scanContentType( ...@@ -2398,15 +2387,9 @@ sal_Unicode const * INetMIME::scanContentType(
// static // static
void INetMIME::writeHeaderFieldBody(INetMIMEOutputSink & rSink, void INetMIME::writeHeaderFieldBody(INetMIMEOutputSink & rSink,
const OUString& rBody, const OUString& rBody,
rtl_TextEncoding ePreferredEncoding, rtl_TextEncoding ePreferredEncoding)
bool bInitialSpace)
{ {
INetMIMEEncodedWordOutputSink INetMIMEEncodedWordOutputSink aOutput(rSink, ePreferredEncoding);
aOutput(rSink,
bInitialSpace ?
INetMIMEEncodedWordOutputSink::SPACE_ALWAYS :
INetMIMEEncodedWordOutputSink::SPACE_NO,
ePreferredEncoding);
aOutput.write(rBody.getStr(), rBody.getStr() + rBody.getLength()); aOutput.write(rBody.getStr(), rBody.getStr() + rBody.getLength());
aOutput.flush(); aOutput.flush();
} }
......
...@@ -47,7 +47,7 @@ void INetMIMEMessage::SetHeaderField_Impl ( ...@@ -47,7 +47,7 @@ void INetMIMEMessage::SetHeaderField_Impl (
{ {
INetMIMEOutputSink aSink; INetMIMEOutputSink aSink;
INetMIME::writeHeaderFieldBody ( INetMIME::writeHeaderFieldBody (
aSink, rValue, osl_getThreadTextEncoding(), false); aSink, rValue, osl_getThreadTextEncoding());
SetHeaderField_Impl ( SetHeaderField_Impl (
INetMessageHeader (rName, aSink.takeBuffer()), rnIndex); INetMessageHeader (rName, aSink.takeBuffer()), rnIndex);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment