Kaydet (Commit) 9d0f8632 authored tarafından Matteo Casalin's avatar Matteo Casalin

Rework loops so to have exit condition on correct unsigned value

Change-Id: I91e647d6b1aebe8342f95c88fc81bd2c5a43ce71
üst 7d5f47af
...@@ -1113,19 +1113,18 @@ void ModulWindow::GetState( SfxItemSet &rSet ) ...@@ -1113,19 +1113,18 @@ void ModulWindow::GetState( SfxItemSet &rSet )
TextView* pView = GetEditView(); TextView* pView = GetEditView();
if ( pView ) if ( pView )
{ {
OUString sProcName; OUString sProcName;
bool bFound = false;
TextSelection aSel = pView->GetSelection(); TextSelection aSel = pView->GetSelection();
long nLine = aSel.GetStart().GetPara();
for (long i = nLine; i >= 0 && !bFound; --i) sal_uInt32 i = aSel.GetStart().GetPara();
do
{ {
OUString aCurrLine = GetEditEngine()->GetText( i ); OUString aCurrLine = GetEditEngine()->GetText( i );
OUString sProcType; OUString sProcType;
bFound = GetEditorWindow().GetProcedureName(aCurrLine, sProcType, sProcName); if (GetEditorWindow().GetProcedureName(aCurrLine, sProcType, sProcName))
} break;
} while (i--);
OUString aTitle = CreateQualifiedName(); OUString aTitle = CreateQualifiedName();
if (!sProcName.isEmpty()) if (!sProcName.isEmpty())
......
...@@ -43,7 +43,7 @@ void MultiLineEditSyntaxHighlight::DoBracketHilight(sal_uInt16 nKey) ...@@ -43,7 +43,7 @@ void MultiLineEditSyntaxHighlight::DoBracketHilight(sal_uInt16 nKey)
{ {
TextSelection aCurrentPos = GetTextView()->GetSelection(); TextSelection aCurrentPos = GetTextView()->GetSelection();
sal_Int32 nStartPos = aCurrentPos.GetStart().GetIndex(); sal_Int32 nStartPos = aCurrentPos.GetStart().GetIndex();
sal_Int32 nStartPara = aCurrentPos.GetStart().GetPara(); const sal_uInt32 nStartPara = aCurrentPos.GetStart().GetPara();
sal_uInt16 nCount = 0; sal_uInt16 nCount = 0;
int nChar = -1; int nChar = -1;
...@@ -74,7 +74,8 @@ void MultiLineEditSyntaxHighlight::DoBracketHilight(sal_uInt16 nKey) ...@@ -74,7 +74,8 @@ void MultiLineEditSyntaxHighlight::DoBracketHilight(sal_uInt16 nKey)
if (nChar != -1) if (nChar != -1)
{ {
for (sal_Int32 nPara = nStartPara; nPara >= 0; --nPara) sal_uInt32 nPara = nStartPara;
do
{ {
if (nPara == nStartPara && nStartPos == 0) if (nPara == nStartPara && nStartPos == 0)
continue; continue;
...@@ -102,7 +103,7 @@ void MultiLineEditSyntaxHighlight::DoBracketHilight(sal_uInt16 nKey) ...@@ -102,7 +103,7 @@ void MultiLineEditSyntaxHighlight::DoBracketHilight(sal_uInt16 nKey)
if (aLine[i] == nKey) if (aLine[i] == nKey)
++nCount; ++nCount;
} }
} } while (nPara--);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment