Kaydet (Commit) 9f1ecd3a authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#1267678 this is surely backwards (gold)

surely we clone from the source and return the newly created
entry. Presumably this doesn't break all the time because
aCloneLink is generally set ?

coverity#1267678 Resource leak

Change-Id: I3e02dfaef371e006f1510b186cdd881c991ef2cf
üst baa5fca0
......@@ -355,8 +355,8 @@ SvTreeListEntry* SvTreeList::CloneEntry( SvTreeListEntry* pSource ) const
if( aCloneLink.IsSet() )
return reinterpret_cast<SvTreeListEntry*>(aCloneLink.Call( pSource ));
SvTreeListEntry* pEntry = CreateEntry();
pSource->Clone( pEntry );
return pSource;
pEntry->Clone(pSource);
return pEntry;
}
SvTreeListEntry* SvTreeList::CreateEntry() const
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment