embeddedobj: Use appropriate OUString functions on string constants

Change-Id: I149dd1abf03437bb58829a5f16a8c2aef5eec092

embeddedobj/source/commonembedding/persistence.cxx

@@ -652,8 +652,7 @@ OUString OCommonEmbeddedObject::GetBaseURL_Impl() const
             uno::Reference< frame::XModel > xParentModel( m_xClientSite->getComponent(), uno::UNO_QUERY_THROW );
             uno::Sequence< beans::PropertyValue > aModelProps = xParentModel->getArgs();
             for ( nInd = 0; nInd < aModelProps.getLength(); nInd++ )
-                if ( aModelProps[nInd].Name.equals(
-                                                OUString( "DocumentBaseURL" ) ) )
+                if ( aModelProps[nInd].Name == "DocumentBaseURL" )
                 {
                     aModelProps[nInd].Value >>= aBaseURL;
                     break;
@@ -668,8 +667,7 @@ OUString OCommonEmbeddedObject::GetBaseURL_Impl() const
     if ( aBaseURL.isEmpty() )
     {
         for ( nInd = 0; nInd < m_aDocMediaDescriptor.getLength(); nInd++ )
-            if ( m_aDocMediaDescriptor[nInd].Name.equals(
-                                                OUString( "DocumentBaseURL" ) ) )
+            if ( m_aDocMediaDescriptor[nInd].Name == "DocumentBaseURL" )
             {
                 m_aDocMediaDescriptor[nInd].Value >>= aBaseURL;
                 break;

embeddedobj/source/general/intercept.cxx

@@ -174,7 +174,7 @@ Interceptor::addStatusListener(
         aStateEvent.FeatureDescriptor = "Update";
         aStateEvent.IsEnabled = sal_True;
         aStateEvent.Requery = sal_False;
-        aStateEvent.State <<= (OUString( "($1) ") + m_pDocHolder->GetTitle() );
+        aStateEvent.State <<= ( "($1) " + m_pDocHolder->GetTitle() );
         Control->statusChanged(aStateEvent);
 
         {
@@ -198,7 +198,7 @@ Interceptor::addStatusListener(
         aStateEvent.FeatureDescriptor = "Close and Return";
         aStateEvent.IsEnabled = sal_True;
         aStateEvent.Requery = sal_False;
-        aStateEvent.State <<= (OUString( "($2) ") + m_pDocHolder->GetTitle() );
+        aStateEvent.State <<= ( "($2) " + m_pDocHolder->GetTitle() );
         Control->statusChanged(aStateEvent);
 
 

embeddedobj/source/inc/docholder.hxx

@@ -131,7 +131,7 @@ public:
 
     OUString GetTitle() const
     {
-        return m_aContainerName + OUString( " - " ) + m_aDocumentNamePart;
+        return m_aContainerName + " - " + m_aDocumentNamePart;
     }
 
     OUString GetContainerName() const { return m_aContainerName; }

embeddedobj/source/msole/ownview.cxx

@@ -201,8 +201,7 @@ OUString OwnView_Impl::GetFilterNameFromExtentionAndInStream(
 
     if ( !aNameWithExtention.isEmpty() )
     {
-        OUString aURLToAnalyze =
-                ( OUString( "file:///" ) + aNameWithExtention );
+        OUString aURLToAnalyze = "file:///" + aNameWithExtention;
         aTypeName = xTypeDetection->queryTypeByURL( aURLToAnalyze );
     }