Kaydet (Commit) a33fcd1d authored tarafından Caolán McNamara's avatar Caolán McNamara

bPrinter is always false, simplify

Change-Id: If40d1ccdec77c1bf0753411da71ac5c0b42c2765
üst 27d7aea0
...@@ -70,7 +70,6 @@ public: ...@@ -70,7 +70,6 @@ public:
class CairoTextRender : public TextRenderImpl class CairoTextRender : public TextRenderImpl
{ {
bool mbPrinter;
ServerFont* mpServerFont[ MAX_FALLBACK ]; ServerFont* mpServerFont[ MAX_FALLBACK ];
SalColor mnTextColor; SalColor mnTextColor;
...@@ -89,7 +88,7 @@ protected: ...@@ -89,7 +88,7 @@ protected:
virtual void clipRegion(cairo_t* cr) = 0; virtual void clipRegion(cairo_t* cr) = 0;
public: public:
CairoTextRender(bool bPrinter); CairoTextRender();
virtual void SetTextColor( SalColor nSalColor ) SAL_OVERRIDE; virtual void SetTextColor( SalColor nSalColor ) SAL_OVERRIDE;
......
...@@ -40,9 +40,8 @@ ...@@ -40,9 +40,8 @@
#include <cairo-xlib.h> #include <cairo-xlib.h>
#include <cairo-xlib-xrender.h> #include <cairo-xlib-xrender.h>
CairoTextRender::CairoTextRender(bool bPrinter): CairoTextRender::CairoTextRender()
mbPrinter(bPrinter), : mnTextColor(MAKE_SALCOLOR(0x00, 0x00, 0x00)) //black
mnTextColor(MAKE_SALCOLOR(0x00, 0x00, 0x00)) //black
{ {
for( int i = 0; i < MAX_FALLBACK; ++i ) for( int i = 0; i < MAX_FALLBACK; ++i )
mpServerFont[i] = NULL; mpServerFont[i] = NULL;
...@@ -89,13 +88,9 @@ bool CairoTextRender::setFont( const FontSelectPattern *pEntry, int nFallbackLev ...@@ -89,13 +88,9 @@ bool CairoTextRender::setFont( const FontSelectPattern *pEntry, int nFallbackLev
// register to use the font // register to use the font
mpServerFont[ nFallbackLevel ] = pServerFont; mpServerFont[ nFallbackLevel ] = pServerFont;
// apply font specific-hint settings if needed // apply font specific-hint settings
// TODO: also disable it for reference devices ImplServerFontEntry* pSFE = static_cast<ImplServerFontEntry*>( pEntry->mpFontEntry );
if( !mbPrinter ) pSFE->HandleFontOptions();
{
ImplServerFontEntry* pSFE = static_cast<ImplServerFontEntry*>( pEntry->mpFontEntry );
pSFE->HandleFontOptions();
}
return true; return true;
} }
...@@ -370,9 +365,9 @@ bool CairoTextRender::GetFontCapabilities(vcl::FontCapabilities &rGetImplFontCap ...@@ -370,9 +365,9 @@ bool CairoTextRender::GetFontCapabilities(vcl::FontCapabilities &rGetImplFontCap
sal_uInt16 CairoTextRender::SetFont( FontSelectPattern *pEntry, int nFallbackLevel ) sal_uInt16 CairoTextRender::SetFont( FontSelectPattern *pEntry, int nFallbackLevel )
{ {
sal_uInt16 nRetVal = 0; sal_uInt16 nRetVal = 0;
if( !setFont( pEntry, nFallbackLevel ) ) if (!setFont(pEntry, nFallbackLevel))
nRetVal |= SAL_SETFONT_BADFONT; nRetVal |= SAL_SETFONT_BADFONT;
if( mbPrinter || (mpServerFont[ nFallbackLevel ] != NULL) ) if (mpServerFont[nFallbackLevel])
nRetVal |= SAL_SETFONT_USEDRAWTEXTARRAY; nRetVal |= SAL_SETFONT_USEDRAWTEXTARRAY;
return nRetVal; return nRetVal;
} }
......
...@@ -15,8 +15,8 @@ ...@@ -15,8 +15,8 @@
#include <cairo-svg.h> #include <cairo-svg.h>
OpenGLX11CairoTextRender::OpenGLX11CairoTextRender(bool bPrinter, X11SalGraphics& rParent): OpenGLX11CairoTextRender::OpenGLX11CairoTextRender(X11SalGraphics& rParent)
X11CairoTextRender(bPrinter, rParent) : X11CairoTextRender(rParent)
{ {
} }
......
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
class OpenGLX11CairoTextRender : public X11CairoTextRender class OpenGLX11CairoTextRender : public X11CairoTextRender
{ {
public: public:
OpenGLX11CairoTextRender(bool bPrinter, X11SalGraphics& rParent); OpenGLX11CairoTextRender(X11SalGraphics& rParent);
virtual cairo_surface_t* getCairoSurface() SAL_OVERRIDE; virtual cairo_surface_t* getCairoSurface() SAL_OVERRIDE;
virtual void getSurfaceOffset(double& nDX, double& nDY) SAL_OVERRIDE; virtual void getSurfaceOffset(double& nDX, double& nDY) SAL_OVERRIDE;
......
...@@ -86,11 +86,11 @@ X11SalGraphics::X11SalGraphics(): ...@@ -86,11 +86,11 @@ X11SalGraphics::X11SalGraphics():
if (OpenGLHelper::isVCLOpenGLEnabled()) if (OpenGLHelper::isVCLOpenGLEnabled())
{ {
mxImpl.reset(new X11OpenGLSalGraphicsImpl(*this)); mxImpl.reset(new X11OpenGLSalGraphicsImpl(*this));
mxTextRenderImpl.reset((new OpenGLX11CairoTextRender(false, *this))); mxTextRenderImpl.reset((new OpenGLX11CairoTextRender(*this)));
} }
else else
{ {
mxTextRenderImpl.reset((new X11CairoTextRender(false, *this))); mxTextRenderImpl.reset((new X11CairoTextRender(*this)));
mxImpl.reset(new X11SalGraphicsImpl(*this)); mxImpl.reset(new X11SalGraphicsImpl(*this));
} }
......
...@@ -42,9 +42,8 @@ struct _XRegion ...@@ -42,9 +42,8 @@ struct _XRegion
BOX extents; BOX extents;
}; };
X11CairoTextRender::X11CairoTextRender(bool bPrinter, X11SalGraphics& rParent): X11CairoTextRender::X11CairoTextRender(X11SalGraphics& rParent)
CairoTextRender(bPrinter), : mrParent(rParent)
mrParent(rParent)
{ {
} }
......
...@@ -37,7 +37,7 @@ protected: ...@@ -37,7 +37,7 @@ protected:
size_t GetHeight() const; size_t GetHeight() const;
public: public:
X11CairoTextRender(bool bPrinter, X11SalGraphics& rParent); X11CairoTextRender(X11SalGraphics& rParent);
virtual GlyphCache& getPlatformGlyphCache() SAL_OVERRIDE; virtual GlyphCache& getPlatformGlyphCache() SAL_OVERRIDE;
virtual cairo_surface_t* getCairoSurface() SAL_OVERRIDE; virtual cairo_surface_t* getCairoSurface() SAL_OVERRIDE;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment