Kaydet (Commit) a4f39904 authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#1251587 Unchecked dynamic_cast

Change-Id: Ibde77906333699046357bec4ff392e5e08b4a426
üst e5e13192
...@@ -763,13 +763,11 @@ const ScCalcConfig::OpenCLImplMatcher& ScCalcOptionsDialog::CurrentWhiteOrBlackL ...@@ -763,13 +763,11 @@ const ScCalcConfig::OpenCLImplMatcher& ScCalcOptionsDialog::CurrentWhiteOrBlackL
void ScCalcOptionsDialog::EditFieldValueChanged(Control *pCtrl) void ScCalcOptionsDialog::EditFieldValueChanged(Control *pCtrl)
{ {
Edit* pEdit(dynamic_cast<Edit*>(pCtrl)); Edit& rEdit(dynamic_cast<Edit&>(*pCtrl));
assert(pEdit); OUString sVal = rEdit.GetText();
OUString sVal = pEdit->GetText(); if (&rEdit == mpEditField)
if (pEdit == mpEditField)
{ {
// We know that the mpEditField is used for only one thing at the moment, // We know that the mpEditField is used for only one thing at the moment,
// the OpenCL subset list of opcodes // the OpenCL subset list of opcodes
...@@ -783,32 +781,32 @@ void ScCalcOptionsDialog::EditFieldValueChanged(Control *pCtrl) ...@@ -783,32 +781,32 @@ void ScCalcOptionsDialog::EditFieldValueChanged(Control *pCtrl)
const ScCalcConfig::OpenCLImplMatcher& impl(CurrentWhiteOrBlackListEntry()); const ScCalcConfig::OpenCLImplMatcher& impl(CurrentWhiteOrBlackListEntry());
ScCalcConfig::OpenCLImplMatcher newImpl(impl); ScCalcConfig::OpenCLImplMatcher newImpl(impl);
if (pEdit == mpOS) if (&rEdit == mpOS)
{ {
newImpl.maOS = sVal; newImpl.maOS = sVal;
} }
else if (pEdit == mpOSVersion) else if (&rEdit == mpOSVersion)
{ {
newImpl.maOSVersion = sVal; newImpl.maOSVersion = sVal;
} }
else if (pEdit == mpPlatformVendor) else if (&rEdit == mpPlatformVendor)
{ {
newImpl.maPlatformVendor = sVal; newImpl.maPlatformVendor = sVal;
} }
else if (pEdit == mpDevice) else if (&rEdit == mpDevice)
{ {
newImpl.maDevice = sVal; newImpl.maDevice = sVal;
} }
else if (pEdit == mpDriverVersionMin) else if (&rEdit == mpDriverVersionMin)
{ {
newImpl.maDriverVersionMin = sVal; newImpl.maDriverVersionMin = sVal;
} }
else if (pEdit == mpDriverVersionMax) else if (&rEdit == mpDriverVersionMax)
{ {
newImpl.maDriverVersionMax = sVal; newImpl.maDriverVersionMax = sVal;
} }
else else
assert(false && "pEdit does not match any of the Edit fields"); assert(false && "rEdit does not match any of the Edit fields");
ScCalcConfig::OpenCLImplMatcherSet& rSet(CurrentWhiteOrBlackList()); ScCalcConfig::OpenCLImplMatcherSet& rSet(CurrentWhiteOrBlackList());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment