java: avoid if..else when returning boolean values

Change-Id: Iab52762a9abfe8735223372b09638ce9d8d44318

javaunohelper/test/com/sun/star/lib/uno/helper/ProxyProvider.java

@@ -80,17 +80,11 @@ class Proxy implements IQueryInterface, XEventListener
         if (object instanceof IQueryInterface)
         {
             IQueryInterface iquery = (IQueryInterface) object;
-            if (iquery.getOid().equals(oid))
-                return true;
-            else
-                return false;
+            return (iquery.getOid().equals(oid));
         }
 
         String oidObj = UnoRuntime.generateOid(object);
-        if (oidObj.equals(oid))
-            return true;
-        else
-            return false;
+        return (oidObj.equals(oid));
     }
 
     public Object queryInterface(Type type) {

qadevOOo/runner/graphical/ParameterHelper.java

@@ -244,15 +244,8 @@ public class ParameterHelper
         String sOfficeViewable = (String)m_aCurrentParams.get(PropertyName.OFFICE_VIEWABLE);
         if (sOfficeViewable != null)
         {
-            if (sOfficeViewable.toLowerCase().equals("yes") ||
-                sOfficeViewable.toLowerCase().equals("true"))
-            {
-                return false; // setViewable();
-            }
-            else
-            {
-                return true; // setHidden();
-            }
+            return !(sOfficeViewable.toLowerCase().equals("yes") ||
+                     sOfficeViewable.toLowerCase().equals("true"));
         }
         return true; /* default: hidden */
     }

scripting/java/org/openoffice/idesupport/ui/ScriptPanel.java

@@ -182,10 +182,7 @@ public class ScriptPanel extends JPanel {
 
         @Override
         public boolean isCellEditable(int row, int col) {
-            if (col == 0)
-                return false;
-            else
-                return true;
+            return (col != 0);
         }
 
         @Override

scripting/java/org/openoffice/netbeans/modules/office/actions/ParcelSupport.java

@@ -174,9 +174,6 @@ public class ParcelSupport implements ParcelCookie
             message, NotifyDescriptor.OK_CANCEL_OPTION);
         TopManager.getDefault().notify(d);
 
-        if (d.getValue() == NotifyDescriptor.CANCEL_OPTION)
-            return false;
-        else
-            return true;
+        return (d.getValue() != NotifyDescriptor.CANCEL_OPTION);
     }
 }

scripting/java/org/openoffice/netbeans/modules/office/utils/NagDialog.java

@@ -66,10 +66,7 @@ public class NagDialog {
     public boolean show() {
         TopManager.getDefault().notify(descriptor);
 
-        if (descriptor.getValue() == NotifyDescriptor.OK_OPTION)
-            return true;
-        else
-            return false;
+        return (descriptor.getValue() == NotifyDescriptor.OK_OPTION);
     }
 
     public boolean getState() {

scripting/workben/ifc/scripting/_XFunctionProvider.java

@@ -77,9 +77,6 @@ public class _XFunctionProvider extends MultiMethodTest {
             output = "XFunction.class";
 
         log.println("expected: " + expected + ", output: " + output);
-        if (output.equals(expected))
-            return true;
-        else
-            return false;
+        return (output.equals(expected));
     }
 }

scripting/workben/ifc/scripting/_XScriptInfoAccess.java

@@ -86,10 +86,7 @@ public class _XScriptInfoAccess extends MultiMethodTest {
             }
 
         log.println("expected: " + expected + ", output: " + output);
-        if (output.equals(expected))
-            return true;
-        else
-            return false;
+        return (output.equals(expected));
     }
 
     public void _getImplementations() {
@@ -143,10 +140,7 @@ public class _XScriptInfoAccess extends MultiMethodTest {
         }
 
         log.println("expected: " + expected + ", output: " + output);
-        if (output.equals(expected))
-            return true;
-        else
-            return false;
+        return (output.equals(expected));
     }
 
     public void _getAllImplementations() {
@@ -196,9 +190,6 @@ public class _XScriptInfoAccess extends MultiMethodTest {
         }
 
         log.println("expected: " + expected + ", output: " + output);
-        if (output.equals(expected))
-            return true;
-        else
-            return false;
+        return (output.equals(expected));
     }
 }

scripting/workben/ifc/scripting/_XScriptInvocation.java

@@ -133,10 +133,7 @@ public class _XScriptInvocation extends MultiMethodTest {
             ctx.dispose();
 
         log.println("expected: " + expected + ", output: " + output);
-        if (output.equals(expected))
-            return true;
-        else
-            return false;
+        return (output.equals(expected));
     }
 
     private int getStorageId(String location) {

scripting/workben/ifc/scripting/_XScriptNameResolver.java

@@ -112,10 +112,7 @@ public class _XScriptNameResolver extends MultiMethodTest {
         }
 
         log.println("expected: " + expected + ", output: " + output);
-        if (output.equals(expected))
-            return true;
-        else
-            return false;
+        return (output.equals(expected));
     }
 
     private int getStorageId(String location) {

scripting/workben/ifc/scripting/_XScriptSecurity.java

@@ -181,14 +181,7 @@ public class _XScriptSecurity extends MultiMethodTest {
                     expectedPath = uri.substring(0,  uri.lastIndexOf('/'));
                 }
                 log.println("pathlist: expected: " + expectedPath + ", output: " + setPath);
-                if( setPath.equals( expectedPath ) )
-                {
-                    return true;
-                }
-                else
-                {
-                    return false;
-                }
+                return setPath.equals( expectedPath );
             }
             return true;
         }

scripting/workben/installer/IdeVersion.java

@@ -299,11 +299,7 @@ class MyTableModelIDE extends AbstractTableModel {
 
         @Override
         public boolean isCellEditable(int row, int col) {
-        if (col == 0) {
-            return true;
-        } else {
-            return false;
-        }
+          return (col == 0);
         }
 
         @Override

scripting/workben/installer/Version.java

@@ -314,11 +314,7 @@ class MyTableModel extends AbstractTableModel {
 
     @Override
     public boolean isCellEditable(int row, int col) {
-        if (col == 0) {
-            return true;
-        } else {
-            return false;
-        }
+        return (col == 0);
     }
 
     @Override