no need to allocate aEmptyOUString separately

Change-Id: I938f5c022ef07e9ac4cc6eaf60cc7a88deabbda7
Reviewed-on: https://gerrit.libreoffice.org/69747
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

sc/inc/global.hxx

@@ -509,7 +509,7 @@ class ScGlobal
     static ScUserList*      pUserList;
     static std::map<const char*, OUString>* pRscString;
     static OUString*        pStrScDoc;
-    static OUString*        pEmptyOUString;
+    static SC_DLLPUBLIC const OUString aEmptyOUString;
     static OUString*        pStrClipDocName;
     static SvxBrushItem*    pEmptyBrushItem;
     static SvxBrushItem*    pButtonBrushItem;
@@ -592,7 +592,7 @@ public:
     static void             InitTextHeight(const SfxItemPool* pPool);
     static SvxBrushItem*    GetEmptyBrushItem() { return pEmptyBrushItem; }
     static SvxBrushItem*    GetButtonBrushItem();
-    SC_DLLPUBLIC    static const OUString&    GetEmptyOUString();
+    static const OUString&  GetEmptyOUString() { return aEmptyOUString; }
 
     static bool             HasStarCalcFunctionList();
     static ScFunctionList*  GetStarCalcFunctionList();

sc/source/core/data/global.cxx

@@ -83,7 +83,7 @@ std::atomic<CollatorWrapper*> ScGlobal::pCaseCollator(nullptr);
 std::atomic<::utl::TransliterationWrapper*> ScGlobal::pTransliteration(nullptr);
 std::atomic<::utl::TransliterationWrapper*> ScGlobal::pCaseTransliteration(nullptr);
 css::uno::Reference< css::i18n::XOrdinalSuffix> ScGlobal::xOrdinalSuffix;
-OUString*       ScGlobal::pEmptyOUString = nullptr;
+const OUString  ScGlobal::aEmptyOUString;
 OUString*       ScGlobal::pStrClipDocName = nullptr;
 
 SvxBrushItem*   ScGlobal::pEmptyBrushItem = nullptr;
@@ -431,15 +431,8 @@ SvxBrushItem* ScGlobal::GetButtonBrushItem()
     return pButtonBrushItem;
 }
 
-const OUString& ScGlobal::GetEmptyOUString()
-{
-    return *pEmptyOUString;
-}
-
 void ScGlobal::Init()
 {
-    pEmptyOUString = new OUString;
-
     // The default language for number formats (ScGlobal::eLnge) must
     // always be LANGUAGE_SYSTEM
     // FIXME: So remove this variable?
@@ -567,7 +560,6 @@ void ScGlobal::Clear()
     delete pUnitConverter.load(); pUnitConverter = nullptr;
     DELETEZ(pFieldEditEngine);
 
-    DELETEZ(pEmptyOUString);
     xDrawClipDocShellRef.clear();
 }