Kaydet (Commit) ac5b44c0 authored tarafından Caolán McNamara's avatar Caolán McNamara

tweak custom widget to give an optimal size

+ move accessibility relations into the .ui now that we can
+ drop unused hids
+ rework the format/language positions to be less weird
+ add a custom widget stub to make easy to edit with glade

Change-Id: I9607603536f9df2b7cac0074880089adad3b9860
üst c77ec4fe
...@@ -329,6 +329,9 @@ ...@@ -329,6 +329,9 @@
<glade-widget-class title="Frame Preview" name="svxlo-SvxSwFrameExample" <glade-widget-class title="Frame Preview" name="svxlo-SvxSwFrameExample"
generic-name="Frame Preview" parent="GtkDrawingArea" generic-name="Frame Preview" parent="GtkDrawingArea"
icon-name="widget-gtk-drawingarea"/> icon-name="widget-gtk-drawingarea"/>
<glade-widget-class title="Presentation Preview" name="sduilo-PresLayoutPreview"
generic-name="Presentation Preview" parent="GtkDrawingArea"
icon-name="widget-gtk-drawingarea"/>
<glade-widget-class title="Rectangle Control" name="svxlo-SvxRectCtl" <glade-widget-class title="Rectangle Control" name="svxlo-SvxRectCtl"
generic-name="Rectangle Control" parent="GtkDrawingArea" generic-name="Rectangle Control" parent="GtkDrawingArea"
icon-name="widget-gtk-drawingarea"/> icon-name="widget-gtk-drawingarea"/>
......
...@@ -109,9 +109,6 @@ ...@@ -109,9 +109,6 @@
#define HID_SD_NAMEDIALOG_PAGE "SD_HID_SD_NAMEDIALOG_PAGE" #define HID_SD_NAMEDIALOG_PAGE "SD_HID_SD_NAMEDIALOG_PAGE"
#define HID_SD_NAMEDIALOG_LINEEND "SD_HID_SD_NAMEDIALOG_LINEEND" #define HID_SD_NAMEDIALOG_LINEEND "SD_HID_SD_NAMEDIALOG_LINEEND"
#define HID_SD_TABPAGE_HEADERFOOTER_SLIDE "SD_HID_SD_TABPAGE_HEADERFOOTER_SLIDE"
#define HID_SD_TABPAGE_HEADERFOOTER_NOTESHANDOUT "SD_HID_SD_TABPAGE_HEADERFOOTER_NOTESHANDOUT"
#define HID_SD_TASK_PANE "SD_HID_SD_TASK_PANE" #define HID_SD_TASK_PANE "SD_HID_SD_TASK_PANE"
#define HID_SD_SLIDE_DESIGNS "SD_HID_SD_SLIDE_DESIGNS" #define HID_SD_SLIDE_DESIGNS "SD_HID_SD_SLIDE_DESIGNS"
#define HID_SD_CURRENT_MASTERS "SD_HID_SD_CURRENT_MASTERS" #define HID_SD_CURRENT_MASTERS "SD_HID_SD_CURRENT_MASTERS"
......
...@@ -28,10 +28,11 @@ ...@@ -28,10 +28,11 @@
#include "sdresid.hxx" #include "sdresid.hxx"
#include <vcl/fixed.hxx>
#include <vcl/button.hxx> #include <vcl/button.hxx>
#include <vcl/edit.hxx>
#include <vcl/combobox.hxx> #include <vcl/combobox.hxx>
#include <vcl/edit.hxx>
#include <vcl/fixed.hxx>
#include <vcl/layout.hxx>
#include "helpids.h" #include "helpids.h"
#include "Outliner.hxx" #include "Outliner.hxx"
...@@ -79,6 +80,7 @@ public: ...@@ -79,6 +80,7 @@ public:
~PresLayoutPreview(); ~PresLayoutPreview();
virtual void Paint( const Rectangle& rRect ); virtual void Paint( const Rectangle& rRect );
virtual Size GetOptimalSize() const;
void init( SdPage* pMaster ); void init( SdPage* pMaster );
void update( HeaderFooterSettings& rSettings ); void update( HeaderFooterSettings& rSettings );
...@@ -120,7 +122,7 @@ private: ...@@ -120,7 +122,7 @@ private:
FixedText* mpFTIncludeOn; FixedText* mpFTIncludeOn;
CheckBox* mpCBHeader; CheckBox* mpCBHeader;
FixedText* mpFTHeader; VclContainer* mpHeaderBox;
Edit* mpTBHeader; Edit* mpTBHeader;
CheckBox* mpCBDateTime; CheckBox* mpCBDateTime;
...@@ -132,7 +134,7 @@ private: ...@@ -132,7 +134,7 @@ private:
SvxLanguageBox* mpCBDateTimeLanguage; SvxLanguageBox* mpCBDateTimeLanguage;
CheckBox* mpCBFooter; CheckBox* mpCBFooter;
FixedText* mpFTFooter; VclContainer* mpFooterBox;
Edit* mpTBFooter; Edit* mpTBFooter;
CheckBox* mpCBSlideNumber; CheckBox* mpCBSlideNumber;
...@@ -182,7 +184,6 @@ HeaderFooterDialog::HeaderFooterDialog( ViewShell* pViewShell, ::Window* pParent ...@@ -182,7 +184,6 @@ HeaderFooterDialog::HeaderFooterDialog( ViewShell* pViewShell, ::Window* pParent
mpCurrentPage( pCurrentPage ), mpCurrentPage( pCurrentPage ),
mpViewShell( pViewShell ) mpViewShell( pViewShell )
{ {
//FreeResource();
get(mpTabCtrl, "tabs" ); get(mpTabCtrl, "tabs" );
SdPage* pSlide; SdPage* pSlide;
...@@ -207,12 +208,10 @@ HeaderFooterDialog::HeaderFooterDialog( ViewShell* pViewShell, ::Window* pParent ...@@ -207,12 +208,10 @@ HeaderFooterDialog::HeaderFooterDialog( ViewShell* pViewShell, ::Window* pParent
} }
pDoc->StopWorkStartupDelay(); pDoc->StopWorkStartupDelay();
// mpTabCtrl.SetHelpId( HID_XML_FILTER_TABPAGE_CTRL );
mpTabCtrl->Show(); mpTabCtrl->Show();
mnSlidesId = mpTabCtrl->GetPageId("slides"); mnSlidesId = mpTabCtrl->GetPageId("slides");
mpSlideTabPage = new HeaderFooterTabPage( this, mpTabCtrl, pDoc, pSlide, false ); mpSlideTabPage = new HeaderFooterTabPage( this, mpTabCtrl, pDoc, pSlide, false );
//mpSlideTabPage->SetHelpId( HID_SD_TABPAGE_HEADERFOOTER_SLIDE );
mpTabCtrl->SetTabPage( mnSlidesId, mpSlideTabPage ); mpTabCtrl->SetTabPage( mnSlidesId, mpSlideTabPage );
Size aSiz = mpSlideTabPage->GetSizePixel(); Size aSiz = mpSlideTabPage->GetSizePixel();
...@@ -226,24 +225,14 @@ HeaderFooterDialog::HeaderFooterDialog( ViewShell* pViewShell, ::Window* pParent ...@@ -226,24 +225,14 @@ HeaderFooterDialog::HeaderFooterDialog( ViewShell* pViewShell, ::Window* pParent
mnNotesId = mpTabCtrl->GetPageId("notes"); mnNotesId = mpTabCtrl->GetPageId("notes");
mpNotesHandoutsTabPage = new HeaderFooterTabPage( this, mpTabCtrl, pDoc, pNotes, true ); mpNotesHandoutsTabPage = new HeaderFooterTabPage( this, mpTabCtrl, pDoc, pNotes, true );
//mpNotesHandoutsTabPage->SetHelpId( HID_SD_TABPAGE_HEADERFOOTER_NOTESHANDOUT );
mpTabCtrl->SetTabPage( mnNotesId, mpNotesHandoutsTabPage ); mpTabCtrl->SetTabPage( mnNotesId, mpNotesHandoutsTabPage );
get(maPBApplyToAll, "apply_all" ); get(maPBApplyToAll, "apply_all" );
get(maPBApply, "apply" ); get(maPBApply, "apply" );
get(maPBCancel, "cancel" ); get(maPBCancel, "cancel" );
/*aSiz = mpNotesHandoutsTabPage->GetSizePixel();
if ( aCtrlSiz.Width() < aSiz.Width() || aCtrlSiz.Height() < aSiz.Height() )
{
mpTabCtrl.SetOutputSizePixel( aSiz );
aCtrlSiz = aSiz;
}*/
ActivatePageHdl( mpTabCtrl ); ActivatePageHdl( mpTabCtrl );
AdjustLayout();
mpTabCtrl->SetActivatePageHdl( LINK( this, HeaderFooterDialog, ActivatePageHdl ) ); mpTabCtrl->SetActivatePageHdl( LINK( this, HeaderFooterDialog, ActivatePageHdl ) );
mpTabCtrl->SetDeactivatePageHdl( LINK( this, HeaderFooterDialog, DeactivatePageHdl ) ); mpTabCtrl->SetDeactivatePageHdl( LINK( this, HeaderFooterDialog, DeactivatePageHdl ) );
...@@ -446,30 +435,30 @@ HeaderFooterTabPage::HeaderFooterTabPage( HeaderFooterDialog* pDialog, ::Window* ...@@ -446,30 +435,30 @@ HeaderFooterTabPage::HeaderFooterTabPage( HeaderFooterDialog* pDialog, ::Window*
mpDialog(pDialog), mpDialog(pDialog),
mbHandoutMode( bHandoutMode ) mbHandoutMode( bHandoutMode )
{ {
get(mpFTIncludeOn, "include_label"); get(mpFTIncludeOn, "include_label");
get(mpCBHeader, "header_cb" ); get(mpCBHeader, "header_cb" );
get(mpFTHeader, "header_label" ); get(mpHeaderBox, "header_box" );
get(mpTBHeader, "header_text" ); get(mpTBHeader, "header_text" );
get(mpCBDateTime, "datetime_cb" ); get(mpCBDateTime, "datetime_cb" );
get(mpRBDateTimeFixed, "rb_fixed" ); get(mpRBDateTimeFixed, "rb_fixed" );
get(mpRBDateTimeAutomatic, "rb_auto" ); get(mpRBDateTimeAutomatic, "rb_auto" );
get(mpTBDateTimeFixed, "datetime_value" ); get(mpTBDateTimeFixed, "datetime_value" );
get(mpCBDateTimeFormat, "datetime_format_list" ); get(mpCBDateTimeFormat, "datetime_format_list" );
get(mpFTDateTimeLanguage, "language_label" ); get(mpFTDateTimeLanguage, "language_label" );
get(mpCBDateTimeLanguage, "language_list" ); get(mpCBDateTimeLanguage, "language_list" );
get(mpCBFooter, "footer_cb" ); get(mpCBFooter, "footer_cb" );
get(mpFTFooter, "footer_label" ); get(mpFooterBox, "footer_box" );
get(mpTBFooter, "footer_text" ); get(mpTBFooter, "footer_text" );
get(mpCBSlideNumber, "slide_number" ); get(mpCBSlideNumber, "slide_number" );
get(mpCBNotOnTitle, "not_on_title" ); get(mpCBNotOnTitle, "not_on_title" );
get(mpCTPreview, "preview"); get(mpCTPreview, "preview");
mpCTPreview->init( pActualPage ? mpCTPreview->init( pActualPage ?
(pActualPage->IsMasterPage() ? pActualPage : (SdPage*)(&(pActualPage->TRG_GetMasterPage()))) : (pActualPage->IsMasterPage() ? pActualPage : (SdPage*)(&(pActualPage->TRG_GetMasterPage()))) :
(pDoc->GetMasterSdPage( 0, bHandoutMode ? PK_NOTES : PK_STANDARD )) ); (pDoc->GetMasterSdPage( 0, bHandoutMode ? PK_NOTES : PK_STANDARD )) );
if( mbHandoutMode ) if( mbHandoutMode )
{ {
...@@ -481,8 +470,7 @@ HeaderFooterTabPage::HeaderFooterTabPage( HeaderFooterDialog* pDialog, ::Window* ...@@ -481,8 +470,7 @@ HeaderFooterTabPage::HeaderFooterTabPage( HeaderFooterDialog* pDialog, ::Window*
} }
mpCBHeader->Show( mbHandoutMode ); mpCBHeader->Show( mbHandoutMode );
mpFTHeader->Show( mbHandoutMode ); mpHeaderBox->Show( mbHandoutMode );
mpTBHeader->Show( mbHandoutMode );
mpCBNotOnTitle->Show( !mbHandoutMode ); mpCBNotOnTitle->Show( !mbHandoutMode );
mpCBDateTime->SetClickHdl( LINK( this, HeaderFooterTabPage, UpdateOnClickHdl ) ); mpCBDateTime->SetClickHdl( LINK( this, HeaderFooterTabPage, UpdateOnClickHdl ) );
...@@ -500,18 +488,6 @@ HeaderFooterTabPage::HeaderFooterTabPage( HeaderFooterDialog* pDialog, ::Window* ...@@ -500,18 +488,6 @@ HeaderFooterTabPage::HeaderFooterTabPage( HeaderFooterDialog* pDialog, ::Window*
mpCBDateTimeLanguage->SelectLanguage( meOldLanguage ); mpCBDateTimeLanguage->SelectLanguage( meOldLanguage );
FillFormatList(SVXDATEFORMAT_A); FillFormatList(SVXDATEFORMAT_A);
mpTBHeader->SetAccessibleRelationMemberOf(mpCBHeader);
mpRBDateTimeFixed->SetAccessibleRelationMemberOf(mpCBDateTime);
mpRBDateTimeAutomatic->SetAccessibleRelationMemberOf(mpCBDateTime);
mpTBDateTimeFixed->SetAccessibleName(mpRBDateTimeFixed->GetText());
mpTBDateTimeFixed->SetAccessibleRelationMemberOf(mpCBDateTime);
mpTBDateTimeFixed->SetAccessibleRelationLabeledBy(mpRBDateTimeFixed);
mpCBDateTimeFormat->SetAccessibleRelationMemberOf(mpCBDateTime);
mpCBDateTimeFormat->SetAccessibleName(mpRBDateTimeAutomatic->GetText());
mpCBDateTimeFormat->SetAccessibleRelationLabeledBy(mpRBDateTimeAutomatic);
mpCBDateTimeLanguage->SetAccessibleRelationMemberOf(mpCBDateTime);
mpTBFooter->SetAccessibleRelationMemberOf(mpCBFooter);
} }
// ----------------------------------------------------------------------- // -----------------------------------------------------------------------
...@@ -626,11 +602,9 @@ void HeaderFooterTabPage::update() ...@@ -626,11 +602,9 @@ void HeaderFooterTabPage::update()
mpFTDateTimeLanguage->Enable( mpCBDateTime->IsChecked() && mpRBDateTimeAutomatic->IsChecked() ); mpFTDateTimeLanguage->Enable( mpCBDateTime->IsChecked() && mpRBDateTimeAutomatic->IsChecked() );
mpCBDateTimeLanguage->Enable( mpCBDateTime->IsChecked() && mpRBDateTimeAutomatic->IsChecked() ); mpCBDateTimeLanguage->Enable( mpCBDateTime->IsChecked() && mpRBDateTimeAutomatic->IsChecked() );
mpFTFooter->Enable( mpCBFooter->IsChecked() ); mpFooterBox->Enable( mpCBFooter->IsChecked() );
mpTBFooter->Enable( mpCBFooter->IsChecked() );
mpFTHeader->Enable( mpCBHeader->IsChecked() ); mpHeaderBox->Enable( mpCBHeader->IsChecked() );
mpTBHeader->Enable( mpCBHeader->IsChecked() );
HeaderFooterSettings aSettings; HeaderFooterSettings aSettings;
bool bNotOnTitle; bool bNotOnTitle;
...@@ -775,6 +749,11 @@ PresLayoutPreview::~PresLayoutPreview() ...@@ -775,6 +749,11 @@ PresLayoutPreview::~PresLayoutPreview()
{ {
} }
Size PresLayoutPreview::GetOptimalSize() const
{
return LogicToPixel(Size(80, 80), MAP_APPFONT);
}
// ----------------------------------------------------------------------- // -----------------------------------------------------------------------
void PresLayoutPreview::init( SdPage *pMaster ) void PresLayoutPreview::init( SdPage *pMaster )
......
...@@ -85,6 +85,8 @@ ...@@ -85,6 +85,8 @@
<object class="GtkNotebook" id="tabs"> <object class="GtkNotebook" id="tabs">
<property name="visible">True</property> <property name="visible">True</property>
<property name="can_focus">True</property> <property name="can_focus">True</property>
<property name="hexpand">True</property>
<property name="vexpand">True</property>
<child> <child>
<placeholder/> <placeholder/>
</child> </child>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment