Kaydet (Commit) ac5ecfeb authored tarafından Caolán McNamara's avatar Caolán McNamara Kaydeden (comit) Ashod Nakashian

ofz: optimize 1bit mask to avoid timeout

Change-Id: Ieaf3eb0800d2e80f16cfa29718d752e43ad534d0
Reviewed-on: https://gerrit.libreoffice.org/43418Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
(cherry picked from commit 035751dd)
Reviewed-on: https://gerrit.libreoffice.org/45457Reviewed-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
Tested-by: 's avatarAshod Nakashian <ashnakash@gmail.com>
üst f641e9d9
......@@ -1144,7 +1144,6 @@ Bitmap Bitmap::CreateMask( const Color& rTransColor, sal_uLong nTol ) const
if( !nTol )
{
const BitmapColor aTest( pReadAcc->GetBestMatchingColor( rTransColor ) );
long nX, nY;
if( pReadAcc->GetScanlineFormat() == ScanlineFormat::N4BitMsnPal ||
pReadAcc->GetScanlineFormat() == ScanlineFormat::N4BitLsnPal )
......@@ -1157,12 +1156,11 @@ Bitmap Bitmap::CreateMask( const Color& rTransColor, sal_uLong nTol ) const
aWhite.GetIndex() == 1 )
{
// optimized for 1Bit-MSB destination palette
for( nY = 0; nY < nHeight; nY++ )
for (long nY = 0; nY < nHeight; ++nY)
{
Scanline pSrc = pReadAcc->GetScanline( nY );
Scanline pDst = pWriteAcc->GetScanline( nY );
long nShift = 0;
for( nX = 0, nShift = nShiftInit; nX < nWidth; nX++, nShift ^= 4 )
for (long nX = 0, nShift = nShiftInit; nX < nWidth; nX++, nShift ^= 4)
{
if( cTest == ( ( pSrc[ nX >> 1 ] >> nShift ) & 0x0f ) )
pDst[ nX >> 3 ] |= 1 << ( 7 - ( nX & 7 ) );
......@@ -1173,11 +1171,10 @@ Bitmap Bitmap::CreateMask( const Color& rTransColor, sal_uLong nTol ) const
}
else
{
for( nY = 0; nY < nHeight; nY++ )
for (long nY = 0; nY < nHeight; ++nY)
{
Scanline pSrc = pReadAcc->GetScanline( nY );
long nShift = 0;
for( nX = 0, nShift = nShiftInit; nX < nWidth; nX++, nShift ^= 4 )
for (long nX = 0, nShift = nShiftInit; nX < nWidth; nX++, nShift ^= 4)
{
if( cTest == ( ( pSrc[ nX >> 1 ] >> nShift ) & 0x0f ) )
pWriteAcc->SetPixel( nY, nX, aWhite );
......@@ -1196,11 +1193,11 @@ Bitmap Bitmap::CreateMask( const Color& rTransColor, sal_uLong nTol ) const
aWhite.GetIndex() == 1 )
{
// optimized for 1Bit-MSB destination palette
for( nY = 0; nY < nHeight; nY++ )
for (long nY = 0; nY < nHeight; ++nY)
{
Scanline pSrc = pReadAcc->GetScanline( nY );
Scanline pDst = pWriteAcc->GetScanline( nY );
for( nX = 0; nX < nWidth; nX++ )
for (long nX = 0; nX < nWidth; ++nX)
{
if( cTest == pSrc[ nX ] )
pDst[ nX >> 3 ] |= 1 << ( 7 - ( nX & 7 ) );
......@@ -1211,10 +1208,10 @@ Bitmap Bitmap::CreateMask( const Color& rTransColor, sal_uLong nTol ) const
}
else
{
for( nY = 0; nY < nHeight; nY++ )
for (long nY = 0; nY < nHeight; ++nY)
{
Scanline pSrc = pReadAcc->GetScanline( nY );
for( nX = 0; nX < nWidth; nX++ )
for (long nX = 0; nX < nWidth; ++nX)
{
if( cTest == pSrc[ nX ] )
pWriteAcc->SetPixel( nY, nX, aWhite );
......@@ -1224,12 +1221,25 @@ Bitmap Bitmap::CreateMask( const Color& rTransColor, sal_uLong nTol ) const
}
}
}
else if (pWriteAcc->GetScanlineFormat() == pReadAcc->GetScanlineFormat() && aWhite.GetIndex() == 1 &&
(pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitLsbPal || pReadAcc->GetScanlineFormat() == ScanlineFormat::N1BitMsbPal))
{
for (long nY = 0; nY < nHeight; ++nY)
{
Scanline pSrc = pReadAcc->GetScanline(nY);
Scanline pDst = pWriteAcc->GetScanline(nY);
assert(pWriteAcc->GetScanlineSize() == pReadAcc->GetScanlineSize());
const long nScanlineSize = pWriteAcc->GetScanlineSize();
for (long nX = 0; nX < nScanlineSize; ++nX)
pDst[nX] = ~pSrc[nX];
}
}
else
{
// not optimized
for( nY = 0; nY < nHeight; nY++ )
for (long nY = 0; nY < nHeight; ++nY)
{
for( nX = 0; nX < nWidth; nX++ )
for (long nX = 0; nX < nWidth; ++nX)
{
if( aTest == pReadAcc->GetPixel( nY, nX ) )
pWriteAcc->SetPixel( nY, nX, aWhite );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment