silence coverity#1414485 Uninitialized pointer field

Change-Id: If62f528b1118aee702f364aa448e36230512fac6
Reviewed-on: https://gerrit.libreoffice.org/39572Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

sw/inc/bparr.hxx

@@ -54,14 +54,11 @@ public:
 
 struct BlockInfo final
 {
-    BigPtrArray* const
-                 pBigArr;              ///< in this array the block is located
+    BigPtrArray* pBigArr;              ///< in this array the block is located
     std::array<BigPtrEntry*, MAXENTRY>
                  mvData;               ///< data block
     sal_uLong    nStart, nEnd;         ///< start- and end index
     sal_uInt16   nElem;                ///< number of elements
-
-    BlockInfo(BigPtrArray* b) : pBigArr(b) {}
 };
 
 class SW_DLLPUBLIC BigPtrArray

sw/source/core/bastyp/bparr.cxx

@@ -156,7 +156,7 @@ void BigPtrArray::UpdIndex( sal_uInt16 pos )
 */
 BlockInfo* BigPtrArray::InsBlock( sal_uInt16 pos )
 {
-    BlockInfo* p = new BlockInfo(this);
+    BlockInfo* p = new BlockInfo;
     m_vpInf.insert( m_vpInf.begin() + pos, p );
 
     if( pos )
@@ -166,6 +166,7 @@ BlockInfo* BigPtrArray::InsBlock( sal_uInt16 pos )
 
     p->nEnd--;  // no elements
     p->nElem = 0;
+    p->pBigArr = this;
     return p;
 }