SdrSnapView: initializae members in the constructor

remove ClearVars() which was only
use by the constructor
instead initialize properly things in the constructor itself

Change-Id: I20a0ea26c5dce680844f81cf85ee72e1809a7068
Reviewed-on: https://gerrit.libreoffice.org/15890Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

include/svx/svdsnpv.hxx

@@ -91,9 +91,6 @@ protected:
     bool                        bHlplFixed : 1;              // sal_True= fixed auxiliary lines, so it isn't movable
     bool                        bEliminatePolyPoints : 1;
 
-private:
-    SVX_DLLPRIVATE void ClearVars();
-
 protected:
     // #i71538# make constructors of SdrView sub-components protected to avoid incomplete incarnations which may get casted to SdrView
     SdrSnapView(SdrModel* pModel1, OutputDevice* pOut = 0L);

svx/source/svdraw/svdsnpv.cxx

@@ -174,44 +174,36 @@ void ImplHelpLineOverlay::SetPosition(const basegfx::B2DPoint& rNewPosition)
 }
 
 
-void SdrSnapView::ClearVars()
+SdrSnapView::SdrSnapView(SdrModel* pModel1, OutputDevice* pOut)
+    : SdrPaintView(pModel1,pOut)
+    , mpPageOriginOverlay(0L)
+    , mpHelpLineOverlay(0L)
+    , nMagnSizPix(4)
+    , nSnapAngle(1500)
+    , nEliminatePolyPointLimitAngle(0)
+    , eCrookMode(SDRCROOK_ROTATE)
+    , bSnapEnab(true)
+    , bGridSnap(true)
+    , bSnapTo1Pix(true)
+    , bBordSnap(true)
+    , bHlplSnap(true)
+    , bOFrmSnap(true)
+    , bOPntSnap(false)
+    , bOConSnap(true)
+    , bMoveMFrmSnap(true)
+    , bMoveOFrmSnap(true)
+    , bMoveOPntSnap(true)
+    , bMoveOConSnap(true)
+    , bMoveSnapOnlyTopLeft(false)
+    , bOrtho(false)
+    , bBigOrtho(true)
+    , bAngleSnapEnab(false)
+    , bMoveOnlyDragging(false)
+    , bSlantButShear(false)
+    , bCrookNoContortion(false)
+    , bHlplFixed(false)
+    , bEliminatePolyPoints(false)
 {
-    nMagnSizPix=4;
-    bSnapEnab=true;
-    bGridSnap=true;
-    bSnapTo1Pix=true;
-    bBordSnap=true;
-    bHlplSnap=true;
-    bOFrmSnap=true;
-    bOPntSnap=false;
-    bOConSnap=true;
-    bMoveMFrmSnap=true;
-    bMoveOFrmSnap=true;
-    bMoveOPntSnap=true;
-    bMoveOConSnap=true;
-    bMoveSnapOnlyTopLeft=false;
-    bOrtho=false;
-    bBigOrtho=true;
-    nSnapAngle=1500;
-    bAngleSnapEnab=false;
-    bMoveOnlyDragging=false;
-    bSlantButShear=false;
-    bCrookNoContortion=false;
-    eCrookMode=SDRCROOK_ROTATE;
-    bHlplFixed=false;
-    bEliminatePolyPoints=false;
-    nEliminatePolyPointLimitAngle=0;
-
-    BrkSetPageOrg();
-    BrkDragHelpLine();
-}
-
-SdrSnapView::SdrSnapView(SdrModel* pModel1, OutputDevice* pOut):
-    SdrPaintView(pModel1,pOut),
-    mpPageOriginOverlay(0L),
-    mpHelpLineOverlay(0L)
-{
-    ClearVars();
 }
 
 SdrSnapView::~SdrSnapView()