Kaydet (Commit) b064a22f authored tarafından Noel Grandin's avatar Noel Grandin

loplugin:constparams in xmlsecurity

Change-Id: I41f153af55262d201c0fb024460de0e9f1c14670
Reviewed-on: https://gerrit.libreoffice.org/40472Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
üst 00c9cb73
......@@ -187,10 +187,10 @@ private:
void removeElementMarkBuffer(sal_Int32 nId);
OUString printBufferNode(
BufferNode* pBufferNode, sal_Int32 nIndent) const;
BufferNode const * pBufferNode, sal_Int32 nIndent) const;
static css::uno::Sequence< css::uno::Reference< css::xml::wrapper::XXMLElementWrapper > >
collectChildWorkingElement(BufferNode* pBufferNode);
collectChildWorkingElement(BufferNode const * pBufferNode);
void smashBufferNode(
BufferNode* pBufferNode, bool bClearRoot) const;
......
......@@ -28,7 +28,7 @@
XSECXMLSEC_DLLPUBLIC int xmlEnableStreamInputCallbacks() ;
XSECXMLSEC_DLLPUBLIC void xmlDisableStreamInputCallbacks() ;
XSECXMLSEC_DLLPUBLIC int xmlRegisterStreamInputCallbacks(
css::uno::Reference< css::xml::crypto::XUriBinding >& aUriBinding
css::uno::Reference< css::xml::crypto::XUriBinding > const & aUriBinding
);
XSECXMLSEC_DLLPUBLIC int xmlUnregisterStreamInputCallbacks() ;
......
......@@ -303,16 +303,16 @@ private:
sal_Int32 nDigestID );
void setReferenceCount() const;
void setX509IssuerName( OUString& ouX509IssuerName );
void setX509SerialNumber( OUString& ouX509SerialNumber );
void setX509Certificate( OUString& ouX509Certificate );
void setSignatureValue( OUString& ouSignatureValue );
void setDigestValue( sal_Int32 nDigestID, OUString& ouDigestValue );
void setGpgKeyID( OUString& ouKeyID );
void setGpgCertificate( OUString& ouGpgCert );
void setGpgOwner( OUString& ouGpgOwner );
void setDate( OUString& ouDate );
void setX509IssuerName( OUString const & ouX509IssuerName );
void setX509SerialNumber( OUString const & ouX509SerialNumber );
void setX509Certificate( OUString const & ouX509Certificate );
void setSignatureValue( OUString const & ouSignatureValue );
void setDigestValue( sal_Int32 nDigestID, OUString const & ouDigestValue );
void setGpgKeyID( OUString const & ouKeyID );
void setGpgCertificate( OUString const & ouGpgCert );
void setGpgOwner( OUString const & ouGpgOwner );
void setDate( OUString const & ouDate );
void setDescription(const OUString& rDescription);
void setCertDigest(const OUString& rCertDigest);
......@@ -320,8 +320,8 @@ public:
void setSignatureBytes(const css::uno::Sequence<sal_Int8>& rBytes);
private:
void setId( OUString& ouId );
void setPropertyId( OUString& ouPropertyId );
void setId( OUString const & ouId );
void setPropertyId( OUString const & ouPropertyId );
css::uno::Reference< css::xml::crypto::sax::XReferenceResolvedListener > prepareSignatureToRead(
sal_Int32 nSecurityId );
......
......@@ -272,7 +272,7 @@ void SAXEventKeeperImpl::removeElementMarkBuffer(sal_Int32 nId)
}
OUString SAXEventKeeperImpl::printBufferNode(
BufferNode* pBufferNode, sal_Int32 nIndent) const
BufferNode const * pBufferNode, sal_Int32 nIndent) const
/****** SAXEventKeeperImpl/printBufferNode ***********************************
*
* NAME
......@@ -340,7 +340,7 @@ OUString SAXEventKeeperImpl::printBufferNode(
for( auto jj = vChildren->begin();
jj != vChildren->end(); ++jj )
{
rc += printBufferNode(const_cast<BufferNode *>(*jj), nIndent+4);
rc += printBufferNode(*jj, nIndent+4);
}
delete vChildren;
......@@ -349,7 +349,7 @@ OUString SAXEventKeeperImpl::printBufferNode(
}
cssu::Sequence< cssu::Reference< cssxw::XXMLElementWrapper > >
SAXEventKeeperImpl::collectChildWorkingElement(BufferNode* pBufferNode)
SAXEventKeeperImpl::collectChildWorkingElement(BufferNode const * pBufferNode)
/****** SAXEventKeeperImpl/collectChildWorkingElement ************************
*
* NAME
......
......@@ -209,7 +209,7 @@ void XSecController::setReferenceCount() const
}
}
void XSecController::setX509IssuerName( OUString& ouX509IssuerName )
void XSecController::setX509IssuerName( OUString const & ouX509IssuerName )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -220,7 +220,7 @@ void XSecController::setX509IssuerName( OUString& ouX509IssuerName )
isi.signatureInfor.ouX509IssuerName = ouX509IssuerName;
}
void XSecController::setX509SerialNumber( OUString& ouX509SerialNumber )
void XSecController::setX509SerialNumber( OUString const & ouX509SerialNumber )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -231,7 +231,7 @@ void XSecController::setX509SerialNumber( OUString& ouX509SerialNumber )
isi.signatureInfor.ouX509SerialNumber = ouX509SerialNumber;
}
void XSecController::setX509Certificate( OUString& ouX509Certificate )
void XSecController::setX509Certificate( OUString const & ouX509Certificate )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -242,7 +242,7 @@ void XSecController::setX509Certificate( OUString& ouX509Certificate )
isi.signatureInfor.ouX509Certificate = ouX509Certificate;
}
void XSecController::setSignatureValue( OUString& ouSignatureValue )
void XSecController::setSignatureValue( OUString const & ouSignatureValue )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -253,7 +253,7 @@ void XSecController::setSignatureValue( OUString& ouSignatureValue )
isi.signatureInfor.ouSignatureValue = ouSignatureValue;
}
void XSecController::setDigestValue( sal_Int32 nDigestID, OUString& ouDigestValue )
void XSecController::setDigestValue( sal_Int32 nDigestID, OUString const & ouDigestValue )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -272,7 +272,7 @@ void XSecController::setDigestValue( sal_Int32 nDigestID, OUString& ouDigestValu
reference.ouDigestValue = ouDigestValue;
}
void XSecController::setGpgKeyID( OUString& ouKeyID )
void XSecController::setGpgKeyID( OUString const & ouKeyID )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -283,7 +283,7 @@ void XSecController::setGpgKeyID( OUString& ouKeyID )
isi.signatureInfor.ouGpgKeyID = ouKeyID;
}
void XSecController::setGpgCertificate( OUString& ouGpgCert )
void XSecController::setGpgCertificate( OUString const & ouGpgCert )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -294,7 +294,7 @@ void XSecController::setGpgCertificate( OUString& ouGpgCert )
isi.signatureInfor.ouGpgCertificate = ouGpgCert;
}
void XSecController::setGpgOwner( OUString& ouGpgOwner )
void XSecController::setGpgOwner( OUString const & ouGpgOwner )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -305,7 +305,7 @@ void XSecController::setGpgOwner( OUString& ouGpgOwner )
isi.signatureInfor.ouGpgOwner = ouGpgOwner;
}
void XSecController::setDate( OUString& ouDate )
void XSecController::setDate( OUString const & ouDate )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -356,7 +356,7 @@ void XSecController::addEncapsulatedX509Certificate(const OUString& rEncapsulate
rInformation.signatureInfor.maEncapsulatedX509Certificates.insert(rEncapsulatedX509Certificate);
}
void XSecController::setId( OUString& ouId )
void XSecController::setId( OUString const & ouId )
{
if (m_vInternalSignatureInformations.empty())
{
......@@ -367,7 +367,7 @@ void XSecController::setId( OUString& ouId )
isi.signatureInfor.ouSignatureId = ouId;
}
void XSecController::setPropertyId( OUString& ouPropertyId )
void XSecController::setPropertyId( OUString const & ouPropertyId )
{
if (m_vInternalSignatureInformations.empty())
{
......
......@@ -52,7 +52,7 @@ class CertificateExtension_XmlSecImpl : public ::cppu::WeakImplHelper<
return m_Extn.m_xExtnValue;
}
void setCertExtn(unsigned char* value, unsigned int vlen, unsigned char* id, unsigned int idlen, bool critical)
void setCertExtn(unsigned char const * value, unsigned int vlen, unsigned char const * id, unsigned int idlen, bool critical)
{
m_Extn.setCertExtn(value, vlen, id, idlen, critical);
}
......
......@@ -58,7 +58,7 @@ class SanExtensionImpl : public ::cppu::WeakImplHelper<
return m_Extn.m_xExtnValue;
}
void setCertExtn(unsigned char* value, unsigned int vlen, unsigned char* id, unsigned int idlen, bool critical)
void setCertExtn(unsigned char const * value, unsigned int vlen, unsigned char const * id, unsigned int idlen, bool critical)
{
m_Extn.setCertExtn(value, vlen, id, idlen, critical);
}
......
......@@ -348,7 +348,7 @@ const Sequence< sal_Int8>& X509Certificate_NssImpl::getUnoTunnelId() {
return theX509Certificate_NssImplUnoTunnelId::get().getSeq();
}
OUString getAlgorithmDescription(SECAlgorithmID *aid)
OUString getAlgorithmDescription(SECAlgorithmID const *aid)
{
SECOidTag tag;
tag = SECOID_GetAlgorithmTag(aid);
......
......@@ -181,7 +181,7 @@ XSECXMLSEC_DLLPUBLIC int xmlEnableStreamInputCallbacks()
}
XSECXMLSEC_DLLPUBLIC int xmlRegisterStreamInputCallbacks(
css::uno::Reference< css::xml::crypto::XUriBinding >& aUriBinding
css::uno::Reference< css::xml::crypto::XUriBinding > const & aUriBinding
) {
if( !( enableXmlStreamIO & XMLSTREAMIO_INITIALIZED ) ) {
if( xmlEnableStreamInputCallbacks() < 0 )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment