sw_redlinehide: rename it to SwAttrIter::MaybeHasHints()

... because it's only used as an optimization currently, so we just use
the slow-path if there is a merged paragraph.

Change-Id: I8b577174e65edd0e5210971511e054fd719de96a

sw/source/core/text/itratr.cxx

@@ -96,6 +96,11 @@ SwAttrIter::~SwAttrIter()
     delete m_pFont;
 }
 
+bool SwAttrIter::MaybeHasHints() const
+{
+    return nullptr != m_pTextNode->GetpSwpHints() || nullptr != m_pMergedPara;
+}
+
 /**
  * Returns the attribute for a position
  *

sw/source/core/text/itratr.hxx

@@ -118,8 +118,8 @@ public:
     bool SeekAndChgAttrIter(TextFrameIndex nPos, OutputDevice* pOut);
     bool SeekStartAndChgAttrIter( OutputDevice* pOut, const bool bParaFont );
 
-    // Do we have an attribute change at all?
-    bool HasHints() const { return nullptr != m_pHints; }
+    // Do we possibly have nasty things like footnotes?
+    bool MaybeHasHints() const;
 
     // Returns the attribute for a position
     SwTextAttr *GetAttr(TextFrameIndex nPos) const;

sw/source/core/text/itrtxt.cxx

@@ -322,7 +322,7 @@ void SwTextIter::TruncLines( bool bNoteFollow )
     if( pDel )
     {
         m_pCurr->SetNext( nullptr );
-        if (HasHints() && bNoteFollow)
+        if (MaybeHasHints() && bNoteFollow)
         {
             GetInfo().GetParaPortion()->SetFollowField( pDel->IsRest() ||
                                                         lcl_NeedsFieldRest( m_pCurr ) );
@@ -367,7 +367,7 @@ void SwTextIter::TruncLines( bool bNoteFollow )
     {
         m_pCurr->SetRealHeight( 1 );
     }
-    if (HasHints())
+    if (MaybeHasHints())
         m_pFrame->RemoveFootnote( nEnd );
 }