Some cppcheck cleaning

Change-Id: I3d515fabc272e5c14f2e2779da1c43f92514f290

cui/source/tabpages/tparea.cxx

@@ -1001,12 +1001,12 @@ int SvxAreaTabPage::DeactivatePage( SfxItemSet* _pSet )
 
 sal_Bool SvxAreaTabPage::FillItemSet( SfxItemSet& rAttrs )
 {
-    const SfxPoolItem* pOld = NULL;
     sal_uInt16  _nPos;
     sal_Bool    bModified = sal_False;
 
     if( nDlgType != 0 || *pbAreaTP )
     {
+        const SfxPoolItem* pOld = NULL;
         XFillStyle eStyle = (XFillStyle) aTypeLB.GetSelectEntryPos();
         XFillStyle eSavedStyle = (XFillStyle) aTypeLB.GetSavedValue();
         switch( eStyle )

filter/source/graphicfilter/idxf/dxfreprd.hxx

@@ -40,7 +40,7 @@ public:
     double fMaxY;
     double fMaxZ;
 
-    DXFBoundingBox() { bEmpty=sal_True; }
+    DXFBoundingBox():bEmpty(sal_True), fMinX(0.0), fMinY(0.0), fMinZ(0.0), fMaxX(0.0), fMaxY(0.0), fMaxZ(0.0) {}
     void Union(const DXFVector & rVector);
 };
 

l10ntools/source/helpmerge.cxx

@@ -184,7 +184,6 @@ bool HelpParser::Merge( const rtl::OString &rSDFFile, const rtl::OString &rDesti
 {
 
     (void) rSDFFile;
-    bool hasNoError = true;
 
     SimpleXMLParser aParser;
 
@@ -193,7 +192,7 @@ bool HelpParser::Merge( const rtl::OString &rSDFFile, const rtl::OString &rDesti
     //TODO: explicit BOM handling?
 
     XMLFile* xmlfile = ( aParser.Execute( sXmlFile, new XMLFile( rtl::OUString('0') ) ) );
-    hasNoError = MergeSingleFile( xmlfile , aMergeDataFile , rLanguage , rDestinationFile );
+    bool hasNoError = MergeSingleFile( xmlfile , aMergeDataFile , rLanguage , rDestinationFile );
     delete xmlfile;
     return hasNoError;
 }
@@ -233,7 +232,6 @@ void HelpParser::ProcessHelp( LangHashMap* aLangHM , const rtl::OString& sCur ,
 
     XMLElement*   pXMLElement = NULL;
     PFormEntrys   *pEntrys    = NULL;
-    XMLData       *data       = NULL;
 
     rtl::OString sLId;
     rtl::OString sGId;
@@ -284,7 +282,7 @@ void HelpParser::ProcessHelp( LangHashMap* aLangHM , const rtl::OString& sCur ,
                 {
                     if( pXMLElement != NULL )
                     {
-                        data   = new XMLData( sNewdata , NULL , true ); // Add new one
+                        XMLData *data = new XMLData( sNewdata , NULL , true ); // Add new one
                         pXMLElement->RemoveAndDeleteAllChildren();
                         pXMLElement->AddChild( data );
                         aLangHM->erase( sCur );

scaddins/source/pricing/black_scholes.cxx

@@ -185,7 +185,7 @@ double bincash(double S, double vol, double rd, double rf,
             val = -pm*dnorm(d2)*sqrt(tau)/vol;
             break;
         default:
-            printf("bincash: greek %ui not implemented\n", greeks );
+            printf("bincash: greek %d not implemented\n", greeks );
             abort();
         }
     }
@@ -286,7 +286,7 @@ double binasset(double S, double vol, double rd, double rf,
             val = -tau*S*pnorm(pm*d1) - pm*S*dnorm(d1)*sqrt(tau)/vol;
             break;
         default:
-            printf("binasset: greek %ui not implemented\n", greeks );
+            printf("binasset: greek %d not implemented\n", greeks );
             abort();
         }
     }
@@ -652,7 +652,7 @@ double barrier_term(double S, double vol, double rd, double rf,
               );
         break;
     default:
-        printf("barrier_term: greek %ui not implemented\n", greek );
+        printf("barrier_term: greek %d not implemented\n", greek );
         abort();
     }
     return val;
@@ -708,7 +708,7 @@ double barrier_double_term( double S, double vol, double rd, double rf,
               barrier_term(S,vol,rd,rf,tau,K,B1,B2,sc,pc,fd,types::Value);
         break;
     default:
-        printf("barrier_double_term: greek %ui not implemented\n", greek );
+        printf("barrier_double_term: greek %d not implemented\n", greek );
         abort();
     }
     return val;

sfx2/source/control/dispatch.cxx

@@ -101,9 +101,7 @@ struct SfxObjectBars_Impl
     String         aName;
     SfxInterface*  pIFace;
 
-    SfxObjectBars_Impl() :
-        nResId( 0 )
-    {}
+    SfxObjectBars_Impl() : nResId(0), nMode(0), pIFace(NULL) {}
 };
 
 //------------------------------------------------------------------

vcl/unx/generic/window/salframe.cxx

@@ -1522,7 +1522,6 @@ void X11SalFrame::SetWindowState( const SalFrameState *pState )
     if (pState->mnMask & _FRAMESTATE_MASK_GEOMETRY)
     {
         Rectangle aPosSize;
-        bool bDoAdjust = false;
 
         /* #i44325#
          * if maximized, set restore size and guess maximized size from last time
@@ -1562,6 +1561,7 @@ void X11SalFrame::SetWindowState( const SalFrameState *pState )
         }
         else
         {
+            bool bDoAdjust = false;
             // initialize with current geometry
             if ((pState->mnMask & _FRAMESTATE_MASK_GEOMETRY) != _FRAMESTATE_MASK_GEOMETRY)
                 GetPosSize (aPosSize);