Kaydet (Commit) b564df24 authored tarafından Cédric Bosdonnat's avatar Cédric Bosdonnat

fdo#37403: Fixed crasher by using boost::shared_ptr

üst d2a1da36
...@@ -31,6 +31,7 @@ ...@@ -31,6 +31,7 @@
#include <svx/svdotext.hxx> #include <svx/svdotext.hxx>
#include "svx/svxdllapi.h" #include "svx/svxdllapi.h"
#include <boost/shared_ptr.hpp>
//************************************************************ //************************************************************
// Vorausdeklarationen // Vorausdeklarationen
...@@ -60,7 +61,7 @@ protected: ...@@ -60,7 +61,7 @@ protected:
virtual sdr::contact::ViewContact* CreateObjectSpecificViewContact(); virtual sdr::contact::ViewContact* CreateObjectSpecificViewContact();
virtual sdr::properties::BaseProperties* CreateObjectSpecificProperties(); virtual sdr::properties::BaseProperties* CreateObjectSpecificProperties();
XPolygon* mpXPoly; ::boost::shared_ptr< XPolygon > mpXPoly;
protected: protected:
// Liefert sal_True, wenn das Painten ein Polygon erfordert. // Liefert sal_True, wenn das Painten ein Polygon erfordert.
......
...@@ -291,7 +291,7 @@ basegfx::B2DPolygon SdrCircObj::ImpCalcXPolyCirc(const SdrObjKind eCicrleKind, c ...@@ -291,7 +291,7 @@ basegfx::B2DPolygon SdrCircObj::ImpCalcXPolyCirc(const SdrObjKind eCicrleKind, c
void SdrCircObj::RecalcXPoly() void SdrCircObj::RecalcXPoly()
{ {
const basegfx::B2DPolygon aPolyCirc(ImpCalcXPolyCirc(meCircleKind, aRect, nStartWink, nEndWink)); const basegfx::B2DPolygon aPolyCirc(ImpCalcXPolyCirc(meCircleKind, aRect, nStartWink, nEndWink));
mpXPoly = new XPolygon(aPolyCirc); mpXPoly.reset( new XPolygon(aPolyCirc) );
} }
void SdrCircObj::TakeObjNameSingul(XubString& rName) const void SdrCircObj::TakeObjNameSingul(XubString& rName) const
......
...@@ -78,21 +78,18 @@ sdr::contact::ViewContact* SdrRectObj::CreateObjectSpecificViewContact() ...@@ -78,21 +78,18 @@ sdr::contact::ViewContact* SdrRectObj::CreateObjectSpecificViewContact()
TYPEINIT1(SdrRectObj,SdrTextObj); TYPEINIT1(SdrRectObj,SdrTextObj);
SdrRectObj::SdrRectObj() SdrRectObj::SdrRectObj()
: mpXPoly(0L)
{ {
bClosedObj=sal_True; bClosedObj=sal_True;
} }
SdrRectObj::SdrRectObj(const Rectangle& rRect) SdrRectObj::SdrRectObj(const Rectangle& rRect)
: SdrTextObj(rRect), : SdrTextObj(rRect)
mpXPoly(NULL)
{ {
bClosedObj=sal_True; bClosedObj=sal_True;
} }
SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind) SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind)
: SdrTextObj(eNewTextKind), : SdrTextObj(eNewTextKind)
mpXPoly(NULL)
{ {
DBG_ASSERT(eTextKind==OBJ_TEXT || eTextKind==OBJ_TEXTEXT || DBG_ASSERT(eTextKind==OBJ_TEXT || eTextKind==OBJ_TEXTEXT ||
eTextKind==OBJ_OUTLINETEXT || eTextKind==OBJ_TITLETEXT, eTextKind==OBJ_OUTLINETEXT || eTextKind==OBJ_TITLETEXT,
...@@ -101,8 +98,7 @@ SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind) ...@@ -101,8 +98,7 @@ SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind)
} }
SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rRect) SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rRect)
: SdrTextObj(eNewTextKind,rRect), : SdrTextObj(eNewTextKind,rRect)
mpXPoly(NULL)
{ {
DBG_ASSERT(eTextKind==OBJ_TEXT || eTextKind==OBJ_TEXTEXT || DBG_ASSERT(eTextKind==OBJ_TEXT || eTextKind==OBJ_TEXTEXT ||
eTextKind==OBJ_OUTLINETEXT || eTextKind==OBJ_TITLETEXT, eTextKind==OBJ_OUTLINETEXT || eTextKind==OBJ_TITLETEXT,
...@@ -111,8 +107,7 @@ SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rRect) ...@@ -111,8 +107,7 @@ SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rRect)
} }
SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rNewRect, SvStream& rInput, const String& rBaseURL, sal_uInt16 eFormat) SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rNewRect, SvStream& rInput, const String& rBaseURL, sal_uInt16 eFormat)
: SdrTextObj(eNewTextKind,rNewRect,rInput,rBaseURL,eFormat), : SdrTextObj(eNewTextKind,rNewRect,rInput,rBaseURL,eFormat)
mpXPoly(NULL)
{ {
DBG_ASSERT(eTextKind==OBJ_TEXT || eTextKind==OBJ_TEXTEXT || DBG_ASSERT(eTextKind==OBJ_TEXT || eTextKind==OBJ_TEXTEXT ||
eTextKind==OBJ_OUTLINETEXT || eTextKind==OBJ_TITLETEXT, eTextKind==OBJ_OUTLINETEXT || eTextKind==OBJ_TITLETEXT,
...@@ -122,19 +117,11 @@ SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rNewRect, SvStr ...@@ -122,19 +117,11 @@ SdrRectObj::SdrRectObj(SdrObjKind eNewTextKind, const Rectangle& rNewRect, SvStr
SdrRectObj::~SdrRectObj() SdrRectObj::~SdrRectObj()
{ {
if(mpXPoly)
{
delete mpXPoly;
}
} }
void SdrRectObj::SetXPolyDirty() void SdrRectObj::SetXPolyDirty()
{ {
if(mpXPoly) mpXPoly.reset();
{
delete mpXPoly;
mpXPoly = 0L;
}
} }
bool SdrRectObj::PaintNeedsXPoly(long nEckRad) const bool SdrRectObj::PaintNeedsXPoly(long nEckRad) const
...@@ -169,7 +156,7 @@ XPolygon SdrRectObj::ImpCalcXPoly(const Rectangle& rRect1, long nRad1) const ...@@ -169,7 +156,7 @@ XPolygon SdrRectObj::ImpCalcXPoly(const Rectangle& rRect1, long nRad1) const
void SdrRectObj::RecalcXPoly() void SdrRectObj::RecalcXPoly()
{ {
mpXPoly = new XPolygon(ImpCalcXPoly(aRect,GetEckenradius())); mpXPoly.reset( new XPolygon(ImpCalcXPoly(aRect,GetEckenradius())) );
} }
const XPolygon& SdrRectObj::GetXPoly() const const XPolygon& SdrRectObj::GetXPoly() const
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment