Kaydet (Commit) b6f52c5c authored tarafından Mark Hung's avatar Mark Hung

tdf#96052 - export the forbidden shape as path instead of preset shape.

OOXML noSmoking shape has different definition so that convert LO's
forbidden shape to OOXML noSmoking do not produce good result.
I put it on whitelist and now the geometry looks correct although handle
is lost.

This partially revert unit test for the shape in
2b4f9d0b, where forbidden is exported as
a preset shape.

Change-Id: I2e134940fa4a36e6b7b814b008d859691fbcdd6a
Reviewed-on: https://gerrit.libreoffice.org/31110Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarMark Hung <marklh9@gmail.com>
üst 6bb20609
...@@ -547,7 +547,6 @@ static bool lcl_IsOnBlacklist(OUString& rShapeType) ...@@ -547,7 +547,6 @@ static bool lcl_IsOnBlacklist(OUString& rShapeType)
OUStringLiteral("smiley"), OUStringLiteral("smiley"),
OUStringLiteral("sun"), OUStringLiteral("sun"),
OUStringLiteral("flower"), OUStringLiteral("flower"),
OUStringLiteral("forbidden"),
OUStringLiteral("bracket-pair"), OUStringLiteral("bracket-pair"),
OUStringLiteral("brace-pair"), OUStringLiteral("brace-pair"),
OUStringLiteral("col-60da8460"), OUStringLiteral("col-60da8460"),
...@@ -606,6 +605,7 @@ static bool lcl_IsOnWhitelist(OUString& rShapeType) ...@@ -606,6 +605,7 @@ static bool lcl_IsOnWhitelist(OUString& rShapeType)
static static
#endif #endif
const std::initializer_list<OUStringLiteral> vWhitelist = { const std::initializer_list<OUStringLiteral> vWhitelist = {
OUStringLiteral("forbidden"),
OUStringLiteral("heart"), OUStringLiteral("heart"),
OUStringLiteral("puzzle") OUStringLiteral("puzzle")
}; };
...@@ -918,12 +918,6 @@ ShapeExport& ShapeExport::WriteCustomShape( const Reference< XShape >& xShape ) ...@@ -918,12 +918,6 @@ ShapeExport& ShapeExport::WriteCustomShape( const Reference< XShape >& xShape )
lcl_AppendAdjustmentValue( aAvList, 0, adj ); lcl_AppendAdjustmentValue( aAvList, 0, adj );
break; break;
} }
case mso_sptNoSmoking:
{
sal_Int32 adj = double( nXPosition )/7200 *50000 ;
lcl_AppendAdjustmentValue( aAvList, 0, adj );
break;
}
case mso_sptDonut: case mso_sptDonut:
case mso_sptSun: case mso_sptSun:
case mso_sptMoon: case mso_sptMoon:
......
...@@ -467,8 +467,6 @@ void SdOOXMLExportTest2::testPresetShapesExport() ...@@ -467,8 +467,6 @@ void SdOOXMLExportTest2::testPresetShapesExport()
"adj1","val 10490", "adj1","val 10490",
"donut", "donut",
"adj","val 9601", "adj","val 9601",
"noSmoking",
"adj","val 16118",
"bevel", "bevel",
"adj","val 42587", "adj","val 42587",
"foldedCorner", "foldedCorner",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment