tdf#93384 editeng rendercontext: don't paint spellcheck result directly

E.g. in Writer create a new comment, type a word that is not in the
dictionary, then a space to trigger the spelling, and that painted the
spelling error indicator outside Paint().

(cherry picked from commits 71aed918 and
89bd30cf)

Change-Id: I8f72486189e04a5596729fb52b6af39772f8e002
Reviewed-on: https://gerrit.libreoffice.org/17690Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

editeng/source/editeng/impedit4.cxx

@@ -2414,8 +2414,7 @@ void ImpEditEngine::DoOnlineSpelling( ContentNode* pThisNodeOnly, bool bSpellAtC
                             {
                                 // convert to window coordinates ....
                                 aClipRect.SetPos( pView->pImpEditView->GetWindowPos( aClipRect.TopLeft() ) );
-                                // If selected, then VDev ...
-                                Paint( pView->pImpEditView, aClipRect, 0, pView->HasSelection() );
+                                pView->pImpEditView->GetWindow()->Invalidate(aClipRect);
                             }
                         }
                     }

sw/source/core/view/viewsh.cxx

@@ -1677,8 +1677,8 @@ public:
             rtl::Reference<sdr::overlay::OverlayManager> xOldManager = pOldPaintWindow->GetOverlayManager();
             if (xOldManager.is())
             {
-                SdrPaintWindow* pNewPaintWindow = m_pShell->Imp()->GetDrawView()->FindPaintWindow(*m_pRef);
-                xOldManager->completeRedraw(pNewPaintWindow->GetRedrawRegion(), m_pRef);
+                if (SdrPaintWindow* pNewPaintWindow = m_pShell->Imp()->GetDrawView()->FindPaintWindow(*m_pRef))
+                    xOldManager->completeRedraw(pNewPaintWindow->GetRedrawRegion(), m_pRef);
             }
 
             m_pShell->Imp()->GetDrawView()->DeleteWindowFromPaintView(m_pRef);