Kaydet (Commit) bd53697b authored tarafından Stephan Bergmann's avatar Stephan Bergmann

clang-analyzer-deadcode.DeadStores

...ever since OResultSet::fillNeededData got introduced in
8687beec "INTEGRATION: CWS insight01" (and the
return value of the N3SQLPutData call in the first case block had always been
ignored completely, not even unnecessarily assigned to nRet as in these later
two case blocks)

Change-Id: I1d2005e7c91749510b23f86ac792bd11ae564608
üst 4e95a613
...@@ -1805,7 +1805,7 @@ void OResultSet::fillNeededData(SQLRETURN _nRet) ...@@ -1805,7 +1805,7 @@ void OResultSet::fillNeededData(SQLRETURN _nRet)
{ {
OUString sRet; OUString sRet;
sRet = m_aRow[nColumnIndex].getString(); sRet = m_aRow[nColumnIndex].getString();
nRet = N3SQLPutData (m_aStatementHandle, static_cast<SQLPOINTER>(const_cast<sal_Unicode *>(sRet.getStr())), sizeof(sal_Unicode)*sRet.getLength()); N3SQLPutData (m_aStatementHandle, static_cast<SQLPOINTER>(const_cast<sal_Unicode *>(sRet.getStr())), sizeof(sal_Unicode)*sRet.getLength());
break; break;
} }
case DataType::LONGVARCHAR: case DataType::LONGVARCHAR:
...@@ -1814,7 +1814,7 @@ void OResultSet::fillNeededData(SQLRETURN _nRet) ...@@ -1814,7 +1814,7 @@ void OResultSet::fillNeededData(SQLRETURN _nRet)
OUString sRet; OUString sRet;
sRet = m_aRow[nColumnIndex].getString(); sRet = m_aRow[nColumnIndex].getString();
OString aString(OUStringToOString(sRet,m_nTextEncoding)); OString aString(OUStringToOString(sRet,m_nTextEncoding));
nRet = N3SQLPutData (m_aStatementHandle, static_cast<SQLPOINTER>(const_cast<char *>(aString.getStr())), aString.getLength()); N3SQLPutData (m_aStatementHandle, static_cast<SQLPOINTER>(const_cast<char *>(aString.getStr())), aString.getLength());
break; break;
} }
default: default:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment