Kaydet (Commit) bd6723fd authored tarafından Noel Grandin's avatar Noel Grandin

disable the 'two different log areas in the same file' loplugin check

too many false+ to leave it alive by default

Change-Id: I6d8f92b630c351c1ac788fad79f8d7c435ba4963
üst 8ad521d9
...@@ -110,6 +110,8 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location ) ...@@ -110,6 +110,8 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location )
checkAreaSyntax(area, location); checkAreaSyntax(area, location);
return; return;
} }
// don't leave this alive by default, generates too many false+
#if 0
if (compiler.getSourceManager().isInMainFile(location)) if (compiler.getSourceManager().isInMainFile(location))
{ {
auto matchpair = [this,area](StringRef p1, StringRef p2) { auto matchpair = [this,area](StringRef p1, StringRef p2) {
...@@ -166,6 +168,7 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location ) ...@@ -166,6 +168,7 @@ void SalLogAreas::checkArea( StringRef area, SourceLocation location )
firstSeenLocation ); firstSeenLocation );
} }
} }
#endif
} }
void SalLogAreas::checkAreaSyntax(StringRef area, SourceLocation location) { void SalLogAreas::checkAreaSyntax(StringRef area, SourceLocation location) {
......
...@@ -35,8 +35,10 @@ class SalLogAreas ...@@ -35,8 +35,10 @@ class SalLogAreas
const FunctionDecl* inFunction; const FunctionDecl* inFunction;
SourceLocation lastSalDetailLogStreamMacro; SourceLocation lastSalDetailLogStreamMacro;
set< string > logAreas; set< string > logAreas;
#if 0
string firstSeenLogArea; string firstSeenLogArea;
SourceLocation firstSeenLocation; SourceLocation firstSeenLocation;
#endif
}; };
} // namespace } // namespace
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment