cppcheck: noExplicitConstructor

Change-Id: I80cd2975f17bb7fa57fa669873ef1dd8f3595a11

desktop/source/app/cmdlineargs.hxx

@@ -51,7 +51,7 @@ class CommandLineArgs: private boost::noncopyable
         };
 
         CommandLineArgs();
-        CommandLineArgs( Supplier& supplier );
+        explicit CommandLineArgs( Supplier& supplier );
 
         boost::optional< OUString > getCwdUrl() const { return m_cwdUrl; }
 

desktop/source/app/desktopresid.hxx

@@ -28,7 +28,7 @@ namespace desktop
 class DesktopResId : public ResId
 {
     public:
-        DesktopResId( sal_uInt16 nId );
+        explicit DesktopResId( sal_uInt16 nId );
 };
 
 }

desktop/source/deployment/gui/dp_gui.h

@@ -68,7 +68,7 @@ enum PackageState { REGISTERED, NOT_REGISTERED, AMBIGUOUS, NOT_AVAILABLE };
 class SelectedPackage: public salhelper::SimpleReferenceObject {
 public:
     SelectedPackage() {}
-    SelectedPackage( const ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage> &xPackage)
+    explicit SelectedPackage( const ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage> &xPackage)
     : m_xPackage( xPackage )
     {}
 

desktop/source/deployment/gui/dp_gui_dialog2.cxx

@@ -136,8 +136,8 @@ class ExtBoxWithBtns_Impl : public ExtensionBox_Impl
     DECL_DLLPRIVATE_LINK( HandleRemoveBtn, void * );
 
 public:
-                    ExtBoxWithBtns_Impl(vcl::Window* pParent);
-                   virtual ~ExtBoxWithBtns_Impl();
+    explicit ExtBoxWithBtns_Impl(vcl::Window* pParent);
+    virtual ~ExtBoxWithBtns_Impl();
     virtual void dispose() SAL_OVERRIDE;
 
     void InitFromDialog(ExtMgrDialog *pParentDialog);

desktop/source/deployment/gui/dp_gui_extlistbox.cxx

@@ -46,7 +46,7 @@ struct FindWeakRef
 {
     const uno::Reference<deployment::XPackage> m_extension;
 
-    FindWeakRef( uno::Reference<deployment::XPackage> const & ext): m_extension(ext) {}
+    explicit FindWeakRef( uno::Reference<deployment::XPackage> const & ext): m_extension(ext) {}
     bool operator () (uno::WeakReference< deployment::XPackage >  const & ref);
 };
 

desktop/source/deployment/gui/dp_gui_extlistbox.hxx

@@ -96,8 +96,8 @@ class ExtensionRemovedListener : public ::cppu::WeakImplHelper1<css::lang::XEven
 
 public:
 
-    ExtensionRemovedListener( ExtensionBox_Impl *pParent ) { m_pParent = pParent; }
-   virtual ~ExtensionRemovedListener();
+    explicit ExtensionRemovedListener( ExtensionBox_Impl *pParent ) { m_pParent = pParent; }
+    virtual ~ExtensionRemovedListener();
 
 
     // XEventListener
@@ -173,7 +173,7 @@ class ExtensionBox_Impl : public ::svt::IExtensionListBox
 
     void Init();
 public:
-    ExtensionBox_Impl(vcl::Window* pParent);
+    explicit ExtensionBox_Impl(vcl::Window* pParent);
     virtual ~ExtensionBox_Impl();
     virtual void dispose() SAL_OVERRIDE;
 

desktop/source/deployment/gui/dp_gui_shared.hxx

@@ -36,7 +36,7 @@ struct DeploymentGuiResMgr :
 class DpGuiResId : public ResId
 {
 public:
-    DpGuiResId( sal_uInt16 nId ):ResId( nId, *DeploymentGuiResMgr::get() ) {}
+    explicit DpGuiResId( sal_uInt16 nId ):ResId( nId, *DeploymentGuiResMgr::get() ) {}
 };
 
 #define DPGUI_RESSTR(i)   DpGuiResId(i).toString()

desktop/source/deployment/gui/dp_gui_updatedata.hxx

@@ -38,7 +38,7 @@ namespace dp_gui {
 
 struct UpdateData
 {
-    UpdateData( ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage > const & aExt):
+    explicit UpdateData( ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage > const & aExt):
         bIsShared(false), aInstalledPackage(aExt), aUpdateSource(NULL), m_nID(0), m_bIgnored(false){};
 
     //When entries added to the listbox then there can be one for the user update and one

desktop/source/deployment/gui/dp_gui_updatedialog.hxx

@@ -115,7 +115,7 @@ private:
         sal_uInt16 getItemCount() const;
 
     private:
-        CheckListBox(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION;
+        explicit CheckListBox(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION;
         void operator =(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION;
 
         virtual void MouseButtonDown(MouseEvent const & event) SAL_OVERRIDE;

desktop/source/deployment/manager/dp_commandenvironments.hxx

@@ -44,7 +44,7 @@ protected:
 public:
     virtual ~BaseCommandEnv();
     BaseCommandEnv();
-    BaseCommandEnv(
+    explicit BaseCommandEnv(
         css::uno::Reference< css::task::XInteractionHandler> const & handler);
 
     // XCommandEnvironment
@@ -70,7 +70,7 @@ class TmpRepositoryCommandEnv : public BaseCommandEnv
 {
 public:
     TmpRepositoryCommandEnv();
-    TmpRepositoryCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
+    explicit TmpRepositoryCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
 
 // XInteractionHandler
     virtual void SAL_CALL handle(
@@ -111,7 +111,7 @@ class NoLicenseCommandEnv : public BaseCommandEnv
 
 public:
     NoLicenseCommandEnv(){};
-    NoLicenseCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
+    explicit NoLicenseCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
 
 // XInteractionHandler
     virtual void SAL_CALL handle(

desktop/source/deployment/manager/dp_extensionmanager.hxx

@@ -44,7 +44,7 @@ class ExtensionManager : private ::dp_misc::MutexHolder,
         public ::cppu::WeakComponentImplHelper1< css::deployment::XExtensionManager >
 {
 public:
-    ExtensionManager( css::uno::Reference< css::uno::XComponentContext >const& xContext);
+    explicit ExtensionManager( css::uno::Reference< css::uno::XComponentContext >const& xContext);
     virtual     ~ExtensionManager();
 
     static css::uno::Sequence< OUString > getServiceNames();

desktop/source/deployment/manager/dp_informationprovider.cxx

@@ -63,7 +63,7 @@ class PackageInformationProvider :
 
 {
     public:
-                 PackageInformationProvider( uno::Reference< uno::XComponentContext >const& xContext);
+    explicit PackageInformationProvider( uno::Reference< uno::XComponentContext >const& xContext);
     virtual     ~PackageInformationProvider();
 
     // XPackageInformationProvider

desktop/source/deployment/manager/dp_manager.cxx

@@ -77,7 +77,7 @@ namespace dp_manager {
 struct MatchTempDir
 {
     OUString m_str;
-    MatchTempDir( OUString const & str ) : m_str( str ) {}
+    explicit MatchTempDir( OUString const & str ) : m_str( str ) {}
     bool operator () ( ActivePackages::Entries::value_type const & v ) const {
         return v.second.temporaryName.equalsIgnoreAsciiCase( m_str );
     }

desktop/source/deployment/manager/dp_managerfac.cxx

@@ -56,7 +56,7 @@ protected:
 
 public:
     virtual ~PackageManagerFactoryImpl();
-    PackageManagerFactoryImpl(
+    explicit PackageManagerFactoryImpl(
         Reference<XComponentContext> const & xComponentContext );
 
     // XPackageManagerFactory

desktop/source/deployment/misc/dp_descriptioninfoset.cxx

@@ -148,7 +148,7 @@ class FileDoesNotExistFilter
 
 public:
     virtual ~FileDoesNotExistFilter();
-    FileDoesNotExistFilter(
+    explicit FileDoesNotExistFilter(
         const css::uno::Reference< css::ucb::XCommandEnvironment >& xCmdEnv);
 
     bool exist() { return m_bExist;}

desktop/source/lib/init.cxx

@@ -237,7 +237,7 @@ struct LibLODocument_Impl : public _LibreOfficeKitDocument
     uno::Reference<css::lang::XComponent> mxComponent;
     shared_ptr< LibreOfficeKitDocumentClass > m_pDocumentClass;
 
-    LibLODocument_Impl(const uno::Reference <css::lang::XComponent> &xComponent) :
+    explicit LibLODocument_Impl(const uno::Reference <css::lang::XComponent> &xComponent) :
         mxComponent( xComponent )
     {
         if (!(m_pDocumentClass = gDocumentClass.lock()))

desktop/source/migration/services/oo3extensionmigration.hxx

@@ -87,7 +87,7 @@ namespace migration
         void                    migrateExtension( const OUString& sSourceDir );
 
     public:
-        OO3ExtensionMigration(::com::sun::star::uno::Reference<
+        explicit OO3ExtensionMigration(::com::sun::star::uno::Reference<
             ::com::sun::star::uno::XComponentContext > const & ctx);
         virtual ~OO3ExtensionMigration();
 

desktop/source/offacc/acceptor.hxx

@@ -71,7 +71,7 @@ private:
     bool m_bDying;
 
 public:
-    Acceptor( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
+    explicit Acceptor( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
     virtual ~Acceptor();
 
     void run();

desktop/source/pkgchk/unopkg/unopkg_app.cxx

@@ -54,7 +54,7 @@ namespace {
 struct ExtensionName
 {
     OUString m_str;
-    ExtensionName( OUString const & str ) : m_str( str ) {}
+    explicit ExtensionName( OUString const & str ) : m_str( str ) {}
     bool operator () ( Reference<deployment::XPackage> const & e ) const
     {
         if (m_str.equals(dp_misc::getIdentifier(e))
@@ -125,7 +125,7 @@ class DialogClosedListenerImpl :
     osl::Condition & m_rDialogClosedCondition;
 
 public:
-    DialogClosedListenerImpl( osl::Condition & rDialogClosedCondition )
+    explicit DialogClosedListenerImpl( osl::Condition & rDialogClosedCondition )
         : m_rDialogClosedCondition( rDialogClosedCondition ) {}
 
     // XEventListener (base of XDialogClosedListener)

desktop/source/pkgchk/unopkg/unopkg_shared.h

@@ -49,7 +49,7 @@ struct OptionInfo
 
 struct LockFileException : public css::uno::Exception
 {
-    LockFileException(OUString const & sMessage) :
+    explicit LockFileException(OUString const & sMessage) :
         css::uno::Exception(sMessage, css::uno::Reference< css::uno::XInterface > ()) {}
 };
 

desktop/source/splash/splash.cxx

@@ -54,7 +54,7 @@ class SplashScreenWindow : public IntroWindow
 public:
     SplashScreen *pSpl;
     ScopedVclPtr<VirtualDevice> _vdev;
-            SplashScreenWindow(SplashScreen *);
+    explicit SplashScreenWindow(SplashScreen *);
     virtual ~SplashScreenWindow() { disposeOnce(); }
     virtual void dispose() SAL_OVERRIDE;
     // workwindow

desktop/source/splash/unxsplash.hxx

@@ -48,7 +48,7 @@ private:
     FILE *m_pOutFd;
 
 public:
-    UnxSplashScreen( const css::uno::Reference< css::uno::XComponentContext >& xCtx );
+    explicit UnxSplashScreen( const css::uno::Reference< css::uno::XComponentContext >& xCtx );
 
     // XStatusIndicator
     virtual void SAL_CALL start( const OUString& aText, sal_Int32 nRange ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE;

desktop/test/deployment/active/active_native.cxx

@@ -74,7 +74,7 @@ public:
     static_getSupportedServiceNames();
 
 private:
-    Provider(
+    explicit Provider(
         css::uno::Reference< css::uno::XComponentContext > const & context):
         context_(context) { assert(context.is()); }
 
@@ -166,7 +166,7 @@ public:
     { return css::uno::Sequence< rtl::OUString >(); }
 
 private:
-    Dispatch(
+    explicit Dispatch(
         css::uno::Reference< css::uno::XComponentContext > const & context):
         context_(context) { assert(context.is()); }
 

desktop/test/deployment/passive/passive_native.cxx

@@ -71,7 +71,7 @@ public:
     static_getSupportedServiceNames();
 
 private:
-    Provider(
+    explicit Provider(
         css::uno::Reference< css::uno::XComponentContext > const & context):
         context_(context) { assert(context.is()); }
 
@@ -163,7 +163,7 @@ public:
     { return css::uno::Sequence< rtl::OUString >(); }
 
 private:
-    Dispatch(
+    explicit Dispatch(
         css::uno::Reference< css::uno::XComponentContext > const & context):
         context_(context) { assert(context.is()); }