clang-analyzer-deadcode.DeadStores

The if block had been disabled ever since
c7c85ab7 "INTEGRATION: CWS pbfinal01," but that
has probably become irrelevant at least since
b80e865d "Convert find & replace dialog to .ui"
introduced SvxSearchDialog::ShowOptionalControls_Impl (called a few lines above
the original if block), which (using a slightly different logic to determine
bDrawApp) shows/hides m_pRegExpBtn and m_pLayoutBtn anyway.

Change-Id: Iaf2c1d8ef1b4e3155d7c4109f15be86d738ba074

svx/source/dialog/srchdlg.cxx

@@ -804,7 +804,6 @@ void SvxSearchDialog::Init_Impl( bool bSearchPattern )
 
     ShowOptionalControls_Impl();
 
-    bool bDraw = false;
     if ( pSearchItem->GetAppFlag() == SvxSearchApp::CALC )
     {
         m_pCalcGrid->Show();
@@ -864,7 +863,6 @@ void SvxSearchDialog::Init_Impl( bool bSearchPattern )
             m_pFormatBtn->Hide();
             m_pNoFormatBtn->Hide();
             m_pAttributeBtn->Hide();
-            bDraw = true;
         }
         else
         {
@@ -887,12 +885,6 @@ void SvxSearchDialog::Init_Impl( bool bSearchPattern )
         }
     }
 
-    if ( false && !bDraw ) //!!!!!
-    {
-        m_pRegExpBtn->Show();
-        m_pLayoutBtn->Show();
-    }
-
     // similarity search?
     if ( ( nModifyFlag & MODIFY_SIMILARITY ) == 0 )
         m_pSimilarityBox->Check( pSearchItem->IsLevenshtein() );