Kaydet (Commit) c421ac3f authored tarafından Stephan Bergmann's avatar Stephan Bergmann

Revert loplugin:unnecessaryparen warning around integer literals

...as those may be used to silence Clang -Werror,-Wunreachable-code (as happens
in sal/osl/unx/file_volume.cxx for Android, where OSL_detail_STATFS(...) always
expands to (1)).

Change-Id: I85d280c1315b4447362255d17f13f437d3c4af92
üst d6609c8b
......@@ -149,9 +149,9 @@ bool UnnecessaryParen::VisitParenExpr(const ParenExpr* parenExpr)
<< parenExpr->getSourceRange();
handled_.insert(parenExpr);
}
} else if (isa<IntegerLiteral>(subExpr) || isa<CharacterLiteral>(subExpr)
|| isa<FloatingLiteral>(subExpr) || isa<ImaginaryLiteral>(subExpr)
|| isa<CXXNullPtrLiteralExpr>(subExpr))
} else if (isa<CharacterLiteral>(subExpr) || isa<FloatingLiteral>(subExpr)
|| isa<ImaginaryLiteral>(subExpr) || isa<CXXNullPtrLiteralExpr>(subExpr))
//TODO: isa<IntegerLiteral>(subExpr)
//TODO: isa<CXXBoolLiteralExpr>(subExpr) || isa<ObjCBoolLiteralExpr>(subExpr)
{
auto const loc = subExpr->getLocStart();
......
......@@ -216,7 +216,7 @@ static oslFileError osl_psz_getVolumeInformation (
{
OSL_detail_STATFS_STRUCT sfs;
OSL_detail_STATFS_INIT(sfs);
if ((OSL_detail_STATFS(pszDirectory, &sfs)) < 0)
if ((OSL_detail_STATFS(pszDirectory, &sfs)) < (0))
{
oslFileError result = oslTranslateFileError(errno);
return result;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment