tdf#112689 - Replace chained O(U)StringBuffer::append() with operator+

Change-Id: If0ed3929f8faab187327b90e63014720e287e501
Reviewed-on: https://gerrit.libreoffice.org/43681Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

sc/source/ui/dbgui/foptmgr.cxx

@@ -96,7 +96,7 @@ void ScFilterOptionsMgr::Init()
                                                 rQueryData.nRow2,
                                                 pViewData->GetTabNo() ) );
         ScDBCollection* pDBColl     = pDoc->GetDBCollection();
-        OUStringBuffer theDbArea;
+        OUString theDbArea;
         OUString   theDbName(STR_DB_LOCAL_NONAME);
         const formula::FormulaGrammar::AddressConvention eConv = pDoc->GetAddressConvention();
 
@@ -149,9 +149,9 @@ void ScFilterOptionsMgr::Init()
 
         if ( theDbName != STR_DB_LOCAL_NONAME )
         {
-            theDbArea.append(" (");
-            theDbArea.append(theDbName).append(')');
-            pFtDbArea->SetText( theDbArea.makeStringAndClear() );
+            theDbArea += " (" + theDbName + ")";
+
+            pFtDbArea->SetText( theDbArea );
         }
         else
         {

vcl/source/uitest/uiobject.cxx

@@ -246,22 +246,20 @@ std::vector<KeyEvent> generate_key_events_from_keycode(const OUString& rStr)
 
 OUString to_string(const Point& rPos)
 {
-    OUStringBuffer aBuffer;
-    aBuffer.append(OUString::number(rPos.X()));
-    aBuffer.append("x");
-    aBuffer.append(OUString::number(rPos.Y()));
+    OUString sStr = OUString::number(rPos.X())
+                  + "x"
+                  + OUString::number(rPos.Y());
 
-    return aBuffer.makeStringAndClear();
+    return sStr;
 }
 
 OUString to_string(const Size& rSize)
 {
-    OUStringBuffer aBuffer;
-    aBuffer.append(rSize.Width());
-    aBuffer.append("x");
-    aBuffer.append(rSize.Height());
+    OUString sStr = OUString::number(rSize.Width())
+                  + "x"
+                  + OUString::number(rSize.Height());
 
-    return aBuffer.makeStringAndClear();
+    return sStr;
 }
 
 }