Kaydet (Commit) cc21f1ab authored tarafından Caolán McNamara's avatar Caolán McNamara

dubious SysAllocString check

Change-Id: I1aece8321b12351b5e8a2d5c33e513531cbc95a1
Reviewed-on: https://gerrit.libreoffice.org/62007
Tested-by: Jenkins
Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
üst 9f8f804f
...@@ -132,9 +132,9 @@ STDMETHODIMP CAccTable::get_columnDescription(long column, BSTR * description) ...@@ -132,9 +132,9 @@ STDMETHODIMP CAccTable::get_columnDescription(long column, BSTR * description)
const ::rtl::OUString& ouStr = GetXInterface()->getAccessibleColumnDescription(column); const ::rtl::OUString& ouStr = GetXInterface()->getAccessibleColumnDescription(column);
// #CHECK# // #CHECK#
SAFE_SYSFREESTRING(*description);//?? SAFE_SYSFREESTRING(*description);
*description = SysAllocString(o3tl::toW(ouStr.getStr())); *description = SysAllocString(o3tl::toW(ouStr.getStr()));
if(description==nullptr) if (*description==nullptr)
return E_FAIL; return E_FAIL;
return S_OK; return S_OK;
...@@ -353,9 +353,8 @@ STDMETHODIMP CAccTable::get_rowDescription(long row, BSTR * description) ...@@ -353,9 +353,8 @@ STDMETHODIMP CAccTable::get_rowDescription(long row, BSTR * description)
SAFE_SYSFREESTRING(*description); SAFE_SYSFREESTRING(*description);
*description = SysAllocString(o3tl::toW(ouStr.getStr())); *description = SysAllocString(o3tl::toW(ouStr.getStr()));
if(description==nullptr) if (*description==nullptr)
return E_FAIL; return E_FAIL;
return S_OK; return S_OK;
LEAVE_PROTECTED_BLOCK LEAVE_PROTECTED_BLOCK
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment