Kaydet (Commit) ce346973 authored tarafından Kohei Yoshida's avatar Kohei Yoshida Kaydeden (comit) Jan Holesovsky

Remove bogus check for numerical sheet names. (fdo#32570)

We apparently put numerical sheet name into quotes somewhere else,
so checking for a number followed by a '.' and flagging it as bad
is not only necessary, it's not appropriate.  E.g. we do support
other formula syntax where the sheet-to-reference separator is not
'.' (Excel A1 and Excel R1C1), thereby making this test even more
inappropriate.
Signed-off-by: 's avatarJan Holesovsky <kendy@suse.cz>
üst 6eec5efb
......@@ -2663,8 +2663,7 @@ BOOL ScCompiler::IsValue( const String& rSym )
double fVal;
sal_uInt32 nIndex = ( mxSymbols->isEnglish() ?
pDoc->GetFormatTable()->GetStandardIndex( LANGUAGE_ENGLISH_US ) : 0 );
// ULONG nIndex = 0;
//// ULONG nIndex = pDoc->GetFormatTable()->GetStandardIndex(ScGlobal::eLnge);
if (pDoc->GetFormatTable()->IsNumberFormat( rSym, nIndex, fVal ) )
{
USHORT nType = pDoc->GetFormatTable()->GetType(nIndex);
......@@ -2686,10 +2685,6 @@ BOOL ScCompiler::IsValue( const String& rSym )
return FALSE; // Boolean function instead.
}
if( aFormula.GetChar(nSrcPos) == '.' )
// numerical sheet name?
return FALSE;
if( nType == NUMBERFORMAT_TEXT )
// HACK: number too big!
SetError( errIllegalArgument );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment