convert SvxChartStyle to scoped enum

Change-Id: I007dc799777524ccfabbb1ce52b9495437ff9156

chart2/source/view/main/ChartItemPool.cxx

@@ -137,7 +137,7 @@ ChartItemPool::ChartItemPool():
     ppPoolDefaults[SCHATTR_NUM_OF_LINES_FOR_BAR - SCHATTR_START] = new SfxInt32Item( SCHATTR_NUM_OF_LINES_FOR_BAR, 0 );
     ppPoolDefaults[SCHATTR_SPLINE_ORDER         - SCHATTR_START] = new SfxInt32Item( SCHATTR_SPLINE_ORDER, 3 );
     ppPoolDefaults[SCHATTR_SPLINE_RESOLUTION    - SCHATTR_START] = new SfxInt32Item( SCHATTR_SPLINE_RESOLUTION, 20 );
-    ppPoolDefaults[SCHATTR_DIAGRAM_STYLE        - SCHATTR_START] = new SvxChartStyleItem( CHSTYLE_2D_COLUMN, SCHATTR_DIAGRAM_STYLE );
+    ppPoolDefaults[SCHATTR_DIAGRAM_STYLE        - SCHATTR_START] = new SvxChartStyleItem( SvxChartStyle::Column2D, SCHATTR_DIAGRAM_STYLE );
     ppPoolDefaults[SCHATTR_GROUP_BARS_PER_AXIS  - SCHATTR_START] = new SfxBoolItem(SCHATTR_GROUP_BARS_PER_AXIS, false);
     ppPoolDefaults[SCHATTR_STARTING_ANGLE       - SCHATTR_START] = new SfxInt32Item( SCHATTR_STARTING_ANGLE, 90 );
     ppPoolDefaults[SCHATTR_CLOCKWISE            - SCHATTR_START] = new SfxBoolItem( SCHATTR_CLOCKWISE, false );

include/svx/chrtitem.hxx

@@ -22,14 +22,14 @@
 #include <svl/eitem.hxx>
 #include <svx/svxdllapi.h>
 
-enum SvxChartStyle
+enum class SvxChartStyle
 {
-    CHSTYLE_2D_LINE,
-    CHSTYLE_2D_COLUMN,
-    CHSTYLE_ADDIN
+    Line2D,
+    Column2D,
+    AddIn
 };
 
-#define CHSTYLE_COUNT   (CHSTYLE_ADDIN + 1)
+#define CHSTYLE_COUNT   ((sal_uInt16)SvxChartStyle::AddIn + 1)
 
 enum class SvxChartTextOrder
 {
@@ -83,7 +83,7 @@ enum class SvxChartRegress
 class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxChartStyleItem : public SfxEnumItem
 {
 public:
-    SvxChartStyleItem(SvxChartStyle eStyle /*= CHSTYLE_2D_LINE*/,
+    SvxChartStyleItem(SvxChartStyle eStyle /*= SvxChartStyle::Line2D*/,
                       sal_uInt16 nId );
     SvxChartStyleItem(SvStream& rIn, sal_uInt16 nId );