Use initializer properly and remove Init().

Change-Id: Ic343ff4ddd51a933ba97971d5a1197f5a25ef772

include/svx/svdoole2.hxx

@@ -59,6 +59,8 @@ protected:
     virtual sdr::properties::BaseProperties* CreateObjectSpecificProperties() SAL_OVERRIDE;
 
 private:
+    SdrOle2ObjImpl*             mpImpl;
+
     svt::EmbeddedObjectRef      xObjRef;
     Graphic*                    pGraphic;
     OUString                    aProgName;
@@ -71,21 +73,18 @@ private:
     mutable bool                m_bTypeAsked:1;
     mutable bool                m_bChart:1;
 
-    SdrOle2ObjImpl*             mpImpl;
-
     SvxUnoShapeModifyListener*  pModifyListener;
 
 private:
 
     void ImpSetVisAreaSize();
-    void Init();
 
 public:
     OUString GetStyleString();
     TYPEINFO_OVERRIDE();
 
-    SdrOle2Obj(bool bFrame_ = false);
-    SdrOle2Obj(const svt::EmbeddedObjectRef& rNewObjRef, const OUString& rNewObjName, const Rectangle& rNewRect, bool bFrame_ = false);
+    SdrOle2Obj( bool bFrame_ = false );
+    SdrOle2Obj( const svt::EmbeddedObjectRef& rNewObjRef, const OUString& rNewObjName, const Rectangle& rNewRect, bool bFrame_ = false );
     virtual ~SdrOle2Obj();
 
     // access to svt::EmbeddedObjectRef

svx/source/svdraw/svdoole2.cxx

@@ -734,29 +734,35 @@ sdr::contact::ViewContact* SdrOle2Obj::CreateObjectSpecificViewContact()
 
 
 TYPEINIT1(SdrOle2Obj,SdrRectObj);
-SdrOle2Obj::SdrOle2Obj(bool bFrame_) : m_bTypeAsked(false)
-,m_bChart(false)
-{
-    bInDestruction = false;
-    mbSuppressSetVisAreaSize = false;
-    Init();
-    bFrame=bFrame_;
-}
 
-
-
-SdrOle2Obj::SdrOle2Obj( const svt::EmbeddedObjectRef&  rNewObjRef, const OUString& rNewObjName, const Rectangle& rNewRect, bool bFrame_)
-    : SdrRectObj(rNewRect)
-    , xObjRef( rNewObjRef )
-    , m_bTypeAsked(false)
-    , m_bChart(false)
-{
-    bInDestruction = false;
-    mbSuppressSetVisAreaSize = false;
-    Init();
+SdrOle2Obj::SdrOle2Obj( bool bFrame_ ) :
+    mpImpl(new SdrOle2ObjImpl),
+    pGraphic(NULL),
+    bFrame(bFrame_),
+    bInDestruction(false),
+    mbSuppressSetVisAreaSize(false),
+    m_bTypeAsked(false),
+    m_bChart(false),
+    pModifyListener(NULL)
+{
+    xObjRef.Lock(true);
+}
+
+SdrOle2Obj::SdrOle2Obj( const svt::EmbeddedObjectRef&  rNewObjRef, const OUString& rNewObjName, const Rectangle& rNewRect, bool bFrame_ ) :
+    SdrRectObj(rNewRect),
+    mpImpl(new SdrOle2ObjImpl),
+    xObjRef(rNewObjRef),
+    pGraphic(NULL),
+    bFrame(bFrame_),
+    bInDestruction(false),
+    mbSuppressSetVisAreaSize(false),
+    m_bTypeAsked(false),
+    m_bChart(false),
+    pModifyListener(NULL)
+{
+    xObjRef.Lock(true);
 
     mpImpl->aPersistName = rNewObjName;
-    bFrame=bFrame_;
 
     if ( xObjRef.is() && (xObjRef->getStatus( GetAspect() ) & embed::EmbedMisc::EMBED_NEVERRESIZE ) )
         SetResizeProtect(true);
@@ -765,21 +771,6 @@ SdrOle2Obj::SdrOle2Obj( const svt::EmbeddedObjectRef&  rNewObjRef, const OUStrin
     SetClosedObj(!ImplIsMathObj( xObjRef.GetObject() ));
 }
 
-
-
-void SdrOle2Obj::Init()
-{
-    mpImpl = new SdrOle2ObjImpl;
-    pModifyListener = NULL;
-    pGraphic=NULL;
-    mpImpl->pGraphicObject=NULL;
-    mpImpl->pLightClient = 0;
-
-    xObjRef.Lock( true );
-}
-
-
-
 OUString SdrOle2Obj::GetStyleString()
 {
     OUString strStyle;