Kaydet (Commit) cf1c3b5c authored tarafından Miklos Vajna's avatar Miklos Vajna

writerfilter: call to SAL_WARN() is not expensive

So guards like '#if OSL_DEBUG_LEVEL > 0' around it can be dropped in
most cases. Also, dumping the hex value of token IDs no longer makes
sense, now that doctok is gone.

Change-Id: I2c0d466e4bdde63d271a83aa4e7eebb52294e363
üst 0aa5a03a
...@@ -31,9 +31,7 @@ ...@@ -31,9 +31,7 @@
#include "util.hxx" #include "util.hxx"
#include "TagLogger.hxx" #include "TagLogger.hxx"
#if OSL_DEBUG_LEVEL > 0 #include <rtl/strbuf.hxx>
# include <rtl/strbuf.hxx>
#endif
namespace writerfilter namespace writerfilter
{ {
...@@ -1047,10 +1045,7 @@ void TableManager<T, PropertiesPointer>::resolveCurrentTable() ...@@ -1047,10 +1045,7 @@ void TableManager<T, PropertiesPointer>::resolveCurrentTable()
} }
catch (css::uno::Exception const& e) catch (css::uno::Exception const& e)
{ {
(void) e;
#if OSL_DEBUG_LEVEL > 0
SAL_WARN("writerfilter", "resolving of current table failed with: " << e.Message); SAL_WARN("writerfilter", "resolving of current table failed with: " << e.Message);
#endif
} }
} }
resetTableProps(); resetTableProps();
......
...@@ -1022,19 +1022,7 @@ void DomainMapper::lcl_attribute(Id nName, Value & val) ...@@ -1022,19 +1022,7 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
m_pImpl->appendGrabBag(m_pImpl->m_aInteropGrabBag, "val", sStringValue); m_pImpl->appendGrabBag(m_pImpl->m_aInteropGrabBag, "val", sStringValue);
break; break;
default: default:
{ SAL_WARN("writerfilter", "DomainMapper::lcl_attribute: unhandled token: " << nName);
#if OSL_DEBUG_LEVEL > 0
OString sMessage("DomainMapper::attribute() - Id: ");
sMessage += OString::number( nName, 10 );
sMessage += " / 0x";
sMessage += OString::number( nName, 16 );
sMessage += " value: ";
sMessage += OString::number( nIntValue, 10 );
sMessage += " / 0x";
sMessage += OString::number( nIntValue, 16 );
SAL_WARN("writerfilter", sMessage.getStr());
#endif
}
} }
} }
......
...@@ -1122,13 +1122,7 @@ void GraphicImport::lcl_sprm(Sprm& rSprm) ...@@ -1122,13 +1122,7 @@ void GraphicImport::lcl_sprm(Sprm& rSprm)
} }
break; break;
default: default:
#if OSL_DEBUG_LEVEL > 0 SAL_WARN("writerfilter", "GraphicImport::lcl_sprm: unhandled token: " << nSprmId);
OString sMessage( "GraphicImport::sprm() - Id: ");
sMessage += OString::number( nSprmId, 10 );
sMessage += " / 0x";
sMessage += OString::number( nSprmId, 16 );
SAL_WARN("writerfilter", sMessage.getStr());
#endif
break; break;
} }
} }
......
...@@ -809,19 +809,7 @@ void ListsManager::lcl_attribute( Id nName, Value& rVal ) ...@@ -809,19 +809,7 @@ void ListsManager::lcl_attribute( Id nName, Value& rVal )
m_pCurrentNumPicBullet->SetId(rVal.getString().toInt32()); m_pCurrentNumPicBullet->SetId(rVal.getString().toInt32());
break; break;
default: default:
{ SAL_WARN("writerfilter", "ListsManager::lcl_attribute: unhandled token: " << nName);
#if OSL_DEBUG_LEVEL > 0
OString sMessage( "ListTable::attribute() - Id: ");
sMessage += OString::number( nName, 10 );
sMessage += " / 0x";
sMessage += OString::number( nName, 16 );
sMessage += " value: ";
sMessage += OString::number( nIntValue, 10 );
sMessage += " / 0x";
sMessage += OString::number( nIntValue, 16 );
SAL_WARN("writerfilter", sMessage.getStr());
#endif
}
} }
} }
......
...@@ -1174,19 +1174,15 @@ void StyleSheetTable::ApplyStyleSheets( FontTablePtr rFontTable ) ...@@ -1174,19 +1174,15 @@ void StyleSheetTable::ApplyStyleSheets( FontTablePtr rFontTable )
catch( const lang::WrappedTargetException& rWrapped) catch( const lang::WrappedTargetException& rWrapped)
{ {
(void) rWrapped; (void) rWrapped;
OString aMessage("Some style properties could not be set"); #ifdef DEBUG_DOMAINMAPPER
#if OSL_DEBUG_LEVEL > 0 OUString aMessage("StyleSheetTable::ApplyStyleSheets: Some style properties could not be set");
beans::UnknownPropertyException aUnknownPropertyException; beans::UnknownPropertyException aUnknownPropertyException;
if( rWrapped.TargetException >>= aUnknownPropertyException ) if (rWrapped.TargetException >>= aUnknownPropertyException)
{ aMessage += ": " + aUnknownPropertyException.Message;
aMessage += ": ";
OString sTemp; SAL_WARN("writerfilter", aMessage);
aUnknownPropertyException.Message.convertToString(&sTemp, RTL_TEXTENCODING_ASCII_US, 0 );
aMessage += sTemp;
}
#endif #endif
SAL_WARN("writerfilter", aMessage.getStr());
} }
catch( const uno::Exception& ) catch( const uno::Exception& )
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment