SwRefPageGetFieldType::MakeSetList can return bool

Change-Id: I79965d94e077345357952e7bded4b7e5b4c51c85

sw/inc/docufld.hxx

@@ -605,7 +605,7 @@ protected:
 public:
     SwRefPageGetFieldType( SwDoc* pDoc );
     virtual SwFieldType*    Copy() const SAL_OVERRIDE;
-    sal_uInt16 MakeSetList( _SetGetExpFlds& rTmpLst );
+    bool MakeSetList( _SetGetExpFlds& rTmpLst );
     SwDoc*  GetDoc() const                  { return pDoc; }
 };
 

sw/source/core/fields/cellfml.cxx

@@ -701,7 +701,7 @@ const SwTable* SwTableFormula::FindTable( SwDoc& rDoc, const OUString& rNm ) con
 {
     const SwFrmFmts& rTblFmts = *rDoc.GetTblFrmFmts();
     const SwTable* pTmpTbl = 0, *pRet = 0;
-    for( sal_uInt16 nFmtCnt = rTblFmts.size(); nFmtCnt; )
+    for( auto nFmtCnt = rTblFmts.size(); nFmtCnt; )
     {
         SwFrmFmt* pFmt = rTblFmts[ --nFmtCnt ];
         // if we are called from Sw3Writer, a number is dependent on the format name

sw/source/core/fields/docufld.cxx

@@ -2075,7 +2075,7 @@ void SwRefPageGetFieldType::Modify( const SfxPoolItem* pOld, const SfxPoolItem*
     NotifyClients( pOld, pNew );
 }
 
-sal_uInt16 SwRefPageGetFieldType::MakeSetList( _SetGetExpFlds& rTmpLst )
+bool SwRefPageGetFieldType::MakeSetList( _SetGetExpFlds& rTmpLst )
 {
     SwIterator<SwFmtFld,SwFieldType> aIter(*pDoc->getIDocumentFieldsAccess().GetSysFldType( RES_REFPAGESETFLD));
     for ( SwFmtFld* pFmtFld = aIter.First(); pFmtFld; pFmtFld = aIter.Next() )
@@ -2118,7 +2118,7 @@ sal_uInt16 SwRefPageGetFieldType::MakeSetList( _SetGetExpFlds& rTmpLst )
             }
     }
 
-    return rTmpLst.size();
+    return !rTmpLst.empty();
 }
 
 void SwRefPageGetFieldType::UpdateField( SwTxtFld* pTxtFld,