Simplify and fix the embedded Firebird on Linux

Change-Id: Ibd29bb964cd090cbfd958a9e54658249e8ce4317

firebird/ExternalPackage_firebird.mk

@@ -17,9 +17,8 @@ $(eval $(call gb_ExternalPackage_add_file,firebird,lib/ifbembed.lib,gen/firebird
 else ifeq ($(OS),MACOSX)
 $(eval $(call gb_ExternalPackage_add_file,firebird,lib/libfbembed.dylib,gen/firebird/lib/libfbembed.dylib.2.5.2))
 else
-$(eval $(call gb_ExternalPackage_add_file,firebird,lib/libfbembed.so.2.5.2,gen/firebird/lib/libfbembed.so.2.5.2))
-$(eval $(call gb_ExternalPackage_add_file,firebird,lib/libfbembed.so.2.5,gen/firebird/lib/libfbembed.so.2.5))
-$(eval $(call gb_ExternalPackage_add_file,firebird,lib/libfbembed.so,gen/firebird/lib/libfbembed.so))
+$(eval $(call gb_ExternalPackage_add_file,firebird,lib/libfbembed.so.2.5,gen/firebird/lib/libfbembed.so.2.5.2))
+$(eval $(call gb_ExternalPackage_add_file,firebird,lib/libfbembed.so,gen/firebird/lib/libfbembed.so.2.5.2))
 endif
 
 # vim: set noet sw=4 ts=4:

firebird/UnpackedTarball_firebird.mk

@@ -13,6 +13,7 @@ $(eval $(call gb_UnpackedTarball_set_tarball,firebird,$(FIREBIRD_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
 	firebird/firebird-icu.patch.1 \
+	firebird/firebird-rpath.patch.0 \
 ))
 
 $(eval $(call gb_UnpackedTarball_add_patches,firebird,\

firebird/firebird-rpath.patch.0

+--- builds/posix/make.defaults
++++ builds/posix/make.defaults
+@@ -255,7 +255,7 @@
+ 
+ LIB_PLATFORM_RPATH = -Wl,-rpath,$(1)
+ ifeq ($(strip @BINRELOC_CFLAGS@),)
+-LIB_LINK_RPATH = $(call LIB_PLATFORM_RPATH,$(if $(subst intl,,$(1)),@FB_LIBDIR@,@FB_INTLDIR@))
++LIB_LINK_RPATH = $(call LIB_PLATFORM_RPATH,'$$ORIGIN')
+ else
+ LIB_LINK_RPATH = $(call LIB_PLATFORM_RPATH,'$$$$ORIGIN/../$(1)')
+ endif

scp2/source/firebird/file_firebird.scp

@@ -20,43 +20,16 @@
 
 #ifndef SYSTEM_FIREBIRD
 
-/*File gid_File_Firebird
-    TXT_FILE_BODY;
-    Dir = gid_Dir_Brand_Root;
-    Name = "firebird.filelist";
-    Styles = (FILELIST,USE_INTERNAL_RIGHTS);
-End*/
-
-#if !defined MACOSX
-
-File gid_File_Firebird_Lib_252
-    LIB_FILE_BODY;
-    Styles = (PACKED);
-    Dir = SCP2_OOO_LIB_DIR;
-  #ifdef UNX
-    Name = STRING(CONCAT4(libfbembed,UNXSUFFIX,.,2.5.2));
-  #endif
-End
-
-File gid_File_Firebird_Lib_25
-    LIB_FILE_BODY;
-    Styles = (PACKED);
-    Dir = SCP2_OOO_LIB_DIR;
-  #ifdef UNX
-    Name = STRING(CONCAT4(libfbembed,UNXSUFFIX,.,2.5));
-  #endif
-End
-
-#endif
-
 File gid_File_Firebird_Lib
     LIB_FILE_BODY;
     Styles = (PACKED);
     Dir = SCP2_OOO_LIB_DIR;
-  #ifdef UNX
-    Name = STRING(CONCAT2(libfbembed,UNXSUFFIX));
+  #if defined MACOSX
+    Name = "libfbembed.dylib";
+  #elif defined UNX
+    Name = STRING(CONCAT3(libfbembed,UNXSUFFIX,.2.5));
   #else
-   Name = "ifbembed.dll";
+    Name = "ifbembed.dll";
   #endif
 End
 

scp2/source/firebird/module_firebird.scp

@@ -23,15 +23,9 @@
 Module gid_Module_Firebird
     PackageInfo = "packinfo_office.txt";
     ParentID = gid_Module_Root_Brand;
-    Dirs = ();
     Files = (
-#if defined UNX && !defined MACOSX
-        File gid_File_Firebird_Lib_252,
-        File gid_File_Firebird_Lib_25,
-#endif
         File gid_File_Firebird_Lib
     );
-    Unixlinks = ();
     Styles = (HIDDEN_ROOT);
 End