loplugin:cstylecast (macOS)

Change-Id: I4468aff1817fdb47256dff94e7f2d8aa7575137e
Reviewed-on: https://gerrit.libreoffice.org/73586
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

fpicker/source/aqua/SalAquaFilePicker.mm

@@ -162,7 +162,8 @@ sal_Int16 SAL_CALL SalAquaFilePicker::execute()
     // So instead of:
     // [m_pDialog setDelegate:m_pDelegate];
     // do:
-    ((id (*)(id, SEL, ...))objc_msgSend)(m_pDialog, @selector(setDelegate:), m_pDelegate);
+    reinterpret_cast<id (*)(id, SEL, ...)>(objc_msgSend)(
+        m_pDialog, @selector(setDelegate:), m_pDelegate);
 
     int nStatus = runandwaitforresult();
 

sfx2/source/appl/sfxhelp.cxx

@@ -1076,10 +1076,10 @@ bool SfxHelp::Start_Impl(const OUString& rURL, const vcl::Window* pWindow, const
         CFURLRef pBrowser = LSCopyDefaultApplicationURLForURL(
                                 CFURLCreateWithString(
                                     kCFAllocatorDefault,
-                                    (CFStringRef)@"https://www.libreoffice.org",
+                                    static_cast<CFStringRef>(@"https://www.libreoffice.org"),
                                     NULL),
                                 kLSRolesAll, NULL);
-        if([(NSString*)CFURLGetString(pBrowser) isEqualToString:@"file:///Applications/Safari.app/"]) {
+        if([static_cast<NSString*>(CFURLGetString(pBrowser)) isEqualToString:@"file:///Applications/Safari.app/"]) {
             impl_showOnlineHelp( aHelpURL );
             return true;
         }

sfx2/source/appl/shutdowniconaqua.mm

@@ -351,7 +351,8 @@ static void appendRecentMenu( NSMenu* i_pMenu, NSMenu* i_pDockMenu, const OUStri
     // confused. Anyway, to avoid warnings, instead of this:
     // [pRecentMenu setDelegate: pRecentDelegate];
     // do this:
-    ((id (*)(id, SEL, ...))objc_msgSend)(pRecentMenu, @selector(setDelegate:), pRecentDelegate);
+    reinterpret_cast<id (*)(id, SEL, ...)>(objc_msgSend)(
+        pRecentMenu, @selector(setDelegate:), pRecentDelegate);
 
     [pRecentMenu setAutoenablesItems: NO];
     [pItem setSubmenu: pRecentMenu];
@@ -368,7 +369,8 @@ static void appendRecentMenu( NSMenu* i_pMenu, NSMenu* i_pDockMenu, const OUStri
 
         // See above
         // [pRecentMenu setDelegate: pRecentDelegate];
-        ((id (*)(id, SEL, ...))objc_msgSend)(pRecentMenu, @selector(setDelegate:), pRecentDelegate);
+        reinterpret_cast<id (*)(id, SEL, ...)>(objc_msgSend)(
+            pRecentMenu, @selector(setDelegate:), pRecentDelegate);
 
         [pRecentMenu setAutoenablesItems: NO];
         [pItem setSubmenu: pRecentMenu];