Kaydet (Commit) d6a6261f authored tarafından Caolán McNamara's avatar Caolán McNamara Kaydeden (comit) Miklos Vajna

afl-eventtesting: crash on undoing insert new page in impress

this is an intermittent crash in the real world but under event testing we can
see that the PaintView is informed that the page has been deleted, but doesn't
clear its use of the page if it so happens that there was earlier modification
events that caused the fire-modification-timer to be launched

If there happens to be no such events then the page is correctly cleared

If the timer is active, then the page is not cleared, but eventually the
timer will fire and access the deleted page and fall over and die

minimal change for backporting ease, follow ups now

(cherry picked from commit f8b97599)

Change-Id: I090ad62cc175545902574c93dec7082225d97ab7
Reviewed-on: https://gerrit.libreoffice.org/19551Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
Tested-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
üst 9f008e2a
...@@ -259,12 +259,12 @@ void SdrPaintView::Notify(SfxBroadcaster& rBC, const SfxHint& rHint) ...@@ -259,12 +259,12 @@ void SdrPaintView::Notify(SfxBroadcaster& rBC, const SfxHint& rHint)
return; return;
} }
bool bObjChg=!bSomeObjChgdFlag; // if true, evaluate for ComeBack timer {
if (bObjChg) {
const SdrHint* pSdrHint = dynamic_cast<const SdrHint*>(&rHint); const SdrHint* pSdrHint = dynamic_cast<const SdrHint*>(&rHint);
if (pSdrHint) { if (pSdrHint) {
SdrHintKind eKind=pSdrHint->GetKind(); SdrHintKind eKind=pSdrHint->GetKind();
if (eKind==HINT_OBJCHG || eKind==HINT_OBJINSERTED || eKind==HINT_OBJREMOVED) { if (eKind==HINT_OBJCHG || eKind==HINT_OBJINSERTED || eKind==HINT_OBJREMOVED) {
bool bObjChg=!bSomeObjChgdFlag; // if true, evaluate for ComeBack timer
if (bObjChg) { if (bObjChg) {
bSomeObjChgdFlag=true; bSomeObjChgdFlag=true;
aComeBackIdle.Start(); aComeBackIdle.Start();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment