Kaydet (Commit) d77d6983 authored tarafından Stephan Bergmann's avatar Stephan Bergmann

-Werror=deprecated-copy (GCC trunk towards GCC 9)

SwVectorModifyBase and its DestructorPolicy look like they beg for clean up, but
it's not immediately clear to me what the best solution would be, so just mark
the dangerous status quo with a TODO comment for now.

Change-Id: I24164553baefb124969d4ac37247dabdaead0cd5
Reviewed-on: https://gerrit.libreoffice.org/58169
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
üst 5d23851b
......@@ -110,6 +110,14 @@ public:
delete *it;
}
//TODO: These functions are apparently brittle (but the copy functions are actually used by the
// code; the move functions will be implicitly-defined as deleted anyway) and should probably
// only be used with DestructorPolicy::KeepELements:
SwVectorModifyBase(SwVectorModifyBase const &) = default;
SwVectorModifyBase(SwVectorModifyBase &&) = default;
SwVectorModifyBase & operator =(SwVectorModifyBase const &) = default;
SwVectorModifyBase & operator =(SwVectorModifyBase &&) = default;
void DeleteAndDestroy(int aStartIdx, int aEndIdx)
{
if (aEndIdx < aStartIdx)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment