Kaydet (Commit) da3ddf32 authored tarafından Caolán McNamara's avatar Caolán McNamara

coverity#1237353 Unchecked dynamic_cast

Change-Id: If25d29eaa788e70972fd0cbbf3d03f4d05862f24
üst a7c378f5
...@@ -1466,29 +1466,25 @@ bool FmFilterNavigator::Select( SvTreeListEntry* pEntry, bool bSelect ) ...@@ -1466,29 +1466,25 @@ bool FmFilterNavigator::Select( SvTreeListEntry* pEntry, bool bSelect )
return false; return false;
} }
void FmFilterNavigator::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint ) void FmFilterNavigator::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint )
{ {
if ( dynamic_cast<const FmFilterInsertedHint*>(&rHint) ) if (const FmFilterInsertedHint* pInsertHint = dynamic_cast<const FmFilterInsertedHint*>(&rHint))
{ {
const FmFilterInsertedHint* pHint = dynamic_cast<const FmFilterInsertedHint*>(&rHint); Insert(pInsertHint->GetData(), pInsertHint->GetPos());
Insert(pHint->GetData(), pHint->GetPos());
} }
else if( dynamic_cast<const FilterClearingHint*>(&rHint) ) else if( dynamic_cast<const FilterClearingHint*>(&rHint) )
{ {
SvTreeListBox::Clear(); SvTreeListBox::Clear();
} }
else if( dynamic_cast<const FmFilterRemovedHint*>(&rHint) ) else if (const FmFilterRemovedHint* pRemoveHint = dynamic_cast<const FmFilterRemovedHint*>(&rHint))
{ {
const FmFilterRemovedHint* pHint = dynamic_cast<const FmFilterRemovedHint*>(&rHint); Remove(pRemoveHint->GetData());
Remove(pHint->GetData());
} }
else if( dynamic_cast<const FmFilterTextChangedHint*>(&rHint) ) else if (const FmFilterTextChangedHint *pChangeHint = dynamic_cast<const FmFilterTextChangedHint*>(&rHint))
{ {
const FmFilterTextChangedHint* pHint = dynamic_cast<const FmFilterTextChangedHint*>(&rHint); SvTreeListEntry* pEntry = FindEntry(pChangeHint->GetData());
SvTreeListEntry* pEntry = FindEntry(pHint->GetData());
if (pEntry) if (pEntry)
SetEntryText( pEntry, pHint->GetData()->GetText()); SetEntryText( pEntry, pChangeHint->GetData()->GetText());
} }
else if( dynamic_cast<const FmFilterCurrentChangedHint*>(&rHint) ) else if( dynamic_cast<const FmFilterCurrentChangedHint*>(&rHint) )
{ {
...@@ -1499,7 +1495,6 @@ void FmFilterNavigator::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint ) ...@@ -1499,7 +1495,6 @@ void FmFilterNavigator::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint )
} }
} }
SvTreeListEntry* FmFilterNavigator::FindEntry(const FmFilterData* pItem) const SvTreeListEntry* FmFilterNavigator::FindEntry(const FmFilterData* pItem) const
{ {
SvTreeListEntry* pEntry = NULL; SvTreeListEntry* pEntry = NULL;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment