loplugin:simplifybool

Change-Id: If72974c49113c64b3ac6269779c5013c554ebdcc

sfx2/source/doc/plugin.cxx

@@ -207,7 +207,7 @@ throw( uno::RuntimeException, std::exception )
         // we must destroy the plugin before the parent is destroyed
         xWindow->addEventListener( this );
         xFrame->setComponent( xWindow, uno::Reference < frame::XController >() );
-        return mxPlugin.is() ? sal_True : sal_False;
+        return mxPlugin.is();
     }
 
     return sal_False;

sfx2/source/doc/sfxbasemodel.cxx

@@ -1317,7 +1317,7 @@ sal_Bool SAL_CALL SfxBaseModel::isModified() throw(RuntimeException, std::except
 {
     SfxModelGuard aGuard( *this );
 
-    return m_pData->m_pObjectShell.Is() ? m_pData->m_pObjectShell->IsModified() : sal_False;
+    return m_pData->m_pObjectShell.Is() && m_pData->m_pObjectShell->IsModified();
 }
 
 
@@ -1480,7 +1480,7 @@ sal_Bool SAL_CALL SfxBaseModel::hasLocation() throw(RuntimeException, std::excep
 {
     SfxModelGuard aGuard( *this );
 
-    return m_pData->m_pObjectShell.Is() ? m_pData->m_pObjectShell->HasName() : sal_False;
+    return m_pData->m_pObjectShell.Is() && m_pData->m_pObjectShell->HasName();
 }
 
 
@@ -1511,7 +1511,7 @@ sal_Bool SAL_CALL SfxBaseModel::isReadonly() throw(RuntimeException, std::except
 {
     SfxModelGuard aGuard( *this );
 
-    return m_pData->m_pObjectShell.Is() ? m_pData->m_pObjectShell->IsReadOnly() : sal_True;
+    return !m_pData->m_pObjectShell.Is() || m_pData->m_pObjectShell->IsReadOnly();
 }
 
 

sfx2/source/view/sfxbasecontroller.cxx

@@ -623,7 +623,7 @@ sal_Bool SAL_CALL SfxBaseController::suspend( sal_Bool bSuspend ) throw( Runtime
     if (bool(bSuspend) == m_pData->m_bSuspendState)
        return sal_True;
 
-    if ( bSuspend == sal_True )
+    if ( bSuspend )
     {
         if ( !m_pData->m_pViewShell )
         {