loplugin:unusedenumconstants look through parentheses

Change-Id: I2afdf5a56d827e283dd2362b87446ad7848cb274
Reviewed-on: https://gerrit.libreoffice.org/64452
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/test/unusedenumconstants.cxx

@@ -113,6 +113,7 @@ void test6()
 {
     Enum6 foo = Enum6::Modules;
     foo &= ~Enum6::Top;
+    foo &= (~Enum6::Top);
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */

compilerplugins/clang/unusedenumconstants.cxx

@@ -179,7 +179,7 @@ walk_up:
             // Ignore a common pattern that does not introduce any new information, merely removes
             // information:     foo &= ~Enum6::Top
             bool found = false;
-            if (auto innerOperatorCall = dyn_cast<CXXOperatorCallExpr>(operatorCall->getArg(1)))
+            if (auto innerOperatorCall = dyn_cast<CXXOperatorCallExpr>(operatorCall->getArg(1)->IgnoreImplicit()->IgnoreParens()->IgnoreImplicit()))
             {
                 found = innerOperatorCall->getOperator() == OO_Tilde;
             }

compilerplugins/clang/unusedenumconstants.readonly.results

@@ -5,7 +5,7 @@ bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx:78
 bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx:79
     enum x86_64_reg_class X86_64_X87UP_CLASS
 chart2/source/inc/CharacterProperties.hxx:121
-    enum chart::CharacterProperties::(anonymous at /media/noel/disk2/libo4/chart2/source/inc/CharacterProperties.hxx:42:5) FAST_PROPERTY_ID_END_CHAR_PROP
+    enum chart::CharacterProperties::(anonymous at /home/noel/libo2/chart2/source/inc/CharacterProperties.hxx:42:5) FAST_PROPERTY_ID_END_CHAR_PROP
 chart2/source/inc/TitleHelper.hxx:48
     enum chart::TitleHelper::eTitleType NORMAL_TITLE_END
 chart2/source/view/inc/ShapeFactory.hxx:50
@@ -39,15 +39,15 @@ chart2/source/view/inc/ShapeFactory.hxx:63
 chart2/source/view/inc/ShapeFactory.hxx:64
     enum chart::SymbolEnum Symbol_VerticalBar
 configmgr/source/access.hxx:455
-    enum configmgr::Access::(anonymous at /media/noel/disk2/libo4/configmgr/source/access.hxx:453:5) IS_SET_MEMBER
+    enum configmgr::Access::(anonymous at /home/noel/libo2/configmgr/source/access.hxx:453:5) IS_GROUP_MEMBER
 configmgr/source/access.hxx:455
-    enum configmgr::Access::(anonymous at /media/noel/disk2/libo4/configmgr/source/access.hxx:453:5) IS_GROUP_MEMBER
+    enum configmgr::Access::(anonymous at /home/noel/libo2/configmgr/source/access.hxx:453:5) IS_SET_MEMBER
 configmgr/source/parsemanager.hxx:47
-    enum configmgr::ParseManager::(anonymous at /media/noel/disk2/libo4/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_OOR
+    enum configmgr::ParseManager::(anonymous at /home/noel/libo2/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_XS
 configmgr/source/parsemanager.hxx:47
-    enum configmgr::ParseManager::(anonymous at /media/noel/disk2/libo4/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_XSI
+    enum configmgr::ParseManager::(anonymous at /home/noel/libo2/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_OOR
 configmgr/source/parsemanager.hxx:47
-    enum configmgr::ParseManager::(anonymous at /media/noel/disk2/libo4/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_XS
+    enum configmgr::ParseManager::(anonymous at /home/noel/libo2/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_XSI
 connectivity/source/drivers/evoab2/NConnection.hxx:41
     connectivity::evoab::SDBCAddress::sdbc_address_type Unknown
 cppcanvas/source/mtfrenderer/emfppen.cxx:53
@@ -432,11 +432,7 @@ include/vcl/graphictools.hxx:227
     enum SvtGraphicFill::FillType fillSolid
 include/vcl/headbar.hxx:185
     enum HeaderBarItemBits RIGHT
-include/vcl/headbar.hxx:186
-    enum HeaderBarItemBits TOP
-include/vcl/headbar.hxx:188
-    enum HeaderBarItemBits BOTTOM
-include/vcl/headbar.hxx:190
+include/vcl/headbar.hxx:187
     enum HeaderBarItemBits RIGHTIMAGE
 include/vcl/help.hxx:41
     enum QuickHelpFlags NoAutoPos
@@ -448,11 +444,11 @@ include/vcl/keycodes.hxx:173
     enum ModKeyFlags Mod1Msk
 include/vcl/keycodes.hxx:174
     enum ModKeyFlags Mod2Msk
-include/vcl/menu.hxx:75
+include/vcl/menu.hxx:74
     enum PopupMenuFlags ExecuteUp
-include/vcl/menu.hxx:76
+include/vcl/menu.hxx:75
     enum PopupMenuFlags ExecuteLeft
-include/vcl/menu.hxx:84
+include/vcl/menu.hxx:83
     enum PopupMenuFlags NoHorzPlacement
 include/vcl/outdev.hxx:173
     enum DrawTextFlags NewsEllipsis
@@ -512,10 +508,10 @@ include/vcl/pdfwriter.hxx:177
     enum vcl::PDFWriter::StructAttributeValue Decimal
 include/vcl/pdfwriter.hxx:177
     enum vcl::PDFWriter::StructAttributeValue Square
-include/vcl/pdfwriter.hxx:177
-    enum vcl::PDFWriter::StructAttributeValue LowerRoman
 include/vcl/pdfwriter.hxx:177
     enum vcl::PDFWriter::StructAttributeValue UpperAlpha
+include/vcl/pdfwriter.hxx:177
+    enum vcl::PDFWriter::StructAttributeValue LowerRoman
 include/vcl/pdfwriter.hxx:177
     enum vcl::PDFWriter::StructAttributeValue UpperRoman
 include/vcl/prntypes.hxx:38
@@ -590,11 +586,11 @@ include/vcl/ptrstyle.hxx:78
     enum PointerStyle CopyFiles
 include/vcl/ptrstyle.hxx:92
     enum PointerStyle Chart
-include/vcl/vclenum.hxx:37
+include/vcl/vclenum.hxx:39
     enum MenuItemBits POPUPSELECT
-include/vcl/vclenum.hxx:143
+include/vcl/vclenum.hxx:145
     enum TimeFormat Hour12
-include/vcl/vclenum.hxx:148
+include/vcl/vclenum.hxx:150
     enum ExtTimeFieldFormat Short24H
 include/vcl/wall.hxx:36
     enum WallpaperStyle Center
@@ -642,9 +638,9 @@ sc/inc/token.hxx:214
     enum ScTableRefToken::Item DATA_TOTALS
 sc/inc/types.hxx:38
     enum ScMatValType NonvalueMask
-sc/source/ui/inc/viewdata.hxx:43
+sc/source/ui/inc/viewdata.hxx:44
     enum ScSplitMode SC_SPLIT_MODE_MAX_ENUM
-sc/source/ui/inc/viewdata.hxx:45
+sc/source/ui/inc/viewdata.hxx:46
     enum ScSplitPos SC_SPLIT_POS_MAX_ENUM
 sc/source/ui/StatisticsDialogs/RegressionDialog.cxx:106
     enum (anonymous namespace)::ScRegType LOGARITHMIC
@@ -675,11 +671,11 @@ scaddins/source/pricing/pricing.hxx:55
 sd/source/ui/slidesorter/cache/SlsRequestPriorityClass.hxx:40
     enum sd::slidesorter::cache::RequestPriorityClass MAX_CLASS
 slideshow/source/engine/shapes/viewshape.hxx:279
-    enum slideshow::internal::ViewShape::(anonymous at /media/noel/disk2/libo4/slideshow/source/engine/shapes/viewshape.hxx:279:13) MAX_RENDER_CACHE_ENTRIES
+    enum slideshow::internal::ViewShape::(anonymous at /home/noel/libo2/slideshow/source/engine/shapes/viewshape.hxx:279:13) MAX_RENDER_CACHE_ENTRIES
 slideshow/source/engine/slideview.cxx:249
-    enum slideshow::internal::(anonymous namespace)::LayerSpriteContainer::(anonymous at /media/noel/disk2/libo4/slideshow/source/engine/slideview.cxx:249:5) SPRITE_ULLAGE
+    enum slideshow::internal::(anonymous namespace)::LayerSpriteContainer::(anonymous at /home/noel/libo2/slideshow/source/engine/slideview.cxx:249:5) SPRITE_ULLAGE
 slideshow/source/engine/slideview.cxx:729
-    enum slideshow::internal::(anonymous namespace)::SlideView::(anonymous at /media/noel/disk2/libo4/slideshow/source/engine/slideview.cxx:729:5) LAYER_ULLAGE
+    enum slideshow::internal::(anonymous namespace)::SlideView::(anonymous at /home/noel/libo2/slideshow/source/engine/slideview.cxx:729:5) LAYER_ULLAGE
 soltools/cpp/cpp.h:42
     int WS
 svgio/inc/svgstyleattributes.hxx:62
@@ -738,8 +734,6 @@ svl/source/numbers/zformat.cxx:385
     enum BracketFormatSymbolType BRACKET_SYMBOLTYPE_NATNUM18
 svl/source/numbers/zformat.cxx:386
     enum BracketFormatSymbolType BRACKET_SYMBOLTYPE_NATNUM19
-svtools/source/contnr/imivctl.hxx:57
-    enum IconChoiceFlags StartEditTimerInMouseUp
 svx/source/inc/docrecovery.hxx:85
     enum EDocStates TryLoadBackup
 svx/source/inc/docrecovery.hxx:86
@@ -793,13 +787,13 @@ sw/source/core/inc/SwXMLBlockImport.hxx:108
 sw/source/core/text/pormulti.hxx:50
     enum RubyPosition RIGHT
 sw/source/core/unocore/unosett.cxx:1578
-    enum (anonymous at /media/noel/disk2/libo4/sw/source/core/unocore/unosett.cxx:1577:5) NotInChapterFirst
+    enum (anonymous at /home/noel/libo2/sw/source/core/unocore/unosett.cxx:1577:5) NotInChapterFirst
 sw/source/core/unocore/unosett.cxx:1579
-    enum (anonymous at /media/noel/disk2/libo4/sw/source/core/unocore/unosett.cxx:1577:5) NotInChapterLast
+    enum (anonymous at /home/noel/libo2/sw/source/core/unocore/unosett.cxx:1577:5) NotInChapterLast
 sw/source/core/unocore/unosett.cxx:1580
-    enum (anonymous at /media/noel/disk2/libo4/sw/source/core/unocore/unosett.cxx:1577:5) InChapterFirst
+    enum (anonymous at /home/noel/libo2/sw/source/core/unocore/unosett.cxx:1577:5) InChapterFirst
 sw/source/core/unocore/unosett.cxx:1581
-    enum (anonymous at /media/noel/disk2/libo4/sw/source/core/unocore/unosett.cxx:1577:5) InChapterLast
+    enum (anonymous at /home/noel/libo2/sw/source/core/unocore/unosett.cxx:1577:5) InChapterLast
 sw/source/filter/html/css1atr.cxx:116
     enum Css1FrameSize AnyHeight
 sw/source/filter/ww8/ww8scan.hxx:604
@@ -813,7 +807,7 @@ sw/source/uibase/inc/envimg.hxx:33
 sw/source/uibase/inc/envimg.hxx:34
     enum SwEnvAlign ENV_VER_CNTR
 tools/source/generic/poly.cxx:1110
-    enum (anonymous at /media/noel/disk2/libo4/tools/source/generic/poly.cxx:1110:5) maxRecursionDepth
+    enum (anonymous at /home/noel/libo2/tools/source/generic/poly.cxx:1110:5) maxRecursionDepth
 ucbhelper/source/client/proxydecider.cxx:119
     enum ucbhelper::proxydecider_impl::InternetProxyDecider_Impl::ProxyType Automatic
 vcl/inc/fontsubset.hxx:41
@@ -828,6 +822,8 @@ vcl/source/gdi/pdfwriter_impl.hxx:73
     enum GraphicsStateUpdateFlags MapMode
 vcl/source/gdi/pdfwriter_impl.hxx:78
     enum GraphicsStateUpdateFlags TransparentPercent
+vcl/source/window/printdlg.cxx:62
+    enum (anonymous at /home/noel/libo2/vcl/source/window/printdlg.cxx:59:1) ORIENTATION_PORTRAIT
 writerfilter/source/ooxml/OOXMLFactory.hxx:39
     enum writerfilter::ooxml::ResourceType List
 writerfilter/source/ooxml/OOXMLFactory.hxx:40

compilerplugins/clang/unusedenumconstants.untouched.results

-chart2/source/controller/dialogs/dlg_DataSource.cxx:83
-    enum chart::DataSourceDialogPages TP_RANGECHOOSER
-chart2/source/controller/dialogs/dlg_DataSource.cxx:84
-    enum chart::DataSourceDialogPages TP_DATA_SOURCE
 drawinglayer/source/tools/emfpimage.hxx:31
     emfplushelper::ImageDataType ImageDataTypeUnknown
 include/connectivity/dbtools.hxx:822
@@ -14,8 +10,6 @@ include/desktop/exithelper.h:27
     int EXITHELPER_FATAL_ERROR
 include/editeng/borderline.hxx:128
     enum SvxBorderLineStyle BORDER_LINE_STYLE_MAX
-include/editeng/editstat.hxx:83
-    enum EditStatusFlags CRSRLEFTPARA
 include/i18nutil/transliteration.hxx:45
     enum TransliterationFlags NumToTextLower_zh_CN
 include/i18nutil/transliteration.hxx:47
@@ -48,14 +42,14 @@ include/unotools/sharedunocomponent.hxx:149
     enum utl::SharedUNOComponent<class com::sun::star::beans::XPropertySet, class utl::DisposableComponent>::AssignmentMode NoTakeOwnership
 include/unotools/sharedunocomponent.hxx:149
     enum utl::SharedUNOComponent<class com::sun::star::sdbc::XPreparedStatement, class utl::DisposableComponent>::AssignmentMode NoTakeOwnership
+include/unotools/sharedunocomponent.hxx:149
+    enum utl::SharedUNOComponent<class com::sun::star::sdb::XSingleSelectQueryComposer, class utl::DisposableComponent>::AssignmentMode NoTakeOwnership
 include/unotools/sharedunocomponent.hxx:149
     enum utl::SharedUNOComponent<class com::sun::star::sdbc::XStatement, class utl::DisposableComponent>::AssignmentMode NoTakeOwnership
 include/unotools/sharedunocomponent.hxx:149
     enum utl::SharedUNOComponent<class com::sun::star::uno::XInterface, class utl::DisposableComponent>::AssignmentMode NoTakeOwnership
 include/unotools/sharedunocomponent.hxx:149
     enum utl::SharedUNOComponent::AssignmentMode NoTakeOwnership
-include/unotools/sharedunocomponent.hxx:149
-    enum utl::SharedUNOComponent<class com::sun::star::sdb::XSingleSelectQueryComposer, class utl::DisposableComponent>::AssignmentMode NoTakeOwnership
 include/unotools/sharedunocomponent.hxx:149
     enum utl::SharedUNOComponent<class com::sun::star::embed::XStorage, class utl::DisposableComponent>::AssignmentMode NoTakeOwnership
 include/vcl/keycod.hxx:29
@@ -72,26 +66,26 @@ include/vcl/keycod.hxx:30
     enum KeyFuncType QUIT
 include/vcl/keycod.hxx:32
     enum KeyFuncType FIND
-include/vcl/keycod.hxx:33
-    enum KeyFuncType PROPERTIES
 include/vcl/keycod.hxx:33
     enum KeyFuncType FINDBACKWARD
+include/vcl/keycod.hxx:33
+    enum KeyFuncType PROPERTIES
 include/vcl/syswin.hxx:54
     enum WindowStateState FullScreen
 include/vcl/window.hxx:118
     enum TrackingEventFlags Focus
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:61
-    enum (anonymous at /media/noel/disk2/libo4/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:59:1) PROP_0
+    enum (anonymous at /home/noel/libo2/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:59:1) PROP_0
 libreofficekit/source/gtk/lokdocview.cxx:287
-    enum (anonymous at /media/noel/disk2/libo4/libreofficekit/source/gtk/lokdocview.cxx:285:1) PROP_0
+    enum (anonymous at /home/noel/libo2/libreofficekit/source/gtk/lokdocview.cxx:285:1) PROP_0
 sc/source/filter/excel/xiescher.cxx:460
-    enum (anonymous at /media/noel/disk2/libo4/sc/source/filter/excel/xiescher.cxx:460:17) eCreateFromOffice
+    enum (anonymous at /home/noel/libo2/sc/source/filter/excel/xiescher.cxx:460:17) eCreateFromOffice
 sc/source/filter/inc/decl.h:24
     enum WKTYP eWK4
 sc/source/ui/inc/anyrefdg.hxx:192
-    enum ScRefHdlrImpl::(anonymous at /media/noel/disk2/libo4/sc/source/ui/inc/anyrefdg.hxx:192:5) SLOTID
+    enum ScRefHdlrImpl<class ScValidationDlg, class SfxTabDialog, false>::(anonymous at /home/noel/libo2/sc/source/ui/inc/anyrefdg.hxx:192:5) SLOTID
 sc/source/ui/inc/anyrefdg.hxx:192
-    enum ScRefHdlrImpl<class ScValidationDlg, class SfxTabDialog, false>::(anonymous at /media/noel/disk2/libo4/sc/source/ui/inc/anyrefdg.hxx:192:5) SLOTID
+    enum ScRefHdlrImpl::(anonymous at /home/noel/libo2/sc/source/ui/inc/anyrefdg.hxx:192:5) SLOTID
 sc/source/ui/StatisticsDialogs/RegressionDialog.cxx:105
     enum (anonymous namespace)::ScRegType LINEAR
 svx/inc/sxmkitm.hxx:25
@@ -150,10 +144,10 @@ vcl/inc/unx/saldisp.hxx:65
     srv_vendor_t vendor_none
 vcl/source/gdi/CommonSalLayout.cxx:129
     enum (anonymous namespace)::VerticalOrientation Rotated
-vcl/unx/gtk3/gtk3gtkinst.cxx:2645
-    enum (anonymous at /media/noel/disk2/libo4/vcl/unx/gtk3/gtk3gtkinst.cxx:2643:1) PROP_0
-vcl/unx/gtk3/gtk3gtkinst.cxx:2650
-    enum (anonymous at /media/noel/disk2/libo4/vcl/unx/gtk3/gtk3gtkinst.cxx:2643:1) PROP_SHADOW_TYPE
+vcl/unx/gtk3/gtk3gtkinst.cxx:2717
+    enum (anonymous at /home/noel/libo2/vcl/unx/gtk3/gtk3gtkinst.cxx:2715:1) PROP_0
+vcl/unx/gtk3/gtk3gtkinst.cxx:2722
+    enum (anonymous at /home/noel/libo2/vcl/unx/gtk3/gtk3gtkinst.cxx:2715:1) PROP_SHADOW_TYPE
 writerfilter/source/ooxml/OOXMLFactory.hxx:36
     enum writerfilter::ooxml::ResourceType NoResource
 writerfilter/source/ooxml/OOXMLFactory.hxx:37