loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)

Change-Id: Ib9c9daa113fecff495a51dca1bfaace1239b6ebc

fpicker/source/office/PlacesListBox.cxx

@@ -76,12 +76,12 @@ PlacesListBox::PlacesListBox( vcl::Window* pParent, SvtFileDialog* pFileDlg, con
     mpImpl->SetDoubleClickHdl( LINK( this, PlacesListBox, DoubleClick ) ) ;
 
     mpAddBtn.reset( VclPtr<ImageButton>::Create( this, 0 ) );
-    mpAddBtn->SetText( OUString( "+" ) );
+    mpAddBtn->SetText( "+" );
     mpAddBtn->SetPosSizePixel( Point( 0, 0 ), Size( 22, 22 ) );
     mpAddBtn->Show();
 
     mpDelBtn.reset( VclPtr<ImageButton>::Create( this, 0 ) );
-    mpDelBtn->SetText( OUString( "-" ) );
+    mpDelBtn->SetText( "-" );
     mpDelBtn->SetPosSizePixel( Point( 0, 0 ), Size( 22, 22 ) );
     mpDelBtn->Show();
 }

fpicker/source/office/RemoteFilesDialog.cxx

@@ -305,7 +305,7 @@ void RemoteFilesDialog::dispose()
         sSize = sSize + OUString::number( aSize.Height() ) + "|";
 
         OUString sUserData = m_pFileView->GetConfigString();
-        aDlgOpt.SetUserItem( OUString( "UserData" ),
+        aDlgOpt.SetUserItem( "UserData",
                              makeAny( sSize + sUserData ) );
     }
 
@@ -438,7 +438,7 @@ void RemoteFilesDialog::InitSize()
     {
         SetWindowState( OUStringToOString( aDlgOpt.GetWindowState(), osl_getThreadTextEncoding() ) );
 
-        Any aUserData = aDlgOpt.GetUserItem( OUString( "UserData" ) );
+        Any aUserData = aDlgOpt.GetUserItem( "UserData" );
         OUString sCfgStr;
         if( aUserData >>= sCfgStr )
         {

fpicker/source/office/commonpicker.cxx

@@ -56,13 +56,13 @@ namespace svt
     {
         // the two properties we have
         registerProperty(
-            OUString( "HelpURL" ), PROPERTY_ID_HELPURL,
+            "HelpURL", PROPERTY_ID_HELPURL,
             PropertyAttribute::TRANSIENT,
             &m_sHelpURL, cppu::UnoType<decltype(m_sHelpURL)>::get()
         );
 
         registerProperty(
-            OUString( "Window" ), PROPERTY_ID_WINDOW,
+            "Window", PROPERTY_ID_WINDOW,
             PropertyAttribute::TRANSIENT | PropertyAttribute::READONLY,
             &m_xWindow, cppu::UnoType<decltype(m_xWindow)>::get()
         );

fpicker/source/office/iodlg.cxx

@@ -515,7 +515,7 @@ void SvtFileDialog::dispose()
         SvtViewOptions aDlgOpt( E_DIALOG, _pImp->_aIniKey );
         aDlgOpt.SetWindowState(OStringToOUString(GetWindowState(), osl_getThreadTextEncoding()));
         OUString sUserData = _pFileView->GetConfigString();
-        aDlgOpt.SetUserItem( OUString( "UserData" ),
+        aDlgOpt.SetUserItem( "UserData",
                              makeAny( sUserData ) );
     }
 
@@ -758,7 +758,7 @@ void SvtFileDialog::Init_Impl
     /// read our settings from the configuration
     m_aConfiguration = OConfigurationTreeRoot::createWithComponentContext(
         ::comphelper::getProcessComponentContext(),
-        OUString( "/org.openoffice.Office.UI/FilePicker" )
+        "/org.openoffice.Office.UI/FilePicker"
     );
 
     _pContainer->init(_pImp, _pFileView, _pSplitter, _pImp->_pBtnNewFolder, _pImp->_pEdFileName);
@@ -2043,7 +2043,7 @@ short SvtFileDialog::PrepareExecute()
         // if applicable set respectively create filter for all files
         if ( !bHasAll )
         {
-            SvtFileDialogFilter_Impl* pAllFilter = implAddFilter( aAll, OUString(FILEDIALOG_FILTER_ALL) );
+            SvtFileDialogFilter_Impl* pAllFilter = implAddFilter( aAll, FILEDIALOG_FILTER_ALL );
             _pImp->InsertFilterListEntry( pAllFilter );
             _pImp->SetCurFilter( pAllFilter, aAll );
         }
@@ -2295,7 +2295,7 @@ void SvtFileDialog::InitSize()
     {
         SetWindowState(OUStringToOString(aDlgOpt.GetWindowState(), osl_getThreadTextEncoding()));
 
-        Any aUserData = aDlgOpt.GetUserItem( OUString( "UserData" ));
+        Any aUserData = aDlgOpt.GetUserItem( "UserData");
         OUString sCfgStr;
         if ( aUserData >>= sCfgStr )
             _pFileView->SetConfigString( sCfgStr );