Initialize some OUString with proper value

Change-Id: I2f5676e9973d476aa709f9dfb4a903b09edaafeb
Reviewed-on: https://gerrit.libreoffice.org/67336
Tested-by: Jenkins
Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>

sw/source/core/graphic/ndgrf.cxx

@@ -569,10 +569,11 @@ void SwGrfNode::InsertLink( const OUString& rGrfName, const OUString& rFltName )
         if( rFltName == "DDE" )
         {
             sal_Int32 nTmp = 0;
-            OUString sApp, sTopic, sItem;
-            sApp = rGrfName.getToken( 0, sfx2::cTokenSeparator, nTmp );
-            sTopic = rGrfName.getToken( 0, sfx2::cTokenSeparator, nTmp );
-            sItem = rGrfName.copy( nTmp );
+            // Cannot use getToken as argument in function call:
+            // evaluation order is undefined!
+            const OUString sApp{ rGrfName.getToken( 0, sfx2::cTokenSeparator, nTmp ) };
+            const OUString sTopic{ rGrfName.getToken( 0, sfx2::cTokenSeparator, nTmp ) };
+            const OUString sItem{ rGrfName.copy( nTmp ) };
             rIDLA.GetLinkManager().InsertDDELink( refLink.get(),
                                             sApp, sTopic, sItem );
         }