loplugin:constfields in shell

Change-Id: Ib30c45bddcc58fcd0fec8b160eb925349e801df7
Reviewed-on: https://gerrit.libreoffice.org/61551
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

shell/inc/xml_parser.hxx

@@ -97,7 +97,7 @@ private:
 
 private:
     i_xml_parser_event_handler* document_handler_;
-    XML_Parser xml_parser_;
+    XML_Parser const xml_parser_;
 
 private:
     xml_parser(const xml_parser&) = delete;

shell/source/tools/lngconvex/cmdline.hxx

@@ -69,8 +69,8 @@ private:
     static bool is_arg_name(const std::string& Argument);
 
 private:
-    size_t      m_argc;
-    char**      m_argv;
+    size_t const      m_argc;
+    char** const      m_argv;
 
 // prevent copy and assignment
 private:

shell/source/tools/lngconvex/lngconvex.cxx

@@ -143,7 +143,7 @@ public:
     }
 private:
     std::ios& m_IoStrm;
-    std::ios::iostate m_OldIos;
+    std::ios::iostate const m_OldIos;
 };
 
 class iso_lang_identifier

shell/source/unix/sysshell/recently_used_file_handler.cxx

@@ -340,7 +340,7 @@ namespace /* private */ {
         bool operator() (const std::unique_ptr<recently_used_item> & item) const
             { return (item->uri_ == uri_); }
     private:
-        string_t uri_;
+        string_t const uri_;
     };